0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
ghost/core/server
Rishabh 196cdafe6b 💡 Removed 401 error for logged-out member on Portal
closes https://github.com/TryGhost/Team/issues/560
closes https://github.com/TryGhost/Ghost/issues/12870

The endpoint `/members/api/member/` is used by Portal for fetching member details on site load to setup different flows. The response from this endpoint for logged out member has now changed from 401 Unauthorized to 204 No Content.

Ghost API was previously returning 401 Unauthorized error for logged-out member as this seemed to be technically correct response for unauthorized access to membership features. This resulted in a lot of confusion for end users where visible 401 errors on console were perceived as errors in the script as well as caught by loggers as erroneous traffic. Also for an end user, in the context of visiting a website - the user themselves is not trying to gain access to anything so this becomes cause for more confusion.

After internal discussion, the endpoint - [SITE_URL]/members/api/member- now returns 204 No Content instead of 401 for logged out member, denoting server was able to process the request but did not find any associated member. This should avoid any unwanted error logging on Portal load on a site, as well as make Portal functioning more transparent for a site.
2021-05-13 15:26:07 +05:30
..
adapters Moved i18n to shared 2021-05-04 13:03:38 +01:00
api Fixed typos 2021-05-12 17:06:10 +04:00
data Added support for gating content by member labels and products (#12946) 2021-05-10 19:32:11 +01:00
lib Extracted package-json lib to Utils 2021-05-07 12:35:06 +01:00
models Added support for gating content by member labels and products (#12946) 2021-05-10 19:32:11 +01:00
public
services 💡 Removed 401 error for logged-out member on Portal 2021-05-13 15:26:07 +05:30
views
web Moved i18n to shared 2021-05-04 13:03:38 +01:00
analytics-events.js Expanded requires of lib/common i18n and events 2021-05-03 17:14:52 +01:00
ghost-server.js Refactored urlUtils out of ghost-server 2021-05-05 14:24:59 +01:00
notify.js
overrides.js
update-check.js Moved i18n to shared 2021-05-04 13:03:38 +01:00