Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity
6831 commits 234 branches 1697 tags 546 MiB
Commit graph

1975 commits

Author SHA1 Message Date
Austin Burdine
25a9b4aa3a 🔥 remove preinstall node version check (#7403) 
no issue
- this is now handled in Ghost-CLI
 2016-09-20 15:59:34 +01:00
kirrg001
8115d83782 🔥 remove postgres support 
refs #1333, refs #5878, refs #5321
 2016-09-20 15:59:34 +01:00
kirrg001
231fea4766 🎨 adaption from master merge 
no issue
[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
6a97873f98 🎨 🔦 refactor content paths (images, apps, themes, storage, scheduling) 
refs #6982
- create config util fn: getContentPath
- we can later let the user change the folder names in contentPath
- get rid of custom/default storage paths

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
248ceba72b 🎨 adapt bootstrap file because of nconf changes 
refs #6982
- remove load config
- remove checkDeprecated
- adapt arguments for scheduling init

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
042e0da1c9 🎨 🔦 read ghost version from package.json 
refs #6982
[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
d42f4f6058 🎨 replace config.getSocket() 
refs #6982
- was a function in ConfigManager
- does belong to the GhostServer logic

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
f4bee50e86 🎨 create assetHash if not available in asset_url helper 
refs #6982
- was before generated in ConfigManager

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
b3bafa4ba8 🎨 🔦 restrict themes storage to local-file-store 
refs #6982
- this was handled before by the old ConfigManager
- this logic belongs into the storage logic itself
- for now we only allow uploading themes via the local-file-store

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
1f85604d09 🎨 remove circular dependency solution in errors/index.js 
refs #6982
[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
34e48dc49a 🎨 🔦 do not append isPostgreSQL to config 
refs #6982
- we cannot add functions to nconf

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
0ae0a0b490 🎨 change how we get and set config 
refs #6982
- a replace for all config usages
- always use config.get or config.set
- this a pure replacement, no logic has changed

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
7d3e8fa8a9 ✨ 🔦 add nconf files 
refs #6982
- add defaults.json
- add overrides.json
- add env specific default values
- add nconf wrapper in /config
- add config utils in /config/utils.js

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
96203a46dc 🔥 remove config.example.js and ConfigManager 
refs #6982
[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
e3c0200f73 🔥 remove startup checks 
refs #6982
- we will execute the startup checks in Ghost-CLI

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
0b2940d587 🎨 add getSubdir and getProtectedSlugs 
refs #6982

- do not add the subdir property as static config value
- create functions to read subdir and protected slugs on runtime
 2016-09-20 15:59:34 +01:00
Katharina Irrgang
c8119eee1f 🎨 source out url utils from ConfigManager (#7347) 
refs #6982
 2016-09-20 15:59:34 +01:00
Katharina Irrgang
dc1ef35f0c 🎨 do not load apps in ConfigManager (#7344) 
refs #6982
 2016-09-20 15:59:34 +01:00
Katharina Irrgang
a639e48715 🎨 load themes not in ConfigManager (#7342) 
refs #6982
 2016-09-20 15:59:34 +01:00
Austin Burdine
756d9bcb6e show correct error message the first time account is locked (#7263) 
closes #7251

- check if remaining attemps is 0, if so then show account locked error
- adds test
 2016-09-19 14:56:55 +01:00
Katharina Irrgang
9349e99e54 🐛 fix delete by author as transaction (#7145) 
closes #7137

Deleting the content from the database runs in a transaction. see
https://github.com/TryGhost/Ghost/blob/master/core/server/api/users.js#L390

`destroyByAuthor` is one of the operations we trigger to delete all the conent, see https://github.com/TryGhost/Ghost/blob/master/core/server/models/post.js#L647

The post model has a specific hook for deleting content to delete the relations as well, see https://github.com/TryGhost/Ghost/blob/master/core/server/models/post.js#L122

This hook is part of the transaction. But the `options` are ignored. `(model/*, attr, options*/)` 
We use the `options` to forward the transaction reference, which we need to pass into the bookshelf queries. So `return model.load('tags').call('related', 'tags').call('detach')` does not forward the transaction and that's why it stucks when deleting the content.
 2016-09-19 14:45:36 +01:00
Katharina Irrgang
265f058466 🎨 use apiUrl helper for scheduling initialisation (#7400) 
no issue
- extend apiUrl to return either an admin url for CORS or not
 2016-09-19 14:41:50 +01:00
Cezary Kluczyński
83b426ad14 Changed formatting of run time to human readable (#7318) 2016-09-19 11:28:18 +01:00
Katharina Irrgang
ed9e90419d 🐛 generate correct apiUrl for scheduling (#7389) 
closes #7388
 2016-09-15 10:22:38 +01:00
Hannah Wolfe
a791b43f1e 🐛 😱 Fixing extract-zip derp-moment 
There are no words for this!
 2016-09-14 22:47:41 +01:00
David Wolfe
1cf0b940ad Do not show internal tags in RSS feed (#7385) 
closes #7367

- checks tags are visibile if internal tags are enabled in labs
- dirty quick update to tests
 2016-09-14 19:14:08 +01:00
Hannah Wolfe
a40ff3b276 🎨 Return gscan warnings from theme API (#7367) 
- return warnings from gscan so we can let users know about potential issues
 2016-09-14 18:49:41 +01:00
Hannah Wolfe
de66a61f59 hides internal tags from displaying in meta data (#7379) 
closes #7348

- only filter keywords if the internal tag lab feature is turned on
 2016-09-14 17:33:24 +00:00
Hannah Wolfe
43bcf5b374 🐛 better theme name consistency (#7380) 
closes #7313

- Adds `getSanitizedFileName` function to storage/base.js which replaces non A-Z0-9@. chacracters with -
- modifies /api/theme.js so that zip.shortName is consistent throughout.
 2016-09-14 17:24:28 +00:00
Austin Burdine
2b07f7a15b Add application/octet-stream to allowed types for theme uploads (#7382) 
closes #7292 (again)
- fix more uploads
 2016-09-14 17:53:36 +01:00
Katharina Irrgang
774a662fb2 🐛 re-run migration for sqlite/pg (#7323) 
closes #7192

- add 008 migration
- added script to re-run 006/01
- re-run 006/01 migration for postgres in any timezone (transform formats only)
- re-run 006/01 migration for sqlite (transform formats only)
- rely on format checks for sqlite, do not check server TZ
 2016-09-14 17:52:45 +01:00
Aileen Nowak
b598656ff1 ✨ Use migration to add AMP column in posts table (#7370) 
no issue

Uses migration to '008' to add an `amp` column to the `posts` table.
 2016-09-14 16:02:35 +01:00
Katharina Irrgang
94fdbdd267 🐛 move overrides into core folder (#7371) 
closes #7336
- make sure overrides is still the first package to call
 2016-09-14 15:50:17 +01:00
Austin Burdine
78f580763f ensure amp works when blog is running in subdirectory (#7353) 
closes #7352
- use relative url instead of absolute url for post lookup
- add test that passes w/these changes
 2016-09-14 12:47:25 +01:00
Sebastian Gierlinger
03ca49ca5e Respect subdirectory for preview pages (#7365) 
no issue
- added subdirectory for preview route when doing cache invalidation
 2016-09-14 12:32:48 +01:00
Aileen Nowak
a4427952e2 ⬆️ 🚨 Update Amperize dep and fix test (#7374) 
no issue

Updates Amperize dep to v0.3.1 and fixes test for `amp_content`.
 2016-09-14 12:30:37 +01:00
Katharina Irrgang
8c1e5fbc61 🐛 add missing dependency lodash.orderBy (#7333) 
no issue
 2016-09-14 11:22:16 +01:00
Katharina Irrgang
5f4da361aa 🐛 fix 006 transform dates for sqlite server offset 0 (#7322) 
refs #7192, refs #7248, refs #7351
 2016-09-14 11:19:39 +01:00
Hannah Wolfe
4287e0e78b 🐛 Reactivate theme on override + cache clear (#7368) 
closes #7350

- When the active theme is overridden, ensure that the activateTheme middleware gets called by removing the `req.app.activeTheme` value.
- Additionally, ensure that the full cache is invalidated
 2016-09-14 10:18:52 +00:00
Ryan McCarvill
98a17d5116 fix: Empty Sitemap.xml (#7354) 
closes #7341
 2016-09-14 10:44:08 +02:00
Aileen Nowak
b3b1bcca94 🐛 Return reg. HTML on Amperize time-out (#7324) 
no issue

`{{amp_content}}` helper can handle error now, if returned from `Amperize` module. In case of on error, we return the unprocessed HTML, which will then get validated by the `Sanitize` functionality.

The unprocessed HTML will be stored in the cache, until the post is updated.

Points to Amperize fork of AileenCGN as dependency to have include the error handling changes incl. timeouts.
 2016-09-06 15:29:21 +02:00
Hannah Wolfe
761d963893 💄 Output overall from -> to version during migration (#7329) 
no issue

- Migrations weren't clear what version the database was
 2016-09-06 13:59:54 +02:00
Katharina Irrgang
2142a9c587 🐛 fix direct blog migration and permission fixture options (#7320) 
* 🐛 fix direct update

closes #7297
- move sitemap initialisation into sitemap handler
- initialise sitemap on first request to sitemap

* 🐛 fix how we pass options to migration files

refs #7317
- clone options when passing them into the migration/fixture files
- do not use default sequence, because it does not clone the arguments
 2016-09-06 13:16:32 +02:00
Kevin Ansfield
0b6459cb91 Fix upgrade notification type value (#7308) 
refs #7305

* 🎨 display upgrade alerts with the correct "info" style
* 💄 update use of notifications status/type/location attrs to reflect current usage
 2016-09-01 17:58:46 +02:00
Aileen Nowak
11436317c0 🐛 Remove oldschool HTML attribrutes (#7309) 
no issue

Uses `allowedAttributes` functionality of `Sanitize` HTML and whitelists attributes for certain tags, regarding
AMP validation rules.

This PR fixes issues with inline style like `border`, `bgcolor`, `align` and so on.
 2016-09-01 16:05:39 +02:00
Austin Burdine
7854b65848 fix subscriber uploads from windows (#7306) 
no issue
- allow 'application/octet-stream' as a valid content type for an
  uploaded subscriber csv
 2016-09-01 12:43:50 +02:00
Katharina Irrgang
54559f24f9 fix: memory leak (#7291) 
closes #7189

- downgrade lodash to 3.x
- downgrade bookshelf to 0.9.x
- downgrade knex to 0.10.x
- keep lodash 4.x functions
 2016-09-01 10:53:08 +02:00
Austin Burdine
c8bc1b0d3c allow windows flavor of zip mime type to be uploaded (#7293) 
refs #7292
- add 'application/x-zip-compressed' to allowed mime types for import
  and theme upload
 2016-09-01 08:49:54 +02:00
Aileen Nowak
587337aab3 🐛 Allow .zip file upload for file import (#7278) 
closes #7277

Adds `.zip` to `extensions` and `application/zip` to `contentTypes` in config, specificly for uploads to `db`, to allow .zip-file file uploads from labs.
 2016-08-29 09:19:49 +02:00
Aileen Nowak
1bc1f165f1 💄 Add post image to AMP template and style fixes (#7272) 
no issue

Will show the post image on top of the AMP page, if image is uploaded.
Some minor style changes.
 2016-08-26 12:28:45 +02:00