5 commits

Author	SHA1	Message	Date
Naz	7252f03824	Improved assertions ... refs https://github.com/TryGhost/Toolbox/issues/283	2022-05-12 13:54:21 +08:00
Naz	a1e1feb125	Added 'Content-Version' header to outgoing webhook requests ... refs https://github.com/TryGhost/Toolbox/issues/283 - The header is needed to signal to the webhook subscribers the content version they are being served. This should imrove API version compatibility and allow for the client to handle incoming data better	2022-05-12 13:54:21 +08:00
Naz	2a3be178ab	Refactored trigger test to us assert instead of should ... refs https://github.com/TryGhost/Toolbox/issues/283 - Should assertion library is outdated and it's preferred to use native assert to make assertions	2022-05-12 13:54:21 +08:00
Naz	21c2c5579b	Refactored webhook triggering to be asyc ... refs https://github.com/TryGhost/Toolbox/issues/283 - In tests we need assurance that the triggering of webhooks has been finished before making assertions. Doing this was impossible with a previous fire-and-forget style of the request call. - The change also adds an optional "request" parameter to be able to override the request library used internally - this is purely for testing purposes.	2022-05-12 13:54:21 +08:00
Naz	67dca08df8	Refactored trigger module to be testable ... refs https://github.com/TryGhost/Toolbox/issues/283 - Current trigger module handling webhook paypload delivery isn't testable! It sucks to add features to it without assurance things still work - Apart from expanding the test suite this changeset also needs live testing - setting up webhooks etc.	2022-05-12 13:54:21 +08:00