Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
Code Issues Activity
39939 commits 234 branches 1694 tags 532 MiB
Commit graph

53 commits

Author SHA1 Message Date
Michael Barrett
2e9dbd3ef0
Fixed suggested accounts not rendering in admin-x-activitypub (#21655) 
refs
[AP-606](https://linear.app/ghost/issue/AP-606/suggested-accounts-not-rendering-due-to-404)

Some of the suggested accounts in `admin-x-activitypub` were not
rendering due to the requests for the data returning a 404. This was due
to incorrect account handles being used. This commit fixes the issue by
ensuring the correct handles are being used. This commit also adds a new
hook to handle the fetching of suggested accounts that also limits and
randomizes the accounts returned.
 2024-11-20 14:07:05 +00:00
Djordje Vlaisavljevic
232c897fa3
Split inbox and feed into separate tabs (#21642) 
close https://linear.app/ghost/issue/AP-600/separate-feed-and-inbox-screens

- Instead of the layout switcher, we now have separate Inbox and Feed
tabs
- Inbox only shows long-form content (Articles)
- Feed only shows short-form content (Notes)
 2024-11-19 17:04:39 +00:00
Djordje Vlaisavljevic
dc8f553fc3 Updated feed view layout so it's more compact 
close https://linear.app/ghost/issue/AP-464/feed-view-visual-refinements
 2024-11-19 13:27:55 +00:00
Djordje Vlaisavljevic
998ade4632
Added loading state to Your Profile page (#21638) 
close
https://linear.app/ghost/issue/AP-515/add-loading-state-to-your-profile-page
 2024-11-18 17:52:45 +00:00
Djordje Vlaisavljevic
86641268ab Stopped HTML cards with fixed width from causing overflow in the drawer 
close https://linear.app/ghost/issue/AP-557/elements-in-articles-can-cause-horizontal-scrolling
 2024-11-14 17:45:59 +00:00
Djordje Vlaisavljevic
2a0ad25edc
Fixed activity badges not showing when the user doesn't have a profile icon (#21609) 
ref https://linear.app/ghost/issue/AP-575/badges-are-not-showing-up-on-placeholder-avatars
 2024-11-14 11:15:00 +00:00
Fabien 'egg' O'Carroll
d555cc6612
Handled non-string preferredUsername values (#21598) 
ref https://linear.app/ghost/issue/AP-585

If preferredUsername is not a string, and we attempt to render it, we
will crash the entire React application!
 2024-11-12 21:22:45 +07:00
Djordje Vlaisavljevic
ea11367ea4
Stopped loading spinner flash when you first open Search page (#21569) 
close
https://linear.app/ghost/issue/AP-531/search-spinner-flashes-for-a-split-second-when-switching-tab-for-the

- Fixed the logic for displaying “loading” and “no results found” states
- Refactored the component to avoid nested ternaries
 2024-11-11 11:36:04 +00:00
Djordje Vlaisavljevic
b55ac9a03a
Fixed Articles appearing squeezed when opened from Notifications or Profile (#21587) 
close
https://linear.app/ghost/issue/AP-581/article-content-appears-squeezed-when-opened-from-notifications-or
 2024-11-11 09:31:04 +00:00
Djordje Vlaisavljevic
5138ef8ed3 Bumped admin-x-activitypub package 
ref https://linear.app/ghost/issue/AP-522/inbox-view-thumbnail-size-inconsistencies
 2024-11-07 17:36:03 +00:00
Djordje Vlaisavljevic
3709a4811e
Improved ActivityPub drawer view UI (#21521) 
ref https://linear.app/ghost/issue/AP-507/inbox-view-missing-min-width-for-inbox-card, https://linear.app/ghost/issue/AP-562/remove-unused-viewfollowersmodal-and-viewfollowingmodal-files, https://linear.app/ghost/issue/AP-559/add-post-stats-and-buttons-to-articles-in-drawer-view, https://linear.app/ghost/issue/AP-468/drawer-visual-refinements, https://linear.app/ghost/issue/AP-558/add-actor-info-to-articles-in-drawer-view, https://linear.app/ghost/issue/AP-573/add-anchor-link-to-replies-in-the-drawer

- Made `Articles` in drawer view wider for better reading experience
- Added `Actor` info to `Articles` in drawer view for more context about who posted it
- Added `Like` and `Reply` buttons and counters to `Articles` in drawer view
- Clicking on a Reply notification or Reply icon in the drawer view now scrolls you directly to replies
- Removed modals we’re no longer using
- Updated `RoutingProvider` so it can work without any modals passed to
it
 2024-11-07 15:59:29 +00:00
Fabien 'egg' O'Carroll
466d7fef3f
Bumb admin-x-activitypub to 0.3.10 (#21546) 
closes https://linear.app/ghost/issue/AP-523
 2024-11-06 11:07:17 +00:00
Michael Barrett
0316c3f16e
Updated admin-x-activitypub to use consistent URL encoding (#21493) 
refs
[TryGhost/ActivityPub](https://github.com/TryGhost/ActivityPub/pull/103)

Updated the API requests made by the `admin-x-activitypub` app to use
consistent URL encoding when making requests to the ActivityPub API
 2024-11-04 10:40:06 +00:00
Michael Barrett
3ecfe08e1d
Added failure state for reply in admin-x-activitypub (#21487) 
no refs

Added a failure state for when a reply fails to be sent
 2024-10-31 16:34:53 +00:00
renovate[bot]
085afdeb74 Pin dependency clsx to 2.1.1 2024-10-31 11:02:29 +00:00
Djordje Vlaisavljevic
45711e197c
AP design bugs (#21395) 
- Fixed links in profile description
- Stripped post content
- Fixed grey bg in Avatars
- Installed `clsx`

---------

Co-authored-by: Michael Barrett <mike@ghost.org>
 2024-10-31 10:50:51 +00:00
Djordje Vlaisavljevic
becfd13141
Refactored handleViewContent so it can be reused (#21468) 
ref
https://linear.app/ghost/issue/AP-540/clicking-comment-icon-on-posts-and-likes-tabs-of-your-profile-doesnt

- We want to open posts in the drawer from multiple views (Inbox,
Profile etc.) and this change allows us to do so by pulling
`handleViewContent` from `Inbox.tsx` into a utility function. At the
same time, we’ve simplified the function so it uses less props to
achieve the same functionality.
- Also added a simple fix for scrolling the reply-box into view when
opening a long `article` by clicking on the reply icon. We probably
still need to figure out a more robust solution, because the height of
the `iframe` and the fact it takes some time to load it sometimes gets
in the way.

Co-authored-by: Michael Barrett <mike@ghost.org>
 2024-10-31 09:58:47 +00:00
Michael Barrett
5f59ddaacc
Updated replies implementation to use thread mechanism in admin-x-activitypub (#21465) 
refs:

- https://linear.app/ghost/issue/AP-439/seeing-parent-post-for-replies
- https://linear.app/ghost/issue/AP-481/reply-ui
-
https://linear.app/ghost/issue/AP-482/replies-to-a-post-should-be-visible-when-opening-it

Updated the replies implementation to make use of the new thread
mechanism. This allows for a more sane approach to handling replies as
well as making it possible to show the parent of a reply in the UI

---------

Co-authored-by: Djordje Vlaisavljevic <dzvlais@gmail.com>
 2024-10-31 09:38:52 +00:00
Michael Barrett
28a9a431db
Prevent replies from being shown on profile page in admin-x-activitypub (#21454) 
refs
[AP-543](https://linear.app/ghost/issue/AP-543/posts-on-profile-should-not-include-replies)

Filtered the posts on the profile page to only show `Create` activities
that are not replies.
 2024-10-29 17:07:01 +00:00
Djordje Vlaisavljevic
cc8a36cc12
Fixed articles getting cut off in the drawer (#21447) 
ref
https://linear.app/ghost/issue/AP-542/articles-are-cut-off-when-viewed-in-sidebar

- We now wait for the content of the iframe to load completely before
determining the height needed to display it
 2024-10-29 10:26:27 +00:00
Michael Barrett
e6df621436
Updated ActivityPub collection retrieval to accommodate pagination (#21393) 
refs
[AP-526](https://linear.app/ghost/issue/AP-526/implement-pagination-for-fedify-collections)

Updated followers, following, outbox and liked collection retrieval to
accommodate pagination
 2024-10-29 09:46:43 +00:00
Fabien 'egg' O'Carroll
f8ef2a1cb6
Fixed layout state sync issues (#21443) 
refs https://linear.app/ghost/issue/AP-544

useState was still called twice, we should have pulled that out - but
instead passing values down for now
 2024-10-29 03:17:57 +00:00
Fabien 'egg' O'Carroll
d4b1f692ab
Persisted activitypub layout to localstorage 
closes https://linear.app/ghost/issue/AP-544

We're releasing this change immediately with v0.3.0
Also cleans up some props for the MainNavigation component.
 2024-10-28 18:39:28 +07:00
Djordje Vlaisavljevic
880c88a184 Bumped admin-x-activitypub package 
no ref
 2024-10-23 19:44:40 +01:00
Michael Barrett
3d430b453f
Opened follow notifications in profile viewer in admin-x-activitypub (#21384) 
refs
[#479](https://linear.app/ghost/issue/AP-479/open-profile-viewer-when-clicking-follow-notifications)

Clicking on a follow notification will now open the profile viewer with
details of the profile of the user that followed you

---------

Co-authored-by: Djordje Vlaisavljevic <dzvlais@gmail.com>
 2024-10-23 14:26:31 +01:00
Michael Barrett
1b468f333b
Added buttons to show more data on profile in admin-x-activitypub (#21373) 
no refs
 2024-10-22 21:29:46 +01:00
Michael Barrett
63afb15356
Added button to show more followers on profile in admin-x-activitypub (#21371) 
no refs
 2024-10-22 20:56:14 +01:00
Michael Barrett
e9914d8fe5
Fixed followers list on profile in admin-x-activitypub app (#21370) 
refs
[AP-489](https://linear.app/ghost/issue/AP-489/followers-showing-unknown-on-user-profile)

Fixed the followers list on profile in admin-x-activitypub app by
utilising a custom endpoint to fetch a list of expanded followers
seeming though the followers endpoint only returns follower id's
 2024-10-22 20:21:12 +01:00
Djordje Vlaisavljevic
7bc510f1c9 Bumped admin-x-activitypub to 0.1.5 
no ref
 2024-10-22 10:57:58 +01:00
Djordje Vlaisavljevic
5af25e1433 Bump admin-x-activitypub to 0.1.4 
no ref
 2024-10-22 09:33:40 +01:00
renovate[bot]
32419e4e07 Update dependency use-debounce to v10.0.4 2024-10-14 00:24:20 +00:00
Fabien O'Carroll
72d46a4706 Bumb admin-x-activitypub to 0.1.3 2024-10-08 20:09:32 +01:00
Michael Barrett
20cb63b9c6
Bump admin-x-activitypub to 0.1.2 (#21257) 
no refs
 2024-10-08 17:52:11 +01:00
Fabien O'Carroll
f7c46088f6 Bumbed admin-x-activitypub to 0.1.1 
This should roll out the fix for the ActivityPub API URL
 2024-10-06 21:57:05 +07:00
Michael Barrett
8fa9fb9c25
Updated search to be dynamic in admin-x-activitypub app (#21099) 
refs
[AP-352](https://linear.app/tryghost/issue/AP-352/search-for-mastodon-usernames-in-ghost-admin)

Updated the search functionality in the admin-x-activitypub app to be
dynamic and utilise the search API endpoint provided by the activitypub
service

---------

Co-authored-by: Djordje Vlaisavljevic <dzvlais@gmail.com>
 2024-09-30 11:32:05 +01:00
Fabien O'Carroll
146e702d93 Updated @tryghost/admin-x-activitypub to 0.1.0 
This will test the release when we merge to main
 2024-09-26 23:24:26 +07:00
Fabien O'Carroll
d9a2b0e3a6 Removed private flag 
This is necessary so that we can publish to npm
 2024-09-26 23:24:26 +07:00
Daniel Lockyer
0187d6b6a2 Fixed versioning and npm visibility for internal apps 
- these apps don't need to be published because they're internal and get
  compiled into Admin
- therefore, we can reset their versions back to 0.0.0 and remove the
  publishConfig block so we don't accidentally publish them
 2024-09-25 09:09:06 +02:00
Fabien O'Carroll
92c17ade34 Ensured types are checked as part of unit tests 
Otherwise we get green ticks on a PR and then the build fails on main
 2024-09-21 10:20:20 +07:00
Djordje Vlaisavljevic
6708787731 Added static reply box for ActivityPub content 
ref https://linear.app/tryghost/issue/AP-307/component-for-replying-to-objects-in-the-inboxfeed
 2024-09-21 09:39:42 +07:00
renovate[bot]
c96744156e
Update dependency @playwright/test to v1.46.1 (#20866) 2024-09-06 10:35:50 -07:00
Daniel Lockyer
33dd6b6b49 Removed concurrently from building apps 
ref https://linear.app/tryghost/issue/DEV-20/faster-builds

- we added concurrently because, in theory, it should make builds faster
  by utilizing more cores
- however, when combined with Nx, it seems that we are trying to exceed
  the number of cores, which actually makes individual builds slower
- I've removed concurrently from the apps, which should improve the
  build time significantly
 2024-09-02 12:06:27 +02:00
renovate[bot]
eb7024da34 Update testing-library monorepo 2024-08-07 09:59:15 +02:00
Fabien O'Carroll
bef58e1069 Removed nx build from test:unit script 
This slows down TDD workflows way too much
 2024-07-24 13:38:08 +07:00
Djordje Vlaisavljevic
a6c6114e6f
Added alternative layout for displaying ActivityPub articles (#20556) 
ref https://linear.app/tryghost/issue/MOM-244/add-alternative-inboxfeed-design, https://linear.app/tryghost/issue/MOM-256/fix-typescript-not-being-able-to-resolve-the-type

- Added a toggle for switching to an alternative layout for displaying
articles in the inbox
- Fixed actor icons not showing up in the inbox
- Fixed Typescript not being able to resolve the type for images
- Added Jest to make tests run

---------

Co-authored-by: Princi Vershwal <vershwal.princi@gmail.com>
 2024-07-08 15:11:01 +01:00
Fabien 'egg' O'Carroll
cb2150f33c
Added Ghost2Ghost ActivityPub feature that uses mock API (#20411) 
ref https://linear.app/tryghost/issue/MOM-108/ap-phase-two

Added a WIP version of the Ghost-to-Ghost ActivityPub feature behind the feature flag. Enabling it will add a new item to the main sidebar nav that lets you interact with our ActivityPub mock API in the following ways:
- Shows you the list of sites you follow
- Shows you the list of sites that follow you
- Shows you the articles published by sites you follow
- Shows you activities (who followed you or liked your article)
- Shows your liked articles

Mock API can be easily updated to simulate working with different types of data and interactions.
 2024-06-19 12:46:02 +01:00
renovate[bot]
f0c8be59a8 Update dependency @types/react to v18.3.3 2024-05-27 09:37:46 +02:00
renovate[bot]
484ba8873b Update Types packages 2024-05-13 09:04:16 +02:00
Daniel Lockyer
88ff804242 Simplified Nx dev config for AdminX ActivityPub package 
- we can avoid a lot of the unnecessary duplication by using the caret,
  which automatically includes dependencies
- also adds a config for `dev`
 2024-05-06 15:17:25 +02:00
renovate[bot]
ec626bd0cf Update react monorepo to v18.3.1 2024-05-02 11:46:13 +02:00