Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity
1028 commits 231 branches 1692 tags 528 MiB
Commit graph

761 commits

Author SHA1 Message Date
Hannah Wolfe
d841e749f9 Adding extra class for url uploads 2013-09-27 13:34:39 +01:00
Hannah Wolfe
ee8d8102db Merge pull request #923 from ErisDS/0.3.1-wip-mysql 
0.3.1 wip mysql
 2013-09-27 05:04:45 -07:00
Hannah Wolfe
5c10f6608c Unit Test fixes for MySQL 
issue #858

- there is no guaranteed order to arrays, so sort before testing them
- tests run much faster, date comparisons fail
- settings tests are more explicit, otherwise they fail random validations
- dates must be inserted as date objects
 2013-09-27 12:52:31 +01:00
Hannah Wolfe
d544b4aebb Custom destroy method for posts 
issue #858

- correctly handles detaching tags before deleting the post
 2013-09-27 11:56:20 +01:00
Hannah Wolfe
e6b779330f Correctly test for an empty Tag array 
issue #858

- fixes syntax errors in mysql
 2013-09-27 11:55:02 +01:00
Hannah Wolfe
71711c1fd2 Drop tables in correct order 
issue #858

- unit tests now run for MySQL
 2013-09-27 11:54:09 +01:00
Hannah Wolfe
50a16ceb76 Test Cleanup 2013-09-27 11:36:12 +01:00
Hannah Wolfe
e411ed6889 No autolinking inside of code blocks 
closes #865

- rejigged markdown to have some functionality before showdown runs, and other functionality before.
- autolinking now happens last, so it can be smarter
 2013-09-27 11:35:44 +01:00
Hannah Wolfe
8c6519fde7 Don't output image tag for empty source 
closes #866

 - ensures we don't end up creating any more empty image tags.
 2013-09-27 11:30:41 +01:00
Hannah Wolfe
6369eb20be Remove broken image from fixture 
issue #866

- this fixes the problem inside the fixture
 2013-09-27 09:18:02 +01:00
Jacob Gable
a9c0359f18 Add some unit tests for post saving 
- Confirm published_at for new posts
- Confirm slug generating on saving posts
 2013-09-26 23:15:43 +01:00
Jacob Gable
088518936c Configuration validation in config-loader 
Added a couple sanity checks to the config during the loadConfig call.

- Check that the config exists for the current NODE_ENV
- Check that the config.url exists and is valid structure
- Check that the config.database exists
- Check that the config.server exists and has a port and host value
 2013-09-26 23:07:48 +01:00
Hannah Wolfe
18ca744c98 Merge pull request #913 from ErisDS/0.3.1-html-handling 
Treat markdown as text in editor
 2013-09-26 14:53:37 -07:00
Sebastian Gierlinger
59b57b84e0 Fix partials in themes 
closes #884
- changed init sequence of ghost and helpers
 2013-09-26 22:30:45 +02:00
Hannah Wolfe
0ef99ad393 Merge pull request #912 from cobbspur/saveposition 
fixes position of save button in image uploader
 2013-09-26 13:26:01 -07:00
Hannah Wolfe
fc881229f4 Treat markdown as text in editor 
closes #857

- markdown is inserted into codemirror with .text() not .html()
 2013-09-26 21:06:52 +01:00
cobbspur
3119fc5388 fixes position of save button in image uploader 
closes #911

- adds display block to save button centre class
 2013-09-26 20:15:48 +01:00
cobbspur
2a55595191 Increased visibility of trash can in image uploader for broken url 
closes #838

- adds a min height value to pre-image-uploader scss
 2013-09-26 18:33:09 +01:00
Sebastian Gierlinger
3def65ee11 Fix for sendmail problem 
closes #871
- added solution from email
- tested on OSX
 2013-09-26 15:45:34 +01:00
Sebastian Gierlinger
fa43ca79d3 Add content to RSS 
closes #886
- removed meta_description which is empty and would have crashed
- added content
- img src converted to absolute path
- a href converted to absolute path
 2013-09-26 15:37:25 +01:00
John O'Nolan
58873a9fc3 Stripped obsolete CSS3 prefixes 2013-09-26 15:26:00 +01:00
jamesbloomer
55048d6a20 Fix image upload tests on windows 
closes #826
- on windows the fs.exists call had windows style back slashes
- set up the test to cope with either (not the most elegant but works)
 2013-09-26 15:19:05 +01:00
John O'Nolan
d1957958e3 Cleanup indentation and quotes 
Aligns all requirements vertically for easier reading + adds single quote standard consistently throughout Ghost, except in long strings.
 2013-09-26 15:06:31 +01:00
jamesbloomer
8e3ddcbdcc Trim version number to major and minor numbers only in meta tag 
closes #880
- as the version number is under control from package.json use regex to trim
 2013-09-26 15:00:05 +01:00
Hannah Wolfe
b787cc6639 Image upload start event fired earlier 
issue #882
 2013-09-26 12:35:03 +01:00
cobbspur
90e4637ede Image Upload URl saves in the right place 
closes #864

- adds trigger - uploadstart to url handler
 2013-09-26 12:34:59 +01:00
Hannah Wolfe
0b87c42e84 Merge pull request #891 from ErisDS/0.3.1-importerfix 
0.3.1 Import & Export fixes
 2013-09-26 04:14:56 -07:00
John O'Nolan
78775f1976 Added email to username if no name is given 
Gets rid of generic "Ghost" - we know a user will always have an email address as it is a required field.
 2013-09-26 12:02:48 +01:00
John O'Nolan
bf5ab32fe9 Renamed user image data helper to make more sense 2013-09-26 12:02:44 +01:00
Matthew Harrison-Jones
67132ff28b Bug Fix: Date Keyboard Shortcut no-longer crashes the browser 2013-09-26 11:22:02 +01:00
jamesbloomer
6941b73168 Fix admin redirect issue 
closes #850
- the aliases for the ghost admin link were causing redirects of the
form /ghost//admin etc.
- simplest solution is to split the route into two with the first one
just redirecting and the second doing the auth
 2013-09-26 10:46:45 +01:00
Hannah Wolfe
02a02054e8 Handle duplicate tags on import 
closes #890

- importer only adds tags which don't exist.
- added back the import unit tests - these are basic for now
 2013-09-25 11:30:59 +01:00
Hannah Wolfe
f68633df20 Adding missing return to MySQL exporter 
closes #888
 2013-09-25 09:38:03 +01:00
Hannah Wolfe
4b5cfbde2e Adding missing multipart to importer route 
closes #869
 2013-09-25 09:36:45 +01:00
Matthew Harrison-Jones
340958cfcf Updated 'Help / Support' link 2013-09-23 18:46:03 +01:00
John O'Nolan
472406d157 Removed version number from user menu 
Fixes #855
 2013-09-22 22:54:07 +02:00
Hannah Wolfe
0c545d5f2e Cleanup 2013-09-19 08:51:01 +01:00
Hannah Wolfe
32d1076d35 Correct validation message for short passwords 
closes #833
 2013-09-19 08:41:04 +01:00
Hannah Wolfe
5528423636 Client & Server side validation for posts per page 
closes #839

- caused a 500 error
 2013-09-19 07:55:37 +01:00
Hannah Wolfe
477c4c59fa Merge pull request #843 from cgiffard/500-errors 
500 Series Error Handling & Stack Traces
 2013-09-18 22:52:52 -07:00
Hannah Wolfe
358ce63732 Merge pull request #831 from gotdibbs/Issue824 
Removed global registration of express.bodyParser
 2013-09-18 22:51:35 -07:00
Hannah Wolfe
4023e55bc2 Merge pull request #842 from gotdibbs/Issue834 
Expanded spelling of chars to characters
 2013-09-18 22:51:09 -07:00
Hannah Wolfe
43fe50ca7b New Tag in fixture breaks Tag tests 2013-09-19 06:50:32 +01:00
Hannah Wolfe
fe5df2b0d1 Updated Welcome to Ghost fixture 
closes #790
 2013-09-19 05:59:33 +01:00
Christopher Giffard
9c8b02949a 500 Series Error Handling & Stack Traces 
Fixes #825

- Changes the way the error middleware is delivered in server.js, moving
  all the logic back into errorHandling.js
- Alters error logging to use console.error (probably more appropriate) instead
  of console.log
- Changes error tests to accomodate for these alterations
- Alters user-error and error hbs templates to incorporate stack traces
- Adds additional styling for error pages to accomodate stack traces
- Added logic to parse and deliver formatted stack traces

Notes:
======

- Jslint gets in the way of the regex I've got to use to parse the stack.
  (It cites 'security reasons' which are not relevant in this case.)
  I needed to add a condition to relax it at the top of errorHandling.js
- The stack trace should probably be added as a partial, but I figured it
  was out of scope for this PR.
 2013-09-19 13:01:20 +10:00
William Dibbern
4ff6162d79 Expanded spelling of chars to characters 
Fixes #834

- Updated error message for password length to use "characters" instead
of "chars".
 2013-09-18 21:51:56 -05:00
William Dibbern
2417de8141 Removed global registration of express.bodyParser 
Fixes #824

- Removed global registration of `express.bodyParser` middleware.
- Replaced with `express.bodyParser`'s constituents: `express.json` and
`express.urlencoded`, then registered `express.multipart` against *only*
the upload route.
 2013-09-18 18:30:31 -05:00
Hannah Wolfe
eb6856dac3 Removing Temporary importer 2013-09-18 23:24:26 +01:00
John O'Nolan
a7a14fac22 New default user image 2013-09-18 22:34:01 +01:00
Hannah Wolfe
eb7a63bd1d Fixing tag save event 
- lost in a bad merge somewhere
 2013-09-18 20:04:39 +01:00