3 commits

Author	SHA1	Message	Date
Hannah Wolfe	a31069d49d	Removed unnecessary use of rewire ... refs: https://github.com/TryGhost/Ghost/commit/e68cb8b31 - I found that some of the places we use rewire are totally unnecessary - Rewire seems to mess with coverage sometimes - It's also a code smell in general so I've ripped it out where possible	2022-03-24 19:32:06 +00:00
Hannah Wolfe	e68cb8b314	Improved settings cache unit tests ... - settings cache was appearing as untested because we use rewire! - rewire was totally unnecessary in this case, so I removed it - updated to 100% test coverage whilst there, including removing one unreachable branch - commented some undesirable behaviour I found whilst trying to reach all branches - I don't want to change the behaviour to return false correctly without having a reason beyond improving coverage	2022-03-23 11:37:52 +00:00
Hannah Wolfe	f08a55c21f	Renamed tests to .test.js & updated commands ... refs: https://github.com/TryGhost/Team/issues/856 refs: https://github.com/TryGhost/Team/issues/756 - The .test.js extension is better than _spec.js as it's more obvious that it's an extension - It also meaans we can use the --extension parameter in mocha, which should result in a better default behaviour for `yarn test` - It also highlights that some of our tests were named incorrectly and were not (and still will not be) run (see https://github.com/TryGhost/Team/issues/856) - Note: even with this change, `yarn test` is throwing errors, I believe because of this issue https://github.com/TryGhost/Team/issues/756	2021-07-06 20:45:01 +01:00

Renamed from test/unit/shared/settings-cache_spec.js (Browse further)