Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity
14351 commits 234 branches 1697 tags 546 MiB
Commit graph

1352 commits

Author SHA1 Message Date
Kevin Ansfield
a485509a2f
🐛 Fixed GA labs flags not appearing enabled in settings API (#13681) 
no issue

The way GA flags were introduced means that they stop existing in the `'labs'` setting in the db and are instead forced to always return `true` when checking the flag in the labs service. However, Admin which uses the flags fetches them via the `/settings/` API endpoint which was only returning the raw labs setting db value meaning GA flags appeared to be disabled unless the flag had previously been enabled and no settings save had occured.

- updated the settings bread service to replace the labs setting value with the JSON stringified output of `labs.getAll()` which is the ultimate source-of-truth for a feature being enabled/disabled
  - extracted `browse()` behaviour to an internal `_formatBrowse()` method so we can apply the same filtering/modification for output of `browse()` and `edit()`

Co-authored-by: Fabien O'Carroll <fabien@allou.is>
 2021-10-22 19:59:13 +01:00
Fabien O'Carroll
696d8e3c49 Added 404 handling for edit Offer 
no-issue

This was also missing as part of the Offers API.
 2021-10-22 16:16:39 +02:00
Fabien O'Carroll
363eb94aee Handled 404 for Offer not found 
no-issue

This was missing handling! We need to throw a NotFoundError so we
return with the correct response.
 2021-10-22 14:22:33 +02:00
Naz
07afb08875 Made storage calls related to images use "images" feature 
refs https://linear.app/tryghost/issue/CORE-1/multiple-adapters-per-type

- Having this preemptive change allows to separate implementation of "image" storage from future usecases like "videos", "audios" etc. Even if the "image" adapter is not configured the default behavior will fallback to use the "active" storage adapter. If there's a need to handle "images" differently through a custom apapter that'll work out of the box ;)
 2021-10-21 20:22:45 +13:00
Naz
6e075c78bf Moved URL service to backend 
refs https://linear.app/tryghost/issue/CORE-104/decouple-frontend-routing-events-from-urlserver-events

- URL module is part of the backend heavily dependent on the model and fits perfectly here. Frontend should get the data it needs by passing a URL manager instance to it
 2021-10-19 07:29:09 +13:00
Hannah Wolfe
00bcaeeb8c
Fixed duplicate message due to bad merge 
- sadly git is not always detecting conflicts properly
 2021-10-13 09:17:01 +01:00
PJ
4943c97ecb
Replace i18n with tpl in api/v2/utils/validators/input/users.js (#13589) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 09:08:57 +01:00
PJ
d362d8c8bd
Replace i18n with tpl in core/server/api/v3/invites.js (#13587) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 09:07:57 +01:00
PJ
09a9a9844f
Replace i18n with tpl in api/v3/pages-public.js (#13586) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 09:07:42 +01:00
PJ
f8033596c0
Replace i18n with tpl in api/v3/pages.js (#13585) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 09:06:53 +01:00
PJ
6e14047a2a
Replace i18n with tpl in core/server/api/v3/memberSigninUrls.js (#13584) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 09:05:38 +01:00
PJ
57ce743d98
Replace i18n with tpl in output/authentication.js (#13581) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 09:00:19 +01:00
Tomás Castillo
2c659ea447
Replaced i18n.t w/ tpl helper in v3/posts.js file (#13580) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 08:58:34 +01:00
IncredibleZuess
dd5a96d37c
Replaced i18n.t w/ tpl in api/v2/utils/validators/input/setup.js (#13579) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 08:54:22 +01:00
IncredibleZuess
b2e4145bd9
Replaced i18n.t w/ tpl in api/v2/utils/validators/input/settings.js (#13578) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 08:53:57 +01:00
IncredibleZuess
0cbc813f28
Replaced i18n.t w/ tpl in core/server/api/v2/utils/validators/input/passwordreset.js (#13577) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package
 2021-10-13 08:52:39 +01:00
IncredibleZuess
e0c0022cb7
Replaced i18n.t w/ tpl in core/server/api/v2/utils/validators/input/invites.js (#13576) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 08:52:19 +01:00
IncredibleZuess
6d4b682b95
Replaced i18n.t w/ tpl in api/v2/utils/validators/input/images.js (#13575) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 08:50:15 +01:00
Levi Richardson
6421f60852
Switch i18n.t to tpl in users.js (#13574) 
refs: #13380

- i18n is deprecated and is being replaced with tpl
 2021-10-13 08:44:04 +01:00
Fabien O'Carroll
b1914758b8 Added support for filter Offers by status 
refs https://github.com/TryGhost/Team/issues/1131

This will allow Ghost Admin to display separate lists of active and
archived Offers! We must pass the options through so that the
OffersService is able to handle the filter passed in the request.
 2021-10-12 18:39:25 +02:00
ItsMeSatan
af7fe99127
Replaced i18n.t with tpl in memberSigninUrls.js and oembed.js (#13564) 
refs: #13380

- i18n is deprecated and is being replaced with tpl
 2021-10-12 14:47:53 +01:00
Fabien O'Carroll
1bb9c3a9ac Invalidated site cache when adding & editing Offers 
no-issue

Because adding and editing Offers can update the redirects for Ghost, we
should ensure that any site cache is cleared so as to not conflict with
Offer redirects.
 2021-10-12 15:20:31 +02:00
Marco F
ed6045d82c
Replaced i18n.t() with tpl() in v2/utils/validators/input/invitations.js (#13560) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-12 09:12:04 +01:00
Indrakant Dana
e2aeca56e9
Replaced i18n.t w/ tpl in v3/utils/serializers (#13552) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-12 08:39:15 +01:00
Indrakant Dana
8029d1ce6a
Replaced i18n.t w/ tpl in v3/settings.js (#13551) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-12 08:36:11 +01:00
Shadman Ahmed Khan
c1789a3a03
Replaced i18n with tpl in core/server/api/v3 (#13548) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.

Co-authored-by: Shadman Khan <shadmankhan@ShadmanMac.local>
 2021-10-12 08:33:33 +01:00
Indrakant Dana
4f0999b6db
Replaced i18n.t w/ tpl in core/server/api/v3/utils/validators/input/setup.js (#13534) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 21:28:01 +01:00
Indrakant Dana
91dd9eae4e
Replaced i18n.t w/ tpl in core/server/api/v3/utils/validators/input/webhooks.js (#13536) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 20:54:06 +01:00
Indrakant Dana
7c14ff903b
Replaced i18n.t w/ tpl in api/v3/utils/validators/input/settings.js (#13533) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 19:57:40 +01:00
Indrakant Dana
cef32dd1fe
Replaced i18n.t w/ tpl in core/server/api/v3/utils/validators/input/passwordreset.js (#13532) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 19:56:23 +01:00
Indrakant Dana
a73459d904
Replaced i18n.t w/ tpl in core/server/api/v3/utils/validators/input/invitations.js (#13531) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 19:45:29 +01:00
Indrakant Dana
9fe0b3df1a
Replaced i18n.t w/ tpl in core/server/api/v3/utils/validators/input/images.js (#13530) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 19:36:36 +01:00
Hannah Wolfe
0bdaa216e5
Refactored tpl to never be used in DI 
- Ghost has a set of core packages that it is safe to require directly in any file - tpl is one of them!
- This keeps the DI signature smaller and easier to reason about
 2021-10-11 15:19:54 +01:00
Ayoub BERDEDDOUCH
1249254a68
Replaced i18n w/ tpl in /core/server/api/v3/posts-public.js (#13527) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 14:40:01 +01:00
Ayoub BERDEDDOUCH
8102a316d5
Replaced i18n w/ tpl in /core/server/api/v3/preview.js (#13526) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 14:39:36 +01:00
Ayoub BERDEDDOUCH
8961785dfa
Replaced i18n w/ tpl in /core/server/api/v3/session.js (#13525) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 14:39:19 +01:00
Ayoub BERDEDDOUCH
887caa299f
Replaced i18n with tpl in /core/server/api/v3/slugs.js (#13524) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 14:37:44 +01:00
homersimpsons
3bb7813613
Replaced i18n.t w/ tpl helper in core/server/api/canary/* (#13521) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 14:35:43 +01:00
william chandra
311414ad48
Replaced i18n.t w/ tpl in core/server/api/v3/utils/validators/input/users.js (#13517) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 14:30:05 +01:00
william chandra
a62c7acde2
Replaced i18n.t w/ tpl in core/server/api/v3/utils/validators/input/oembed.js (#13516) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 13:59:40 +01:00
william chandra
e0b08c1ece
Replaced i18n.t w/ tpl in api/v3/utils/validators/input/invites.js (#13514) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 13:58:53 +01:00
Naz
8737ec8888 Added createdAtVersion property to newly created notifications 
refs https://linear.app/tryghost/issue/CORE-64/resolve-undissmissable-update-notification-banners

- The property is meant to track Ghost instance version the notification was received and processed at.
- This information should be useful in the future to dismiss outdated notifications
 2021-10-11 23:38:40 +13:00
Kevin Ansfield
c33b596e9c
Added API tests for custom theme settings (#13519) 
refs https://github.com/TryGhost/Team/issues/1104

- bumped `@tryghost/custom-theme-settings-service` so it throws a more appropriate `ValidationError` when setting keys don't exist or a select value is not known
- changed the custom theme settings service to have a `.init()` method which creates an instance of the service under `.api` so that we're able to create the instance at a particular point in the boot process when we know the models have been initialised
  - there were problems in tests because the service was being initialised through the require chain before models were initialised through the boot process
- fixed incorrect `camelCase` of resource name in API responses
 2021-10-08 16:18:49 +01:00
LucasOe
1ceab9dea3
Replaced i18n.t w/ tpl in v2/slugs.js (#13505) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-08 15:41:10 +01:00
LucasOe
ace3ff033c
Replaced i18n.t w/ tpl in v2/settings.js (#13504) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-08 15:40:55 +01:00
LucasOe
5ec272a377
Replaced i18n.t w/ tpl in v2/preview.js (#13503) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-08 15:40:22 +01:00
LucasOe
649461ba2f
Replaced i18n.t w/ tpl in v2/posts.js (#13502) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-08 15:39:58 +01:00
LucasOe
ea346d5d22
Replaced i18n.t w/ tpl in v2/posts-public.js (#13501) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-08 15:39:15 +01:00
LucasOe
280bc6e6e1
Replaced i18n.t w/ tpl in v2/pages.js (#13500) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-08 15:38:40 +01:00
LucasOe
3303ce127c
Replaced i18n.t w/ tpl in v2/oembed.js (#13499) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-08 15:38:23 +01:00