0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-17 23:44:39 -05:00
Commit graph

3010 commits

Author SHA1 Message Date
Jilles Soeters
71c6b33385 Remove hash after the url when clicking Meta Data
Removes that hash appended to the URL when clicking Meta Data in post settings.

Closes #4386

When clicking 'Meta Data' the click event appends a # to the URL. I replaced the a with a button element so that won't happen anymore. The button has a type attribute because it will try and submit the form without it. Added text-align: left to the navlist button because the button centers it's content by default.
2014-11-05 14:17:52 +00:00
Jason Williams
d5f13e1510 Merge pull request #4384 from meowtec/fix-error-log
fix bug in which `logError` could not resolve an err without `message`
2014-11-04 23:20:47 -06:00
meowtec
d42703dd9f Correct logError to log err which has undefined message
closes #4384
 - if err is `object` && `err.message` isNOT `string`, let err = `An unknown error occurred.`
2014-11-05 11:03:33 +08:00
Matt Enlow
ef448a0f85 Merge pull request #4273 from cobbspur/tags
Create Tags Management Stubs for Ember
2014-11-04 10:30:00 -07:00
cobbspur
69d4852a6d Create Tags Management Stubs for Ember
closes #4260

- Adds "tags" route inside of the settings routes.
- Adds this route to router.js
- Links the route from the settings.hbs template
- Adds demo tags html in tag.hbs template
- Adds flag for tagsUI
2014-11-04 15:50:41 +00:00
Matt Enlow
b5af691a61 Save meta title and meta desc on post save
Closes #4369
- Renamed `editor-route-base` -> `editor-base-route` to bring it in alignment with the view and controller mixins
- Consolidated editor route code into editor-base-route
- Removed `serialize` from EditorEditRoute, as it reimplemented the ember default
2014-11-03 21:11:04 -07:00
Matt Enlow
8d96cb2f67 Merge pull request #4375 from DaveRobson/#4253
Editor must be focused before allowing certain keyboard shortcuts.
2014-11-03 10:30:30 -07:00
Hannah Wolfe
67e33a65e8 Merge pull request #4317 from cobbspur/image
Created image helper with absolute url option
2014-11-03 15:21:35 +00:00
Hannah Wolfe
fe659117bc Merge pull request #4155 from jgable/importDuplicates
Remove duplicate posts and tags on import
2014-11-03 15:03:44 +00:00
David Robson
8bcfd16f19 Editor must be focused before allowing certain keyboard shortcuts.
closes #4253
- checked for the CodeMirror-focused class on the CodeMirror div
- used length to determine whether CodeMirror-focused has been added
- determines whether the editor has been focused on
2014-11-02 09:50:42 +00:00
Hannah Wolfe
8df98b4f7d Merge pull request #4371 from jaswilli/fork-timeout
Improve handling of forked processes in tests.
2014-11-01 11:02:39 +00:00
Jason Williams
817b8d2906 Improve handling of forked processes in tests.
Closes #4277
- Increase the wait time for forked processes to spin up.
- If we give up on waiting for a forked process, send it a
  kill signal so if it comes alive later it doesn't sit in the
  background forever.
- Fail fast if test setup fails instead of waiting for the timeout.
2014-10-31 16:00:35 +00:00
Jason Williams
8249d88cdd Timeout after two seconds on gravatar lookup.
Refs #4277
- Switch from the built-in http module to request and set
  a timeout of 2 seconds on gravatar lookup requests.
- Move request package from devDependencies to dependencies.
2014-10-30 20:01:11 +00:00
Jason Williams
2cfab3565f Handle null/undefined value in test assertion.
No Issue.
- Test is not guaranteed to get a setting that has a "value"
  so we need to handle the case where it's null or undefined.
2014-10-30 15:40:23 +00:00
Matt Enlow
2bd129fb81 Merge pull request #4361 from jaswilli/ember18
Update Ember to 1.8.0.
2014-10-30 08:26:26 -06:00
Paul Adam Davis
be976485ad Better comments
Also introduces a new format of file opening comment, to outline what happens and a contents list.
2014-10-30 12:40:50 +00:00
Paul Adam Davis
d314727506 Var cleanup 2014-10-30 12:40:12 +00:00
Paul Adam Davis
4ae81799c3 File structure cleanup 2014-10-30 12:39:31 +00:00
Jason Williams
de63f56f68 Update Ember to 1.8.0.
Closes #4316
- Ember@1.8.0.
- Ember-Data@1.0.0-beta.11.
- Change templates to use new Ember.Select syntax and other minor
  cleanup.
- Adjust functional tests.
2014-10-30 06:01:22 +00:00
Matt Enlow
a2d37ce265 Redirect unauthorized users to signin from debug
Closes #4357
- Adds a call to `this._super()` in DebugRoute#beforeModel to hit the ember simpleauth mixin's beforemodel hook
2014-10-29 14:30:40 -06:00
Matt Enlow
344f3080df Consolidate SimpleAuth.AuthenticatedRouteMixin into AuthenticatedRoute
No issue
2014-10-28 08:29:42 -06:00
cobbspur
4a56d10c86 Created image helper with absolute url option
closes #4231

- Adds {{image}} helper
- Adds image_spec test unit
- Updated {{ghost_head}} to use image helper
2014-10-28 13:14:41 +02:00
Hannah Wolfe
bc728c3e62 Merge pull request #4285 from novaugust/read-draft-shortcuts
Go between post list / post content with keyboard
2014-10-28 13:02:17 +02:00
Hannah Wolfe
dbf055907a Merge pull request #4338 from felixrieseberg/iss3858
Enable :author as permalink option
2014-10-28 12:58:39 +02:00
Jacob Gable
5de5cfe7a1 Remove duplicate posts and tags on import
Issue #806

- Modify sanitize to check for duplicate posts and tags
- Update posts_tags when referencing removed duplicate tags
- Return both data and problems from importData
- Add tests for duplicate posts and tags with fixtures
2014-10-27 18:20:32 -05:00
Paul Adam Davis
17d662bff9 Use gh-path for nav bar dfallback avatar
Closes #4344

- Uses the `{{gh-path}}` helper to make the fellback avatar src work when Ghost is in a sub-directory
2014-10-27 16:26:02 +00:00
John O'Nolan
edef2ec941 Merge pull request #4341 from PaulAdamDavis/fix-floating-scroll-shadows
Fix floating header vertical shadows glitch
2014-10-27 16:59:42 +01:00
Hannah Wolfe
2d48c2b695 Merge pull request #4343 from jaswilli/gh-paths
Fix argument handling in gh-path helper.
2014-10-27 17:45:34 +02:00
Matt Enlow
d8f858e264 Go between post list / post content with keyboard
Closes #3940
- Pushing left/right changes the "focus" of the posts screen to the list / content, respectively
- Once one of these has been focused, up/down keyboards work on that section in particular
- By default, the post list is selected
- Using the keyboard to focus one of the two makes it go "poof" to let you know you changed stuff
2014-10-27 09:41:13 -06:00
Hannah Wolfe
644f922510 Merge pull request #4324 from jaswilli/timed-save
Auto-save post at 60 second intervals
2014-10-27 17:38:54 +02:00
Hannah Wolfe
6db2973f0f Merge pull request #4337 from jaswilli/title
Fix up title/slug handling on posts.
2014-10-27 17:27:11 +02:00
Hannah Wolfe
c0375d4087 Merge pull request #4332 from cobbspur/escape
Escape meta title and description
2014-10-27 17:03:20 +02:00
Jason Williams
d810fe1ca7 Fix argument handling in gh-path helper.
No Issue
- Make helper behave as stated in description when variable
  number of arguments are passed in.
- Handle leading and trailing slashes when creating output
  url partial.
2014-10-27 02:17:07 +00:00
Paul Adam Davis
074c12a763 Swap 2 box shadows for 1 radial gradient
Closes #4340

Fixes a UI glitch where the vertical parts of a box shadow would show.
This fix changes those box shadows for 1 radial gradient, where only 5px of it is shown. No more vertical shadows.
2014-10-26 17:35:54 +00:00
Felix Rieseberg
e9c22ea580 Include post title in 'delete post' modal
Closes #2971
2014-10-25 18:37:18 -07:00
Felix Rieseberg
c7ad09aace Enable :author as permalink option
Closes #3858
- urlPathForPost is now aware of the author’s slug, allowing for the
permalink setting to use :author
- Frontend controller only renders posts that have the specified
author, if one is given
- Extensive tests included
2014-10-25 18:15:24 -07:00
Jason Williams
e046f4a536 Fix up title/slug handling on posts.
Refs #4323
- Remove any titleScratch observers that may be hanging
  around on the post-settings-menu controller from previous posts.
- Change logic around when to regenerate slugs on posts that are
  "(Untitled)" so that slug generation continues after slug no
  longer resembles "untitled."
2014-10-25 23:35:50 +00:00
Hannah Wolfe
20fbcc1e59 Merge pull request #4335 from jaswilli/jscs
Enable JSCS checking on client.
2014-10-25 19:44:16 +03:00
Jason Williams
0f17378b26 Enable JSCS checking on client.
Refs #4001
- grunt-jscs@0.8.1 which provides ES6 support.
2014-10-25 16:13:04 +00:00
Hannah Wolfe
a5d4a9cd2c Merge pull request #4329 from jaswilli/remove-lodash-requirement
Remove lodash from admin client (updates PR #3491)
2014-10-25 12:26:18 +03:00
cobbspur
5aac6d6d69 Escapes strings
closes #4328

- Escapes metaTitle, metaDescription, blog url, blog title, tags
- Updates tests
- Adds test for metaTitle and metaDescription with double quotes
2014-10-24 19:22:37 +02:00
Jason Williams
9aa13330ba Fix up PR #3491, remove lodash from admin
Refs #3491
2014-10-23 19:44:53 +00:00
John O'Nolan
16e9098906 Merge pull request #4217 from PaulAdamDavis/permalinks-ui
[WIP] Custom Permalink UI
2014-10-23 21:06:33 +02:00
Robert Jackson
a3456b7e1c Remove lodash from admin client.
* Adds `bind`, `isFinite`, and `isNumber` utility functions from lodash.
* Use new util funtions instead of lodash throughout the codebase.
* Remove lodash from vendor builds.
2014-10-23 18:27:09 +00:00
Hannah Wolfe
81dd5600b6 Merge pull request #4323 from jaswilli/issue-4121
Change slug and date placeholders to values
2014-10-23 21:11:03 +03:00
Paul Adam Davis
d999ce555d Custom permalink UI
References #3920
2014-10-23 12:12:48 +01:00
Leonard Camacho
a6a02f31ad Fix no show of default Twitter card
No issue
- change default Twitter card from content to summary
2014-10-22 20:49:06 -04:30
Jason Williams
9a62a38440 Change slug and date placeholders to values
Closes #4121
2014-10-22 16:49:13 +00:00
Jason Williams
5de2cb4471 Auto-save post at 60 second intervals
Refs #4259
- Auto-save the post at least once in any 60 second interval where
  there have been changes.
2014-10-22 15:26:27 +00:00
Paul Adam Davis
a32e5a7135 Move unrelated editor cover code to the right place
Closes #4106

Moved the `.editor-close` styles to `post-settings-menu.scss`
2014-10-21 13:14:07 +01:00