Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity
39250 commits 231 branches 1692 tags 528 MiB
Commit graph

924 commits

Author SHA1 Message Date
Djordje Vlaisavljevic
69a8f71bd1 Switched checkbox to a hint showing status 
refs PROD-276
 2023-12-13 16:58:50 +00:00
Djordje Vlaisavljevic
b0ac1e9afd Hid price preselect dropdown when only monthly or yearly are shown 
refs PROD-275
 2023-12-13 16:58:50 +00:00
Djordje Vlaisavljevic
b97f91f408 Changed portal settings to show free tier name instead of "Free" 
refs PROD-255
 2023-12-13 16:58:50 +00:00
Sodbileg Gansukh
f00b342e83
Fixed number formatting of offer redemptions count (#19365) 
fixes PROD-274

- corrected plural form of the label
- added number formatting
 2023-12-13 15:38:53 +00:00
Sodbileg Gansukh
6462f8f2ab
Fixed minor design issues in offers (#19363) 
fixes PROD-271, PROD-273
 2023-12-13 15:26:28 +00:00
Peter Zimon
58d9b8e382
Update migration in settings (#19278) 
refs.
7b40393d77

We're improving the usability and possibilities for publishers to
migrate from other platforms such as Substack, Medium or Mailchimp. This
PR applies changes to Ghost Settings to support the new flows, more
specifically:

- moves import and export functions out of Labs to its own setting,
directly available from search and the menu
- adds direct access to various platform migrations
- moves "Delete all content" to a dedicated setting group at the bottom
of all setting

---------

Co-authored-by: Jono Mingard <reason.koan@gmail.com>
 2023-12-13 16:25:29 +01:00
Ronald Langeveld
f23767fe12
Fixed offers asc/desc sorting not updating in component (#19361) 
refs
https://linear.app/tryghost/issue/PROD-8/when-i-sort-by-name-→-click-into-an-offer-→-go-back-to-the-list-it
 2023-12-13 13:46:11 +00:00
Princi Vershwal
f29d7975a8
Removed validation onBlur (#19358) 
Fixes
[PROD-209](https://linear.app/tryghost/issue/PROD-209/when-an-input-is-focused-and-a-modal-is-closed-error-messages-are)
 2023-12-13 11:07:15 +00:00
Daniel Lockyer
a9c9202b5c Added defaults to Nx build step 
refs https://github.com/TryGhost/DevOps/issues/122

- this allows us to DRY up some of the other configuration we have
  dotted around and fixes a niche bug with overlapping builds that we
  were seeing before, because Nx should only allow one build at a time
 2023-12-13 11:54:31 +01:00
Daniel Lockyer
efec8b5fba Enabled concurrent execution of tsc and Vite build 
refs https://github.com/TryGhost/DevOps/issues/122

- this runs the Vite build and Typescript type checking concurrently,
  which will speed up the total time to build
 2023-12-13 11:54:31 +01:00
Ronald Langeveld
286194d61a
Added global state to avoid losing sorting state in Offers (#19355) 
refs
https://linear.app/tryghost/issue/PROD-8/when-i-sort-by-name-→-click-into-an-offer-→-go-back-to-the-list-it


- we now handle the state via a global state to ensure we aren't resetting the sorting options after each rerender.
 2023-12-13 12:25:06 +02:00
Sodbileg Gansukh
be47817ca0
Dark mode improvements for offers success screen (#19356) 2023-12-13 10:20:47 +00:00
Daniel Lockyer
fc02ca8bbb Reverted "Update Vite packages" 
refs https://ghost.slack.com/archives/C0568LN2CGJ/p1702454781859679

- this reverts commit cf60db85d8 as we've
  seen issues with the `vite-plugin-css-injected-by-js` dependency
 2023-12-13 09:24:29 +01:00
renovate[bot]
9f9f6d0526 Update dependency @types/react to v18.2.45 2023-12-13 08:59:33 +01:00
Sodbileg Gansukh
3713273560
Dark mode improvements for offers (#19352) 
fixes PROD-262, PROD-261
 2023-12-13 07:40:40 +00:00
renovate[bot]
981b8fc814 Update dependency @types/react to v18.2.44 2023-12-13 08:23:09 +01:00
Princi Vershwal
830967d2ed
Edit cancle button fix (#19350) 
Fixes:
[PROD-213](https://linear.app/tryghost/issue/PROD-213/cancelling-should-act-two-ways-when-the-modal-is-opened-from-the-list)
 2023-12-13 07:16:26 +00:00
Sodbileg Gansukh
b7648e7bc2
Added design improvements to the Portal preview in offers (#19349) 
fixes PROD-251, PROD-252, PROD-254
 2023-12-13 06:17:12 +00:00
Princi Vershwal
7d530406f6
Add offer cancel button fix (#19348) 
Ref
[PROD-213](https://linear.app/tryghost/issue/PROD-213/cancelling-should-act-two-ways-when-the-modal-is-opened-from-the-list)
 2023-12-13 05:48:48 +00:00
renovate[bot]
cf60db85d8 Update Vite packages 2023-12-12 18:23:37 +01:00
Sodbileg Gansukh
03fd494e84
Hide copy link feature when there's no offer code (#19335) 
fixes PROD-253
 2023-12-12 15:57:55 +00:00
Sodbileg Gansukh
0a5c61acb2
Removed linking when there's no redemptions (#19332) 
fixes PROD-250
 2023-12-12 15:37:50 +00:00
Djordje Vlaisavljevic
5c19249473
Added yearly discount indicator to monthly/yearly toggle PROD-60 PROD-222 PROD 223 (#19276) 
refs PROD-60, PROD-222, PROD-223, PROD-89, PROD-94

- Indicator shows up in the monthly/yearly toggle if there are any paid
tiers with yearly discount, and shows the highest discount in order to
nudge visitors towards checking out yearly plan
- A couple of smaller portal improvements: typos, spacing, alignment

---------

Co-authored-by: Simon Backx <simon@ghost.org>
 2023-12-12 09:32:56 +00:00
Princi Vershwal
c1c3775748
Revert "Add offer cancle button fix" (#19324) 
Reverts TryGhost/Ghost#19297
 2023-12-12 07:27:17 +00:00
Sodbileg Gansukh
c932e9d60e
Updated copy of the add offer link in the settings group (#19323) 2023-12-12 12:28:53 +07:00
Sodbileg Gansukh
742a743a6b
Removed extra div when there's no offers to show in the settings group (#19322) 2023-12-12 05:03:43 +00:00
Daniël van der Winden
8c5c773398
Fixed white icon bg's in tier list in dark mode (#19310) 
Closes issue https://github.com/TryGhost/Ghost/issues/18872

Solves the problem of the bg-white class showing a white background
behind the checkmark icons in the tier list.
 2023-12-11 17:13:46 +01:00
Jono M
9ff482f985
Updated AdminX routing to work with and without a leading slash (#19312) 
no issue
 2023-12-11 14:43:06 +00:00
Ronald Langeveld
4c09a96a3c
Changed request type to fetching iframe content in previews (#19307) 
refs PROD-227

- Swapped out the request type from `POST` to `GET`.
 2023-12-11 14:28:35 +00:00
Jono M
8ab693d74d
Fixed wrong credentials usage in AdminX previews (#19281) 
refs PROD-227
 2023-12-11 14:01:53 +00:00
renovate[bot]
29f9322cf3 Update dependency @types/react to v18.2.43 2023-12-11 09:49:06 +01:00
Princi Vershwal
5cb3ec6e0b
Add offer cancle button fix (#19297) 
Fixes PROD-213
 2023-12-11 04:40:35 +00:00
Ronald Langeveld
181c5c0920
Changed code injection to full screen editor. (#19259) 
fixes PROD-7
https://ghost.slack.com/archives/C0568LN2CGJ/p1701690959138659

- Changed the code injector editor to only use the full screen editor in
its own modal.

---------

Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
 2023-12-08 09:11:52 +02:00
Sag
a5dcae80e7
Updated copy during email verification in newsletter settings (#19265) 
fixes PROD-202
 2023-12-06 19:56:25 +00:00
Djordje Vlaisavljevic
813abb06e2
Moved hint content to placeholders for consistency PROD-204, PROD-203 (#19261) 
refs PROD-204, PROD-203

- Moved fallback value information from hints to placeholders for
consistency and cleaner layout
- Changed setting section label
 2023-12-06 17:06:21 +00:00
Simon Backx
3bc068123c
Wired up checkbox to toggle tier visibility (#19260) 
fixes PROD-200
 2023-12-06 17:36:18 +01:00
Simon Backx
3f6ea04c43
Added portal default plan setting (#19238) 
fixes PROD-61

This adds a new default plan setting. It defaults to yearly, which is
the current default selected interval in Portal.

Behind the new portal improvements feature flag, the default plan can be
changed. It will also change automatically if the available intervals
are changed.

This PR also wires up passing the new setting to the Portal preview.
 2023-12-06 11:39:58 +01:00
Princi Vershwal
a38aef7522
Validation fix (#19256) 
Fixes PROD-208
 2023-12-06 10:38:05 +00:00
Princi Vershwal
60d142202b
Remove validation error once user start typing (#19251) 
Ref
[PROD-15](https://linear.app/tryghost/issue/PROD-15/validation-issues)
 2023-12-06 13:32:21 +05:30
Princi Vershwal
5a4d98e90d
Show Add offer button on settings screen if no offer is present (#19215) 
Ref
[PROD-3](https://linear.app/tryghost/issue/PROD-3/settings-group-navigation-handling)
 2023-12-06 04:31:48 +00:00
Djordje Vlaisavljevic
9eed858e8e
Added static design for toggling showing new tier in portal PROD-66 (#19242) 
refs PROD-66

---------

Co-authored-by: Sag <guptazy@gmail.com>
Co-authored-by: Jono M <reason.koan@gmail.com>
Co-authored-by: Steve Larson <9larsons@gmail.com>
Co-authored-by: Daniel Lockyer <hi@daniellockyer.com>
Co-authored-by: Aileen Booker <AileenCGN@gmail.com>
 2023-12-05 18:53:05 +00:00
Sag
545cf8c258
Updated logic to allow a different name for the free tier (#19229) 
fixes PROD-69
 2023-12-05 18:05:16 +00:00
Jono M
960fde80db
Fixed missing link on upgrade modals (#19237) 
refs PROD-5
 2023-12-05 14:59:49 +00:00
renovate[bot]
5811dcaa41 Update Types packages 2023-12-04 22:05:57 +01:00
renovate[bot]
a1c292b683 Update dependency @vitejs/plugin-react to v4.2.1 2023-12-04 19:41:11 +01:00
Djordje Vlaisavljevic
f1511e6081 Added logic for disabled state for the dropdown 
refs GRO-141
 2023-12-04 18:16:23 +00:00
Djordje Vlaisavljevic
7026b28e17 Added static dropdown for selecting default price plan 
refs GRO-141
 2023-12-04 18:16:23 +00:00
Djordje Vlaisavljevic
36294c6482 Added feature flag for portal improvements 
refs GRO-154
 2023-12-04 18:16:23 +00:00
Jono M
ede2d9c1b7
Fixed loading and error handling bugs in portal settings (#19225) 
fixes ADM-31
 2023-12-04 15:25:58 +00:00
Peter Zimon
be925251b8
Added "support email address" keywords (#19224) 
refs.
https://linear.app/tryghost/issue/ADM-59/add-support-and-email-address-to-portal-keywords

Searching for "support email address" (or any combination of this) in
Settings resulted in an empty screen. The setting is availble under
Portal which is pretty hidden so it should at least be searchable. This
PR sets up new search keywords for support email address in Settings.
 2023-12-04 14:15:10 +00:00