Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity
37756 commits 234 branches 1697 tags 546 MiB
Commit graph

564 commits

Author SHA1 Message Date
James Morris
7e4f0bf361 Adding in bio position to comments, change to comment layout, changed up mobile design tweaks, new comment form, no global styles on iframes 
- This removes the global styles on the iFrame
- Changes to comment layout for new bio, new position for date and edited tag
- Lots of design tweaks for desktop and mobile

refs https://github.com/TryGhost/Team/issues/1716
 2022-07-26 16:22:45 +01:00
James Morris
550d28cc96 Moved the date up to underneath the name and tweaked over bits 2022-07-26 12:44:49 +01:00
James Morris
531e0036b2 Renamed the add name dialog to better suit including bio 2022-07-26 11:47:36 +01:00
James Morris
b1e1d4e23b Aded in a basic Bio field into the Add Name dialog 2022-07-26 11:45:10 +01:00
Rishabh
1eb16692aa v0.2.1 2022-07-26 15:40:34 +05:30
Rishabh
75503279d4 v0.2.0 2022-07-25 22:40:53 +05:30
Rishabh Garg
3314a03a3b Replaced hardcoded css link with styles from config (#2) 
refs https://github.com/TryGhost/Team/issues/1719

- the stylesheet link was prev hardcoded in the app, which made it impossible to configure from Ghost
- fetches styles url from the data attribute on script instead, which allows app to load styles based on config upstream
 2022-07-25 22:39:23 +05:30
Simon Backx
2e7055622e Fixed reply box redrawing when clicking the button again 
refs https://github.com/TryGhost/Team/issues/1710

Was caused by: mouseDown triggered on Reply button -> editor blurred -> editor closed itself -> onClick on reply opened the form again
 2022-07-22 17:38:28 +02:00
Simon Backx
3fbb7a6c24 Improved Form stability 2022-07-22 17:26:14 +02:00
Simon Backx
45d3ffcf06 Added proper cleanup functions to Form's useEffect 2022-07-22 17:24:02 +02:00
Simon Backx
6550d1b8cc Fixed add name dialog enter transition 2022-07-22 17:20:55 +02:00
Simon Backx
8544dbb1ba Removed old for attribute and readded appear animation in modals 2022-07-22 17:12:28 +02:00
Simon Backx
fd996da083 Refixed selection and flashing by properly stopping propagation 2022-07-22 17:07:17 +02:00
Simon Backx
e5d6a626bd Fixed selection inside forms 2022-07-22 16:34:05 +02:00
James Morris
34724c991e Tons of added styles to make mobile look better 
refs: https://github.com/TryGhost/Team/issues/1712
 2022-07-22 15:14:47 +01:00
Simon Backx
e333ecdb85 Fixed flashing when clicking around comment box when open 
refs https://github.com/TryGhost/Team/issues/1710
 2022-07-22 15:56:05 +02:00
Simon Backx
4bd1181e33 Removed admin auth log 2022-07-22 15:31:27 +02:00
James Morris
b2c7a49398 Removed the unncessary toggle reply prop that was passed 
no issue
 2022-07-22 13:46:12 +01:00
Simon Backx
c2d49d549c Removed default include from comments browse API call 2022-07-22 14:02:35 +02:00
James Morris
0dab85bfe9 Added in some basic hover to the action buttons 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-22 11:26:44 +01:00
James Morris
e1648551bf Improved the dropdowns on mobile 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-22 11:12:36 +01:00
James Morris
9f93eb75f5 Better blank avatar in dark mode and hover states for pagination 
- The blank avatar needed some work in dark mode and removed bits from svg file
- Added in some hover states for the pagination buttons

refs https://github.com/TryGhost/Team/issues/1703
 2022-07-22 11:05:50 +01:00
James Morris
4ab0bdf3b7 Added in conditions to the submit button values to work on mobile 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-22 10:54:33 +01:00
James Morris
fa411fdbf2 Fixing up some things with the modals and mobile and other bits 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-22 10:44:31 +01:00
James Morris
273c19db45 Fixed up the dropdown text alignments 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-22 09:39:27 +01:00
James Morris
2c013b8db0 Added in some responsive design to the Comments modals for mobile 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-22 09:35:52 +01:00
Simon Backx
8d41ec360b Skipped waiting for admin authentication 
fixes https://github.com/TryGhost/Team/issues/1700

- Admin authentication requests are non blocking now
 2022-07-22 09:44:21 +02:00
James Morris
a5af3f47ce Improved the hidden and removed status where it's now hidding name 
- Before, this was still showing name and avatar
- This now reverts to a blank avatar image

refs https://github.com/TryGhost/Team/issues/1703
 2022-07-21 19:46:53 +01:00
James Morris
59e29f30b0 Fixed the bug where the portal windows open inside the iFrame 
refs https://github.com/TryGhost/Team/issues/1706
 2022-07-21 18:43:32 +01:00
James Morris
ea643a4847 Added in some error handling and a few other tiny tweaks to Add Name dialog 
- Added in some error handling to catch empty names
- Basic checks for trimmed strings
- Subtle transition effects

refs https://github.com/TryGhost/Team/issues/1682
 2022-07-21 18:31:58 +01:00
James Morris
47a8386da2 Spacing tweaks to tighten things up based on John's feedback 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-21 18:08:30 +01:00
James Morris
16cccc2fcc Added the reply box disappearing properly with the toggle when finished 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-21 17:50:23 +01:00
James Morris
b60f0995d9 Added in the toggle so when blurring from reply textbox it'll undo the reply button too 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-21 17:50:23 +01:00
James Morris
5466ca2608 Needing more control over the opening and closing of text box so moved some things around 
- Note this may look a bit more complicated but I need more control over opening/closing
- Will look to refactor this and make it simpler soon enough

refs https://github.com/TryGhost/Team/issues/1703
 2022-07-21 17:50:20 +01:00
Simon Backx
30cd5c278e Fixed More button not toggling context menu 2022-07-21 17:35:24 +02:00
Simon Backx
dcfebd5e5f Fixed generic dialogs closing when clicking inside them 2022-07-21 17:27:58 +02:00
Simon Backx
b262d7010a Fixed closing context menus when clicking outside them 
fixes https://github.com/TryGhost/Team/issues/1702
 2022-07-21 17:23:35 +02:00
Simon Backx
20f2b26c23 Removed Modal component 2022-07-21 17:00:10 +02:00
Simon Backx
2980e58201 Updated Popup Modals now using global context 2022-07-21 16:59:18 +02:00
James Morris
15b534f7d3 Push some more style tweaks for iFrame but it may need more 
- Includes more dynamic styling for negative margins for iFrames
- This may well change again when looking more closely with themes

refs https://github.com/TryGhost/Team/issues/1701
 2022-07-21 15:33:04 +01:00
James Morris
dd8715fa46 Moved iFrame comments adjustments 
- Moved where the styling is to not mess with modals
- Added in some padding at the top for edit box

refs https://github.com/TryGhost/Team/issues/1701
 2022-07-21 14:44:37 +01:00
Simon Backx
f011de6b5b Cleaned up the modals iframe being in DOM when not shown 2022-07-21 15:31:26 +02:00
James Morris
6d19323df2 Quick fix for iFrame, negative margins and padding to retain shadow 
refs https://github.com/TryGhost/Team/issues/1701
 2022-07-21 14:09:13 +01:00
Simon Backx
866a020072 Fixed scrolling to reply form 2022-07-21 15:03:40 +02:00
Simon Backx
0b8f92ddbe Switched from Shadow DOM back to Iframes 
refs https://github.com/TryGhost/Team/issues/1701

The Selection API is missing in Safari in Shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=163921. So we need to move away from it for now.

- Adds a new component: Modal, which makes sure we can style modals using tailwind, while displaying them outside of the main iframe (inside a different iframe that is positioned fixed)
- Updated GenericDialog to use the new Modal component
- Removed ShadowDOM
 2022-07-21 14:35:32 +02:00
James Morris
a9c3ef5444 Fixed the quotes back to double for HTML elements 
no issue
 2022-07-21 13:11:33 +01:00
James Morris
6b4290694b Added in a simple scroll to reply to ensure it's always in view 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-21 13:05:23 +01:00
James Morris
e6cacdb2db Moved reply box to bottom and made it autofocus 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-21 12:36:54 +01:00
James Morris
64b6dbd3ee Little tweak to how the Add Name dialog box opens from comments 
- Now doesn't jump when opening the Add Name dialog box
- Still some minor things to visually tweak on this but it's an improvement

refs https://github.com/TryGhost/Team/issues/1682
 2022-07-21 12:04:08 +01:00
James Morris
269bd6506e Smaller UI and UX tweaks from John's feedback 
- Increase rounded border size of submit button
- Make cursor be text when editing
- Remove ugly outlines from actions

refs https://github.com/TryGhost/Team/issues/1703
 2022-07-21 11:31:12 +01:00