Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity
35642 commits 231 branches 1692 tags 528 MiB
Commit graph

553 commits

Author SHA1 Message Date
renovate[bot]
6e0e9e02ca Update dependency postcss to v8.4.24 2023-06-21 12:41:39 +02:00
renovate[bot]
e8f5ea0f33 Update dependency serve-handler to v6.1.5 2023-06-21 12:41:12 +02:00
Daniel Lockyer
8d611112a1 Updated Renovate config to quietJS 
- this is our homegrown Renovate preset that should keep things quiet around here
 2023-06-21 12:35:40 +02:00
Daniel Lockyer
08aef4fbb4 Pinned dependencies 
- this is an app so we want to pin dependencies to ensure we know what
  version they're using
 2023-06-21 12:26:56 +02:00
renovate[bot]
94242ec627 Update dependency @testing-library/react to v12.1.5 2023-06-21 12:19:41 +02:00
renovate[bot]
5a426e5575 Update dependency @testing-library/jest-dom to v5.16.5 2023-06-21 12:17:06 +02:00
renovate[bot]
7a7629620b Add renovate.json 2023-06-21 12:15:03 +02:00
Hannah Wolfe
3a58b6402a Update dependency eslint-plugin-ghost to v3.2.0 
refs: https://github.com/TryGhost/Toolbox/issues/595

- Adds custom rules for node assert
- Enforces assert/strict as an error
 2023-06-21 10:34:37 +01:00
Sodbileg Gansukh
19b8bd2b50 Released Announcement-Bar v1.1.6 2023-06-21 17:04:56 +08:00
Sodbileg Gansukh
c1cd18b526 Added correct cursor style to announcement bar links 2023-06-21 17:03:58 +08:00
Hannah Wolfe
6161f94910
Updated to use assert/strict everywhere (#17047) 
refs: https://github.com/TryGhost/Toolbox/issues/595

We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default.

This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results:
- Url matching needs to be done on `url.href` see aa58b354a4
- Null and undefined are not the same thing,  there were a few cases of this being confused
- Particularly questionable changes in [PostExporter tests](c1a468744b) tracked [here](https://github.com/TryGhost/Team/issues/3505).
- A typo see eaac9c293a

Moving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
 2023-06-21 09:56:59 +01:00
Simon Backx
3e932458a4 Released Signup Form v0.1.3 2023-06-21 10:48:22 +02:00
Simon Backx
40f71cb79b 🐛 Fixed accessibility issue with hidden success message in signup form 
refs https://ghost.slack.com/archives/CTH5NDJMS/p1686928938857799

The button read 'Subscribe email sent' on screen readers.
 2023-06-21 10:38:27 +02:00
Daniel Lockyer
1be11e4648
Fixed include path for signup-form translations 
- this fixes the path after we moved the signup-form folder between
  workspace folders
 2023-06-21 09:12:28 +02:00
renovate[bot]
e3c9af380c Update dependency @storybook/testing-library to v0.2.0 2023-06-21 08:12:26 +02:00
Daniel Lockyer
5c4ef092b6 Updated vitest to v0.32 
refs https://github.com/TryGhost/Ghost/pull/16949
refs https://github.com/vitest-dev/vitest/releases/tag/v0.32.0

- contains a switch from `@vitest/coverage-c8` to `@vitest/coverage-v8`
  as this is now required in 0.32
 2023-06-20 14:54:04 +02:00
renovate[bot]
ea3ab6beb6 Update dependency @vitejs/plugin-react to v4.0.1 2023-06-20 08:09:23 +02:00
Daniel Lockyer
2173fd9ef9 Moved signup-form to apps/ folder 
refs https://github.com/TryGhost/Toolbox/issues/594

- we're moving all the standalone apps to a separate folder to keep them
  out of the core code and easier to find
 2023-06-19 09:43:33 +02:00
Daniel Lockyer
e13fcd3272
Released Portal v2.33.2 2023-06-16 13:41:31 +02:00
Daniel Lockyer
f3894d5898 Moved Portal to apps/ 
refs https://github.com/TryGhost/Toolbox/issues/594

- we're moving all the standalone apps to a separate folder to keep them
  out of the core code and easier to find
 2023-06-16 13:37:58 +02:00
Elena Baidakova
333471c263 Released Announcement-Bar v1.1.5 2023-06-15 09:54:19 +04:00
Daniel Lockyer
7a124a6901 Moved announcement-bar to apps/ 
refs https://github.com/TryGhost/Toolbox/issues/594

- we're moving all the standalone apps to a separate folder to keep them
  out of the core code and easier to find
 2023-06-14 12:28:55 +02:00
Daniel Lockyer
fa43a0236b Moved Sodo-Search into apps/ 
refs https://github.com/TryGhost/Toolbox/issues/594

- this is the first of a set of commits to move our "apps" into the
  `apps/` folder, so we don't mix Ghost core and standalone apps
 2023-06-14 12:10:57 +02:00
Daniel Lockyer
33fa048c7e Pinned dependencies 
- Comments-UI is an app so we should pin the dependencies to ensure we
  know what version it is running
 2023-03-21 09:59:12 +01:00
Daniel Lockyer
fac4ec7876 Fixed minor linting issues 
- these classes needed to be reordered to satisfy eslint-plugin-tailwindcss
 2023-03-17 12:19:52 +01:00
Sodbileg Gansukh
1892be929b v0.12.4 2023-03-14 18:46:10 +08:00
Rishabh
7aa1281e45 Fixed build script not working on Node 18.x 
- `yarn start:dev` was failing with `error:0308010C:digital envelope routines::unsupported` without the `--openssl-legacy-provider` option on Node 18. Currently react-scripts@4.x doesn't support Node 18, so until we upgrade to use react-scripts@5.x we'll need to pass in this change for build scripts
 2023-03-14 15:42:40 +05:30
Sodbileg Gansukh
be7e3f3e62 Fixed invisible top border issue of the form input (#14) 
refs https://github.com/TryGhost/Team/issues/2615
 2023-03-14 18:11:49 +08:00
James Morris
4abbb0a8ca v0.12.3 2022-11-11 15:33:51 +00:00
James Morris
a41259be27 Fix the word break for long links in comments on mobile 
refs https://github.com/TryGhost/Team/issues/2245
 2022-11-11 15:31:34 +00:00
James Morris
9bcdfb911d Removed the duplicate sm config 
refs https://github.com/TryGhost/Team/issues/2244
 2022-11-11 15:25:57 +00:00
James Loh
62149ea747 v0.12.2 2022-11-08 10:06:51 +11:00
Kevin Ansfield
c334afef3a v0.12.1 2022-11-07 22:45:15 +00:00
Kevin Ansfield
fcf8570393 🐛 Fixed error rendering count with no number (#13) 
refs https://github.com/TryGhost/Team/issues/2221

- added guard to `formatNumber` helper used in the `<Count>` component via the `<ContentTitle>` component so a missing count prop is handled gracefully
 2022-11-07 22:40:58 +00:00
e.baidakova
cb6bf40f56 v0.12.0 2022-11-04 09:28:47 +04:00
James Morris
6956b82245 Add comma separators to all numbers in comments 
refs https://github.com/TryGhost/Team/issues/2210
 2022-11-03 15:47:49 +00:00
e.baidakova
40c26a26f6 v0.11.0 2022-11-02 10:22:49 +04:00
Elena Baidakova
290e3d5713 Updated counts api url (#12) 
closes TryGhost/Team#2094
- Counts request was changed from `post` to `get` for enable request caching.
 2022-11-02 10:02:26 +04:00
Simon Backx
883a9728ca v0.10.3 2022-10-10 11:45:22 +02:00
Simon Backx
a2daf2e448 🐛 Fixed CMD+C focussing main form 
fixes https://github.com/TryGhost/Ghost/issues/15563
 2022-10-10 11:43:07 +02:00
James Morris
1a00c070d1 v0.10.2 2022-10-06 16:25:19 +01:00
James Morris
92dec78902 Improving the border, text and buttons to work in light, dark and other weird colours 
- Changed all borders to work better in different background colours
- Same goes for main buttons like pagination for main and reply
- Same goes for any secondary text which should help

no issue
 2022-10-06 16:06:40 +01:00
Simon Backx
ec586d02af Removed start-server-and-test dev dependency 2022-09-09 17:34:21 +02:00
Simon Backx
68c2e6a30d Removed Cypress from CI 
refs 24af5ad0dd

CI is not working yet with Cypress atm.
 2022-09-09 17:32:57 +02:00
Simon Backx
24af5ad0dd Added experimental Cypress tests 
refs https://github.com/TryGhost/Team/issues/1780

This commit adds some Cypress tests as a POC to the project. If we decide to go with Cypress, we can add more tests to cover the rest of the codebase. The main reason to have a E2E framework is that some editor related UI is hard to test with the React tests because it uses JSDOM.
 2022-09-09 17:27:32 +02:00
Simon Backx
ddbc2db76d Fixed error when not signed in as admin 
no issue

When loading comments UI without being logged in as an admin, it would throw an error every time when unpacking result.users[0].
 2022-09-09 12:05:14 +02:00
Simon Backx
500ebf0de2 Prevented relative time updates on comment state changes 
no issue

When the state of a comment changes (e.g., after a like) the relative time would update. This is not desirable because it looks glitchy. If the relative time doesn't update every second, then it is better to never update it after the initial render.
 2022-09-09 11:52:26 +02:00
Simon Backx
f72e804d08 Removed event bus 2022-09-09 11:48:24 +02:00
Simon Backx
527abdbcd6 Cleaned up ContentBox and PopupBox 2022-09-09 11:46:55 +02:00
Simon Backx
65dd6bd1d6 Cleaned up component props 2022-09-09 11:46:08 +02:00