4 commits

Author	SHA1	Message	Date
Naz	4a47e8d0a8	Changed settings loader module API signature ... refs https://linear.app/tryghost/issue/CORE-35/refactor-route-and-redirect-settings - It was not clear from the module signature/usages that the default method is executing synchronously. The change makes it explicit. Knowing if the method is synchronous is helpful to stop possible pefr bottlenecks!	2021-09-28 04:59:41 +13:00
Naz	93af11bdec	Simplified knowSettings usage ... refs https://linear.app/tryghost/issue/CORE-35/refactor-route-and-redirect-settings - 'knowSettings' was based on a "configurable" array of settings that might be configured in Ghost. The multitude never happened! The only setting the frontend takes care of is routes.yaml file (redirects is also kind of a setting but is a separate concept for now). - Having just one type of file to deal with allows to simplify implementation significantly, which helps before a big refactor	2021-09-28 04:59:41 +13:00
Naz	010db90a51	Removed unused getAll settings method ... refs https://linear.app/tryghost/issue/CORE-35/refactor-route-and-redirect-settings - The getAll function was never used. No need to keep it around!	2021-09-28 04:59:41 +13:00
Hannah Wolfe	f08a55c21f	Renamed tests to .test.js & updated commands ... refs: https://github.com/TryGhost/Team/issues/856 refs: https://github.com/TryGhost/Team/issues/756 - The .test.js extension is better than _spec.js as it's more obvious that it's an extension - It also meaans we can use the --extension parameter in mocha, which should result in a better default behaviour for `yarn test` - It also highlights that some of our tests were named incorrectly and were not (and still will not be) run (see https://github.com/TryGhost/Team/issues/856) - Note: even with this change, `yarn test` is throwing errors, I believe because of this issue https://github.com/TryGhost/Team/issues/756	2021-07-06 20:45:01 +01:00

Renamed from test/unit/services/settings/settings_spec.js (Browse further)