Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity
6859 commits 231 branches 1692 tags 528 MiB
Commit graph

5031 commits

Author SHA1 Message Date
Hannah Wolfe
3e727d01f7 Refresh assetHash on theme activation (#7464) 
closes #7423

- asset hashes have never been refreshed properly!
- Ghost(Pro)'s 1-theme-only limitation has been hiding this bug for 3 years 🙄
 2016-09-30 13:13:16 +02:00
kirrg001
d0356a257e 🐛 fix circular dependency in new bootUp script 
closes #7440
 2016-09-27 12:18:45 +02:00
kirrg001
5e8baace22 Updated Ghost-Admin to 1.0.0-alpha.2 2016-09-26 19:22:11 +02:00
Ryan McCarvill
7edc518d5a [WIP] Mobile-Doc based renderer (#7437) 
Refs #7429

Added mobile-doc renderer

------------

- Added generic mobiledoc-renderer
- Kept the existing showdown editor for legacy mode.
 2016-09-26 15:23:49 +02:00
Hannah Wolfe
6c24084e68 Merge pull request #7422 from kirrg001/feature/users-invites-separation 
🎨  Separate invites from user

refs #7420

- remove invite logic from user
- add invite model and adapt affected logic for inviting team members
 2016-09-26 13:26:01 +01:00
Hannah Wolfe
b0af496c98 💄 Ensure all middleware use named functions (#7434) 
no issue

- anonymous functions are hard to debug in memory traces etc
- having anonymous middleware functions makes it hard to inspect or debug the middleware stack (something I like to do)
- these 2 are the only ones atm, including all 3rd party middleware
 2016-09-26 11:10:44 +02:00
kirrg001
b79a18ca8f 🎨 Separate invites from user 
refs #7420
- remove invite logic from user
- add invite model and adapt affected logic for inviting team members
 2016-09-26 11:08:43 +02:00
kirrg001
6c100a171e 🛠 update lodash,knex and bookshelf to latest versions 
refs #7189
- we had a memory leak after upgrading to knex 0.11.x
- knex has published a new version 0.12.x
- the memory leak does not longer exists
- knex has reverted their pool logic, see https://github.com/tgriesser/knex/pull/1665
 2016-09-26 10:20:55 +02:00
Hannah Wolfe
264661ee09 🐛 Refresh assetHash on theme override (#7430) 
closes #7423

- Extend our dirty theme override cache clear hack to also reset the asset hash
_ This brings alpha into line with the LTS branch
- This still needs a rewrite for Ghost 1.0.0 🙄
 2016-09-23 13:05:44 +02:00
Hannah Wolfe
26efcc4936 Updated Ghost-Admin to 1.0.0-alpha.1 2016-09-20 16:39:30 +01:00
Hannah Wolfe
6a4c58073d Update Ghost-Admin to 1.0.0-alpha.0 2016-09-20 15:59:34 +01:00
Katharina Irrgang
32a5982430 ✨ utf8mb4 support (#7409) 
closes #5519, closes #6197

- default encoding is utf8mb4 instead of utf8
- support emojis
- read here why: http://dev.mysql.com/doc/refman/5.7/en/innodb-restrictions.html
- read here why: https://dev.mysql.com/doc/refman/5.5/en/charset-unicode-conversion.html
 2016-09-20 15:59:34 +01:00
Hannah Wolfe
9a520f39fb 🎨 Preparation for going alpha (#7404) 
- Don't let people start Ghost Alpha with non-alpha databases.
- Provide a new welcome message for development mode (a little bit of positive reinforcment)
- Provide a RED WARNING when in production mode (will still be used for developing, but we can ignore)
- Change package.json to 1.0.0-alpha.0, we won't relelase this, will bump to .1 for release
 2016-09-20 15:59:34 +01:00
Austin Burdine
25a9b4aa3a 🔥 remove preinstall node version check (#7403) 
no issue
- this is now handled in Ghost-CLI
 2016-09-20 15:59:34 +01:00
kirrg001
8115d83782 🔥 remove postgres support 
refs #1333, refs #5878, refs #5321
 2016-09-20 15:59:34 +01:00
kirrg001
79bf09a7c1 🚨 fix admin_spec && module_spec 
no issue
 2016-09-20 15:59:34 +01:00
kirrg001
231fea4766 🎨 adaption from master merge 
no issue
[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
6a97873f98 🎨 🔦 refactor content paths (images, apps, themes, storage, scheduling) 
refs #6982
- create config util fn: getContentPath
- we can later let the user change the folder names in contentPath
- get rid of custom/default storage paths

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
0487ac5a1b 🔥 🔦 we no longer keep config and configExample in config 
refs #6982
- see https://github.com/TryGhost/Ghost/blob/master/core/server/config/index.js#L217
- remove tests for it

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
66129ed9da 🔥 remove all config tests for file and deprecated config 
refs #6982
[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
ef50c6a149 🎨 🔦 theme url is no longer defined in config 
refs #6982
- it's for now defined where all theme properties get set: in api/settings.js
- it's not the best place, but for now the place where i think it makes the most sense
- see https://github.com/TryGhost/Ghost/blob/playground/core/server/api/settings.js#L63

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
bd4590d0b5 🎨 🔦 no support for active storage adapter as string 
refs #6982
[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
3e02dbf734 🎨 missing get/set config changes 
refs #6982
[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
248ceba72b 🎨 adapt bootstrap file because of nconf changes 
refs #6982
- remove load config
- remove checkDeprecated
- adapt arguments for scheduling init

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
042e0da1c9 🎨 🔦 read ghost version from package.json 
refs #6982
[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
d42f4f6058 🎨 replace config.getSocket() 
refs #6982
- was a function in ConfigManager
- does belong to the GhostServer logic

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
f4bee50e86 🎨 create assetHash if not available in asset_url helper 
refs #6982
- was before generated in ConfigManager

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
66dbd5f5f2 🚨 adapt fork logic 
refs #6982
- write json file instead of js file
- simplifiy how we pass config for a forked child process

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
b158a3a944 🚨 change logic for test/utils/configUtils 
refs #6982
- adaption because of using nconf
- change tests which changed config directly

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
bdad235f6a 🚨 improve error handling in test env 
no issue
[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
b3bafa4ba8 🎨 🔦 restrict themes storage to local-file-store 
refs #6982
- this was handled before by the old ConfigManager
- this logic belongs into the storage logic itself
- for now we only allow uploading themes via the local-file-store

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
1f85604d09 🎨 remove circular dependency solution in errors/index.js 
refs #6982
[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
34e48dc49a 🎨 🔦 do not append isPostgreSQL to config 
refs #6982
- we cannot add functions to nconf

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
0ae0a0b490 🎨 change how we get and set config 
refs #6982
- a replace for all config usages
- always use config.get or config.set
- this a pure replacement, no logic has changed

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
7d3e8fa8a9 ✨ 🔦 add nconf files 
refs #6982
- add defaults.json
- add overrides.json
- add env specific default values
- add nconf wrapper in /config
- add config utils in /config/utils.js

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
96203a46dc 🔥 remove config.example.js and ConfigManager 
refs #6982
[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
e3c0200f73 🔥 remove startup checks 
refs #6982
- we will execute the startup checks in Ghost-CLI

[ci skip]
 2016-09-20 15:59:34 +01:00
kirrg001
0b2940d587 🎨 add getSubdir and getProtectedSlugs 
refs #6982

- do not add the subdir property as static config value
- create functions to read subdir and protected slugs on runtime
 2016-09-20 15:59:34 +01:00
kirrg001
0dd3d9ff40 🎨 Move tests: create utils/url_spec.js 
refs #6982
 2016-09-20 15:59:34 +01:00
Katharina Irrgang
c8119eee1f 🎨 source out url utils from ConfigManager (#7347) 
refs #6982
 2016-09-20 15:59:34 +01:00
Katharina Irrgang
dc1ef35f0c 🎨 do not load apps in ConfigManager (#7344) 
refs #6982
 2016-09-20 15:59:34 +01:00
Katharina Irrgang
a639e48715 🎨 load themes not in ConfigManager (#7342) 
refs #6982
 2016-09-20 15:59:34 +01:00
Hannah Wolfe
55d1e86c55 Update Ghost-Admin: ready for lts 2016-09-20 14:27:25 +01:00
Austin Burdine
756d9bcb6e show correct error message the first time account is locked (#7263) 
closes #7251

- check if remaining attemps is 0, if so then show account locked error
- adds test
 2016-09-19 14:56:55 +01:00
Katharina Irrgang
9349e99e54 🐛 fix delete by author as transaction (#7145) 
closes #7137

Deleting the content from the database runs in a transaction. see
https://github.com/TryGhost/Ghost/blob/master/core/server/api/users.js#L390

`destroyByAuthor` is one of the operations we trigger to delete all the conent, see https://github.com/TryGhost/Ghost/blob/master/core/server/models/post.js#L647

The post model has a specific hook for deleting content to delete the relations as well, see https://github.com/TryGhost/Ghost/blob/master/core/server/models/post.js#L122

This hook is part of the transaction. But the `options` are ignored. `(model/*, attr, options*/)` 
We use the `options` to forward the transaction reference, which we need to pass into the bookshelf queries. So `return model.load('tags').call('related', 'tags').call('detach')` does not forward the transaction and that's why it stucks when deleting the content.
 2016-09-19 14:45:36 +01:00
Katharina Irrgang
265f058466 🎨 use apiUrl helper for scheduling initialisation (#7400) 
no issue
- extend apiUrl to return either an admin url for CORS or not
 2016-09-19 14:41:50 +01:00
Cezary Kluczyński
83b426ad14 Changed formatting of run time to human readable (#7318) 2016-09-19 11:28:18 +01:00
Hannah Wolfe
a422314e6f Updated Ghost-Admin to 0.11.0 2016-09-15 10:23:15 +01:00
Katharina Irrgang
ed9e90419d 🐛 generate correct apiUrl for scheduling (#7389) 
closes #7388
 2016-09-15 10:22:38 +01:00
Hannah Wolfe
a791b43f1e 🐛 😱 Fixing extract-zip derp-moment 
There are no words for this!
 2016-09-14 22:47:41 +01:00