5 commits

Author	SHA1	Message	Date
kirrg001	6f6c8f4521	Import lib/common only ... refs #9178 - avoid importing 4 modules (logging, errors, events and i18n) - simply require common in each file	2017-12-12 10:28:13 +01:00
kirrg001	ac2578b419	Moved errors,logging,i18n and events to lib/common ... refs #9178	2017-12-12 10:28:13 +01:00
Hannah Wolfe	69657a1ac6	Keep the original error in registerAsyncTheme (#8977) ... refs #8945 - pass the original error as part of the errorDetails - improves logging, so we know what really went wrong - for debug purposes - can be removed at some point	2017-09-05 20:11:59 +02:00
Hannah Wolfe	b6b2930d15	🐛 Fixed error handling in async helpers ... refs #8703 - Always always call cb() even if we get an error! - Ensure the error is handled, and converted to a GhostError if not already - If we're in development mode, render the error. Else render nothing.	2017-08-29 10:31:00 +02:00
Hannah Wolfe	243b387063	✨ Helper Proxy & single express-hbs instance (#8225) ... refs #8126, #8221, #8223 ✨ New 'Proxy' for all helper requires - this is not currently enforced, but could be, much like apps - the proxy object is HUGE - changed date to use SafeString, this should have been there anyway - use the proxy for all helpers, including those in apps 😁 ✨ 🎨 Single instance of hbs for theme + for errors - we now have theme/engine instead of requiring express-hbs everywhere - only error-handler still also requires express-hbs, this is so that we can render errors without extra crud - TODO: remove the asset helper after #8126 IF it is not needed, or else remove the TODO 🎨 Cleanup visibility utils 🎨 Clean up the proxy a little bit 🚨 Unskip test as it now works! 🎨 Minor amends as per comments	2017-04-04 18:07:35 +02:00