0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Commit graph

4502 commits

Author SHA1 Message Date
Kevin Ansfield
2335bba40a Fix stretched team image on setup/three
closes #6380
- wraps `<img>` element with a `<div>` to workaround buggy browser behaviour (https://github.com/philipwalton/flexbugs/issues/14)
- adds explicit `width: 100%` to `img` element to fix Firefox not scaling down to mobile sizes
2016-02-02 15:08:28 +00:00
Hannah Wolfe
ad6e37bf79 Merge pull request #6426 from kevinansfield/fix-forgot-password-regression
Acceptance tests for password reset flow on signin screen
2016-02-02 13:58:59 +00:00
Kevin Ansfield
35a7dc2971 Acceptance tests for password reset flow on signin screen
refs #6039
- adds `/authentication/passwordreset` endpoint to mirage config
- tests the "Forgot?" link behaviour on the signin form

NB: This will fail until #6425 is merged as this tests the correct behaviour rather than the currently broken behaviour ;-)
2016-02-02 12:22:41 +00:00
Fabian Becker
1a7a763c9f Correctly use POST request to reset password
closes #6423
2016-02-02 12:58:39 +01:00
Kevin P. Kucharczyk
dc957d7d2e Fix missing nav-current class bug when trailing slashes don't match
closes #6422
- trim trailing slashes before comparing URLs in navigation helper
- add test case to make sure nav-current is appended regardless of trailing slash presence
2016-02-02 11:47:13 +01:00
James Seymour-Lock
ffab3127ae UI/CSS Improvements
Remove shadow on last tag item hover, was an inconsistent style addition thats not used elsewhere such as the content list
- Remove box-shadow on last of type settings tag hover state
- http://g.recordit.co/CEglFT7Hlr.gif

Remove * selector and specify user-select on individual classes for performance.
- remove * selector
- update classes that benefit from user-select none

Having different visuals based around if a radio/checkbox uses a label or not is weird and style changes should use a class modifier.
- Merged the two together as I was unable to find an example checkbox/radio in use that did not use the label tag

Improved UI for radio/checkboxes
- Added cursor pointer to radio/checkboxes
- Added hover state to radio/checkboxes

Add cursor to select boxes for usability
- cursor: pointer; added to select boxes

Add hover state to post edit icon
- add dark grey hover state to post edit icon

Add visual hover to nav user menu dropdown
- Move dropdown icon to visually indicate hover
2016-01-28 08:35:43 -05:00
Kevin P. Kucharczyk
f075221598 Fix missing tags list link on mobile
closes #6397
- don't pass isMobile to gh-tag-settings-form
- add gh-tag-settings-form test for mobile settings.tags link
2016-01-26 18:42:13 +01:00
Kevin P. Kucharczyk
08d6e56b28 Fix posts.post route not redirecting to 404
closes #6385
- redirect to 404 when post is not found
- replace replaceRoute calls with replaceWith calls in routes (replaceRoute is only available on controllers)
- add post mirage factory
- add acceptance test for post 404 redirection
2016-01-26 15:25:53 +01:00
Sebastian Gierlinger
feb59fa714 Merge pull request #6382 from kevinansfield/upgrade-simple-auth
deps: ember-simple-auth@1.0.1
2016-01-26 15:06:25 +01:00
Hannah Wolfe
08e5848d4a Fix cache-control header for sitemaps
no issue

- sitemaps were getting max-age=undefined as they were depending on the wrong utils folder
- test + fix included
2016-01-25 17:56:05 +00:00
Kevin Ansfield
7c1f26cad7 deps: ember-simple-auth@1.0.1
closes #6381
- fixes event forwarding in adaptive session store
2016-01-25 15:52:07 +00:00
Hannah Wolfe
e5e375057e Merge pull request #6299 from acburdine/config-refactor
Refactor Config Service
2016-01-25 13:22:20 +00:00
Kevin Ansfield
d74d0d63b1 Merge pull request #6372 from jamesslock/copyright-update
Always show current year in copyright text on "About" page
2016-01-25 13:07:43 +00:00
Hannah Wolfe
08058ec750 Merge pull request #6379 from kevinansfield/fix-jquery-ajax-401
Fix 401 error when uploading images
2016-01-25 12:39:30 +00:00
Hannah Wolfe
4e355ecba9 Merge pull request #6374 from jtwebman/admin_error_no_theme
Fixed ghost admin error when missing theme folder.
2016-01-25 12:29:31 +00:00
Hannah Wolfe
c29187a5fe Merge pull request #6370 from jtwebman/meta_data_to_functions
Started moving meta data fetching to functions.
2016-01-25 12:16:20 +00:00
Hannah Wolfe
15cb71b408 Merge pull request #6335 from damsonn/fix-mailer-specs
Improve test coverage for mailer
2016-01-25 12:05:15 +00:00
Kevin Ansfield
8ddf160240 Merge pull request #6365 from acburdine/remove-on
remove more usage of Ember.on
2016-01-25 11:42:32 +00:00
James Seymour-Lock
4ea3e13bd4 Always show current year in copyright text on "About" page
no issue
- add `copyrightYear` CP to about page controller
- displays the current year in the copyright notice
2016-01-25 11:33:10 +00:00
Kevin Ansfield
c55d9699ef Fix 401 error when uploading images
closes #6377
- restores ajax prefilter initializer that was removed in #6243
- adds regression test for standard `$.ajax` requests sending Authorization header

This can be removed once we no longer have jquery plugins that make internal ajax calls that don't go through ember-ajax.
2016-01-25 11:11:29 +00:00
JT Turner
cdc98dce15 Fixed ghost admin error when missing theme folder.
closes #6368
- Add test to recreate the error in the static theme middleware.
- Updated static theme middleware to not error if missing theme folder.
2016-01-23 14:01:26 -08:00
JT Turner
1f4c01d207 Started moving meta data fetching to functions.
issue #6186
- Moved asset helper logic to a asset url function.
- Created author image function to be used in ghost_head helper.
- Created author url function to be used in the ghost_head helper.
- Created canonical url function to be used in the ghost_head helper.
- Moved meta_description helper logic to a function.
- Moved excerpt helper logic to a function.
- Created an index in data/meta to be used in ghost_head helper to get all data.
- Created keyword function to be used in the ghost_head helper.
- Created modified data function to be used in the ghost_head helper.
- Created next url function to be used in the ghost_head helper.
- Created ogType function to be used in the ghost_head helper.
- Created previous url function to be used in the ghost_head helper.
- Created published data function to be used in the ghost_head helper.
- Created rss url function to be used in the ghost_head helper.
- Created schema function to be used in the ghost_head helper.
- Created structured data function to be used in the ghost_head helper.
- Moved meta_title helper logic to a title function.
- Moved url helper logic to a url function.
- Wrote tests for all the new functions

This is just the first step. I plan on refactoring the ghost head to use these new functions.
2016-01-23 13:58:21 -08:00
Kevin P. Kucharczyk
9eac05e082 Standardise client property names to camelCase
closes #6018
- added keyForAttribute method in application serializer
- override keyForAttribute in settings serializer to not apply camelCase/underscore conversion
- rename under_scored properties to camelCased
2016-01-23 19:12:22 +01:00
John O'Nolan
100ab9ecef Update copyright year
To appease James Seymour-Lock
2016-01-23 17:28:17 +02:00
Damien Dormal
58fe7af7d1 Cleanup and improved test coverage for mailer
closes #5489
- Remove unneeded Promise.promisify in mailer
- Remove noEmailTransportConfigured error as not relevant anymore (Direct is default)
- Clone message argument in mailer.send
- Move test from api_mail_spec to mail_spec
- Add default mail title test
2016-01-23 11:49:01 +08:00
Hannah Wolfe
57ae36ab21 Merge pull request #6341 from kevinansfield/fix-mixed-content-on-team-page
Move user/cover image files used in admin team area into the client folder
2016-01-21 09:46:00 +00:00
Hannah Wolfe
c549914ae8 Merge pull request #6316 from halfdan/5606-subdir
Make regex for subfolder deduplication more restrictive
2016-01-20 20:09:29 +00:00
Kevin Ansfield
929f9e89b2 deps: ember@2.3.0
no issue
- predominantly a bugfix and performance related release
- https://github.com/emberjs/ember.js/releases/tag/v2.3.0
- http://emberjs.com/blog/2016/01/15/ember-2-3-released.html
- some deprecations are introduced around the use of injected `container` objects, these are from `ember-simple-auth` and should be rectified with an up-coming release
2016-01-20 13:16:15 +00:00
Hannah Wolfe
25d90822c3 Merge pull request #6364 from kevinansfield/deps-mirage
deps: ember-cli-mirage@0.1.11
2016-01-20 08:53:57 +00:00
Hannah Wolfe
7234cb7931 Merge pull request #6329 from kevinansfield/ember-data-2-3
deps: ember-data@2.3.2
2016-01-20 08:52:27 +00:00
Austin Burdine
7e2fa64278 remove more usage of Ember.on 2016-01-19 10:00:44 -06:00
Austin Burdine
7d304a046f refactor admin config to include explicit value types
closes #6266
- add "type" to valid keys in configuration api
- refactor ember config service to parse values based on provided type
2016-01-19 09:43:09 -06:00
Hannah Wolfe
1b5b6cf6e3 Merge pull request #6314 from halfdan/6287-import
Only import tables defined in core/server/data/schema.js
2016-01-19 15:22:24 +00:00
Kevin Ansfield
4f80d97d02 deps: ember-cli-mirage@0.1.11
no issue
- contains bugfixes for a couple of issues that we luckily haven't run into yet but likely will as we expand acceptance testing
2016-01-19 14:41:54 +00:00
Kevin Ansfield
f401d6f3e5 deps: ember-data@2.3.2
no issue
- updates ember-data dependency and switches to direct es6 module import instead of destructuring assignment
- fixes issue with `authenticationFailed` action being called before transitions have finished
2016-01-19 14:36:39 +00:00
Austin Burdine
250e7a3b8b cleanup usage of Ember.inject 2016-01-19 07:03:27 -06:00
Austin Burdine
022bf364c2 deps: ember-ajax@0.7.1 2016-01-18 09:37:14 -06:00
Kevin Ansfield
5ab0710da3 Merge pull request #6353 from kevinkucharczyk/loading-image-switching-tags
Clear images in gh-uploader when navigating between items
2016-01-18 10:13:38 +00:00
Kevin Ansfield
61b7ac9917 Merge pull request #6350 from acburdine/ember-2.2.1
Update Ember to 2.2.1
2016-01-17 13:18:49 +00:00
Kevin P. Kucharczyk
41a18c9262 Clear images in gh-uploader when navigating between items
closes #6198
- clear img src in gh-uploader when navigating to item with image
- always reset uploader component when new image is not empty
2016-01-16 21:54:02 +01:00
Kevin Ansfield
9fda1dc5ba Merge pull request #6348 from zinyando/adapter-fix
Make sure super in buildURL passes all arguments
2016-01-16 18:40:41 +00:00
Austin Burdine
beed0dbf6f deps: ember@2.2.1 2016-01-16 10:35:56 -06:00
zinyando
6659ecc6b6 Make sure super in buildURL passes all arguments 2016-01-15 19:13:36 +02:00
Austin Burdine
4862a9051c refactor slug-generator object into a service
refs #6243
2016-01-15 09:43:17 -06:00
Kevin Ansfield
da0a0c559b Move user/cover image files used in admin team area into the client folder
no issue
- fixes potential "mixed content" warnings if non-admin urls are redirected
2016-01-14 16:26:48 +00:00
Sebastian Gierlinger
749bd29e12 Merge pull request #6337 from halfdan/6332-i18n-startup
Revert i18n in startup-check
2016-01-14 10:05:25 +01:00
Kevin Ansfield
5dba4fab5c Merge pull request #6331 from novaugust/draft_preview_notification
Add Preview link to draft saved notification
2016-01-13 14:27:52 +00:00
Fabian Becker
eef37acc49 Revert i18n in startup-check
- Removes preinstall dependencies
- Reintroduce old plain english strings
- Remove translations for startup check

closes #6332
2016-01-13 14:46:51 +01:00
Matt Enlow
c349394563 Add Preview link to draft saved notification
Closes #6330
- also change notifications to open with `target=_blank`
2016-01-13 06:44:51 -07:00
Sebastian Gierlinger
cb72792bb7 Merge pull request #6212 from kevinansfield/isolate-editor
Isolate all markdown editor behaviour into `gh-editor` component
2016-01-13 14:41:33 +01:00
Kevin Ansfield
ead352dd83 Isolate all markdown editor behaviour into gh-editor component
no issue
- move all existing markdown editor behaviour out of the editor controller and isolate it into a single component that can be swapped out
- split the `register/remove` functions of the `shortcuts-route` out into a separate `shortcuts` mixin
2016-01-13 12:01:31 +00:00
Kevin Ansfield
110ee9198c deps: ember-mocha@0.8.6 2016-01-13 11:29:59 +00:00
Kevin Ansfield
7c49824ae2 deps: ember-cli-mocha@0.9.8 2016-01-13 11:28:59 +00:00
Kevin Ansfield
22206f4b4f Merge pull request #6327 from halfdan/6326-lskey
Set localStorage key based on subdir
2016-01-12 21:22:20 +00:00
Hannah Wolfe
c30f1d5ed7 Merge pull request #6088 from kevinansfield/liquid-tether-modals
Modals refactor
2016-01-12 21:11:38 +00:00
Kevin Ansfield
1c6b208047 Refactor modals
refs #5798, closes #5018
- adds new `gh-fullscreen-modal` component - modals are now specified in-context so that they can have deeper interaction with their surrounding components/controller/route, i.e. a modal component can be a thin confirm/deny wrapper over the underlying controller action keeping all context-sensitive logic in one place
- adds spin-buttons to all modals with async behaviour
- adds/improves behaviour of inline-validation in modals
- improves re-authenticate modal to properly handle validation and authentication errors
2016-01-12 20:53:08 +00:00
Kevin Ansfield
d710bdea1a deps: ember-hash-helper-polyfill@0.1.0 2016-01-12 20:49:46 +00:00
Kevin Ansfield
b4b2f06868 deps: ember-route-action-helper@0.2.0 2016-01-12 20:49:46 +00:00
Kevin Ansfield
a6aabfc591 deps: liquid-fire@0.22 2016-01-12 20:49:46 +00:00
Kevin Ansfield
7ea536b6b0 deps: liquid-tether@0.1.9 2016-01-12 20:49:46 +00:00
Kevin Ansfield
adfa250158 Remove use of Ember.on
no issue
- removes the few uses of `Ember.on` for lifecycle hooks or event hooks where order may be important

`Ember.on` use is discouraged so although we haven't used it often I felt like we should ensure we're consistent throughout the codebase. There's a great article with details of why it's discouraged here: http://notmessenger.com/proper-use-of-ember-on/
2016-01-12 20:48:15 +00:00
Hannah Wolfe
4a7a19c86a Merge pull request #6070 from kevinkucharczyk/harvesting-server-side-strings
Harvest server side strings
2016-01-12 20:04:53 +00:00
Fabian Becker
d57f189294 Set localStorage key based on subdir
closes #6326
2016-01-12 17:12:59 +01:00
Kevin Ansfield
58e699a209 Merge pull request #6321 from AileenCGN/test
Minor usability improvements for editor screen #6318
2016-01-12 09:49:08 +00:00
Hannah Wolfe
a658be931f Merge pull request #6317 from kevinansfield/quick-fix-unnecessary-leave-editor-modal
Quick-fix for unnecessary "discard changes" modals
2016-01-12 09:39:59 +00:00
Hannah Wolfe
593a20cd7a Merge pull request #6297 from jtwebman/bug_mixed_content_firefox
Fix urlFor to handle secure correctly as well as canonical urls.
2016-01-12 09:27:00 +00:00
JT Turner
e4c52a6915 Fix urlFor to handle secure correctly
issue #6270
- Exposed getBaseUrl on the config class.
- Fix formatting config index as array was more then 140 characters long.
- Updated getBaseUrl to handle secure by replacing http with https if true.
- Fixed ghost_head helper to output canonical base url no https.
- Fixed ghost_head helper to set secure correctly for the rss link.
- Fixed navigation helper to pass secure in each nav item, so that urlFor can u$
- Fixed {{url}} to pass secure correctly to config.urlFor.
- Fixed test to use urlSSL over https besides for canonical.
- Add tests for {{url}} and to make sure they output https for absolute and secure.
- Update twitter and og url to use the canonical url.
2016-01-11 19:40:30 -08:00
AileenCGN
d66e9e745e Minor usability improvements for editor screen
closes #6318
2016-01-11 20:34:04 +02:00
Hannah Wolfe
b748137a10 Merge pull request #6307 from kevinansfield/fix-step3-endless-spinner
Redirect after setup step 3 even if invite requests time out
2016-01-11 18:10:27 +00:00
Kevin Ansfield
b407dcf06e Quick-fix for unnecessary "discard changes" modals
closes #6315
- don't set the `slug` attribute if we get an empty string back from the slug generator to prevent dirty attributes being triggered for `null` getting changed to `''`
2016-01-11 15:58:07 +00:00
Hannah Wolfe
dfa74ffcd5 Merge pull request #6304 from halfdan/fix-6290
Disallow access to author/tag rss feeds if private blogging is on
2016-01-11 14:04:19 +00:00
Fabian Becker
c8e30f0182 Make regex for subfolder deduplication more restrictive
- Add subdir to protected slugs
- Fix regex for subfolder deduplication

fixes #5605
2016-01-11 12:46:59 +01:00
Fabian Becker
2770def8f1 Only import tables defined in core/server/data/schema.js
fixes #6287
2016-01-11 11:56:18 +01:00
Hannah Wolfe
5e2523a305 Merge pull request #6273 from johnny94/add-attributes
Add attributes for `{{tags}}` and `{{#foreach}}` helpers
2016-01-11 10:24:04 +00:00
Szu Yaung
70327c2a74 Add attributes for {{tags}} and {{#foreach}} helpers
issue #6205
- added `from` and `to` attribute for `{{tags}}` and `{{#foreach}}` helpers.
- added tests for these new atttributes
2016-01-10 02:47:36 +08:00
Hannah Wolfe
9ee52d4079 Merge pull request #6300 from kevinansfield/fix-missing-tags-bug
Fix disappearing tags when tag input's selection is swapped out
2016-01-09 16:32:59 +00:00
Hannah Wolfe
816e773f93 Merge pull request #6298 from jtwebman/fix_ghost_head_on_error_page
Fix ghost_head helper to not run if error page.
2016-01-09 13:42:03 +00:00
Hannah Wolfe
5fdfc5a091 Merge pull request #6296 from jgable/imageTags
Refactor sitemap generation to include images consistently
2016-01-09 13:28:32 +00:00
Hannah Wolfe
f0d33f863d Merge pull request #6291 from kevinansfield/fix-private-safari-login
Use AdaptiveStore for cookie fallback if local storage is unavailable
2016-01-09 13:00:19 +00:00
Hannah Wolfe
4229205d23 Merge pull request #6286 from kevinansfield/fix-slow-post-navigation
Fix posts navigation slowdown when lots of posts are loaded
2016-01-09 12:42:21 +00:00
Hannah Wolfe
0071c99fe2 Merge pull request #6285 from kevinansfield/fix-unresponsive-search
Fix unresponsive search
2016-01-08 17:21:59 +00:00
Kevin Ansfield
167aca64f9 Transition after setup step 3 submission even if invite takes a long time
refs #5779
- adds a timeout of 4 seconds to step 3 submission so that we transition even if we haven't heard back from the server yet. Notification alerts will be displayed asynchronously once all server requests have returned.
- adds a message to check e-mail configuration to step 3 invitation failure alert
2016-01-08 17:06:41 +00:00
Hannah Wolfe
4f05bbf6e1 Merge pull request #6254 from kevinansfield/fix-profile-image
Fix teardown of gh-profile-image when fileStorage=false
2016-01-08 15:54:25 +00:00
Kevin Ansfield
c1c8a0a8bc Merge pull request #6294 from ErisDS/issue-6272
Add missing chars to slug generator
2016-01-08 15:11:09 +00:00
Fabian Becker
8a16dd5d7e Disallow access to author/tag rss feeds if private blogging is on
- Also fixes an issue where posts/tags with slugs starting with rss/sitemap became inaccessible

fixes #6290
2016-01-07 15:03:39 +01:00
Kevin Ansfield
2308ca4ed8 Fix disappearing tags when input's selection is swapped out
closes #6257
- update the `_onChange` event handler in `gh-selectize` component so that the re-ordering process isn't hit when the underlying objects have changed
2016-01-06 12:21:39 +00:00
JT Turner
3af224ed39 Fix ghost_head helper to not run if error page.
issue #6289
- Made quick fix to return from ghost_head helper if error page
2016-01-05 23:31:46 -08:00
Jacob Gable
d1348d709f Refactor RSS Image node generation
fixes #6292

- Added createImageNodeFromDatum to BaseSiteMapGenerator
- Refactor some defaults code that was unnecessary
- Add tests for posts, tags, users and posts with images
2016-01-05 21:25:52 -08:00
Hannah Wolfe
c10eb58144 Add missing chars to slug generator
closes #6272

- curly braces and back-tick should also be replaced with a dash
- other symbols and chars in ascii table are either removed or replace
- not all the replacements are sensible, but better than having odd chars in the slug for now
2016-01-05 19:12:44 +00:00
Kevin Ansfield
de6a131d36 Fill in pending tests setup acceptance tests
refs #6039
- test the sad paths in the setup process
2016-01-05 17:03:22 +00:00
Kevin Ansfield
50c3905cb3 Use AdaptiveStore for cookie fallback if local storage is unavailable
closes #5829
- switch application session store to inherit from ESA's `AdaptiveStore` instead of `LocalStorageStore`
2016-01-05 13:16:41 +00:00
Kevin Ansfield
08735aa9bf Fix posts navigation slowdown when lots of posts are loaded
refs #6274
- adds `active-link-wrapper` mixin that tracks the `active` state of child links and adds/removes a `.active` class on the mixed-in element
- removes the passed-in `active` attribute on `gh-posts-list-item` component that forced every item in the content list to be re-rendered each time the currently selected post changed
2016-01-04 16:55:36 +00:00
Kevin Ansfield
ee3339bf18 Fix unresponsive search
closes #6274
- any time the search content is refreshed, start with a clean array instead of performing expensive object comparisons to remove existing content
2016-01-04 12:04:57 +00:00
Austin Burdine
06817fcc54 fix autoscoping of _this in settings/navigation
closes #6267
- adds a hardcoded this because babel's autoscoping isn't triggered by default
2015-12-27 17:25:36 -07:00
Sebastian Gierlinger
c533c48b89 Merge pull request #6251 from ErisDS/issues-6247
Switch channel filters to use strings not literals
2015-12-21 20:20:44 +01:00
Kevin Ansfield
c28f4853b8 Merge pull request #6244 from acburdine/issue-6226
Fix authentication error if setup/two is re-submitted
2015-12-21 11:14:39 +00:00
Kevin Ansfield
cb921a951e Fix teardown of gh-profile-image when fileStorage=false
closes #6253
- don't expect the file input to be present in `willDestroyElement`
2015-12-21 11:08:49 +00:00
Hannah Wolfe
20f102808a Switch channel filters to use strings not literals
fixes #6247

- GQL has a bug where literals starting with numbers are incorrectly parsed
- Using strings instead of literals is a workaround, but is probably safer anyway
2015-12-20 16:03:39 +00:00
Hannah Wolfe
968349236d Merge pull request #6242 from halfdan/6205-last-limit
Fix broken @last for foreach with limit
2015-12-20 14:30:48 +00:00
Hannah Wolfe
fe91944d43 Merge pull request #6240 from halfdan/6239-ghost-api
Fix non-idempotent Ghost API helper
2015-12-20 14:30:34 +00:00