0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-13 22:41:32 -05:00
Commit graph

97 commits

Author SHA1 Message Date
Jason Williams
1c07273f5a Update grunt-jscs dependency
No Issue
- grunt-jscs@1.2.0
- Clean up some instances of multiple spaces.
- Remove jscs:disable for regexes now that jscs better supports them.
2015-01-16 18:06:20 +00:00
Hannah Wolfe
e6305e83fa Merge pull request #4765 from martinnormark/master
Load next page if scrollHeight <= clientHeight
2015-01-12 14:17:51 +00:00
Jason Williams
66154145f1 Fixup validation engine to handle lack of proxying
Closes #4766
- Adjust ValidationEngine so it no longer assumes the properties
  it is validating are proxies via ObjectController.
- Fixup controllers, templates, and routes to use models where
  data needs to be validated.
2015-01-12 03:27:47 +00:00
Felix Rieseberg
d7bf4258fe Editor Save Button/Notifcations: Post vs Page
Closes #4768

- Notifications that used to read ‘View Post’ now read ‘View Page’ if
the post is actually a page
- The Editor Save Button now also makes a distinction between posts and
pages
2015-01-08 10:23:48 -08:00
Martin H. Normark
3faf4deca0 Load next page if scrollHeight <= clientHeight
closes #4764
- call loadNextPage in attachCheckScroll, if element scrollHeight <=
clientHeight
2015-01-07 00:16:16 +01:00
Robert Jackson
a1ed9adf92
Remove ObjectController proxying behavior.
Ember.ObjectController (and Ember.ArrayController) will be deprecated in
Ember 1.11 (and removed from core in Ember 2.0). The reasoning is
detailed in the Ember 2.0 RFC.

This PR does the following:

* Updates templates/controllers/views to explicitly reference model
  properties (instead of relying on proxying behavior).
* Clearly delineate where certain properties are being set or retrieved
  from (for example it was not clear exactly where `scratch` and
  `titleScratch` were stored).
* Remove usage of `Ember.ObjectController`.
* Add JSCS rule to prevent future PR's from adding regressions.
2015-01-01 21:51:20 -05:00
Jason Williams
7176097e9d Finish tag post count UI. Misc tag related fixes
Issue #4683
- Finish setting up pagination in tag management page.
- Add post count warning to delete tag modal.  Fix styling.
- Make sure tag input menu is loading all tags.
- Only include saved tags in tag input suggestion list.
- Unload tag records from store when entering tag route so that
  we get accurate post count.
- Add a resetPagination action to pagination-controller-mixin for
  cases where we want to start fresh.
- Include tag.id when sending tag payload to API.
2014-12-22 02:17:18 +00:00
Hannah Wolfe
c5f165d5b7 Merge pull request #4643 from novaugust/settings-menu-mixin
Create settings-menu-mixin for subview state tracking
2014-12-18 16:34:39 +00:00
Hannah Wolfe
a0db21d3ec Merge pull request #4629 from cobbspur/postpreview
Add view post link on published and updated posts
2014-12-15 13:28:47 +00:00
cobbspur
53d12a9659 Add view post link on published and updated posts
closes #1756

- adds a post url link to 'post updated' and 'post published' in editor
- adds join function in ghost paths
- adds a '/' detection to makeRoute method
- adds test for join function
2014-12-15 12:18:47 +00:00
Matt Enlow
29328bd4c9 Create settings-menu-mixin for subview state tracking
Ref #4642
- Move duplicate code from PSM and SettingsTags to a mixin
2014-12-13 20:37:36 -07:00
Ihab Khattab
0f37f3d4e5 Autosave for whitespace-only titles
closes #4625
- trim white space form `titleScratch` to enable autosave for
whitespace-only titles
2014-12-12 16:44:24 +02:00
Paul Adam Davis
ce395998ff Add Tag Meta View
Closes #4509, Closes #4615

- Adds meta title & meta description input fields
- Autosaves meta data
- Shows SEO preview (falling back to tag name & description if meta not supplied)
- Adds `type="button"` to delete button (which closes 4651)
2014-12-10 18:12:30 +00:00
Nazar Gargol
7e16ef328d Adds ctrl/cmd+s shortcut to whole application with a noop default
closes #4516
- shortcut for ctrl/cmd+s on application level
- shortens a syntax for any route that is using 'save' method, shortcuts object doesn't have to be defined at all, only the save action.
2014-12-08 19:08:40 +01:00
Jason Williams
0a7d161822 Prevent silent failures and recover after error.
Refs #4543
- Alway return model out of save handler so sub-classes which
  call this._super() on save have a model on success and failure.
- Always return resolved promise out of post slug generator.
- Test the errors object in the error notification helper to avoid
  throwing an unhandled exception and silently failing.
- Consider a post model "dirty" if it is in an error state.
2014-11-30 20:38:24 +00:00
Matt Enlow
bd0f5e0c5b Tags management api hookup
Ref #4248
- Added tags settings menu
- Added basic new, edit, delete, and save actions
- Show actionable edit buttons dynamically based on tag state
- Infinite scroll
- Closing the tag settings menu rollbacks your changes
- Removed not-yet-implementable code
2014-11-21 16:24:28 -07:00
Matt Enlow
a9ce31ffe7 Fix high latency autosave bug in editor.new
Closes #4400
- Added focusCursorAtEnd property to codemirror component, to set the cursor at document end on load. Used for posts that have been edited
- centralized codemirror init code in component
2014-11-16 08:53:02 -07:00
Matt Enlow
b5af691a61 Save meta title and meta desc on post save
Closes #4369
- Renamed `editor-route-base` -> `editor-base-route` to bring it in alignment with the view and controller mixins
- Consolidated editor route code into editor-base-route
- Removed `serialize` from EditorEditRoute, as it reimplemented the ember default
2014-11-03 21:11:04 -07:00
David Robson
8bcfd16f19 Editor must be focused before allowing certain keyboard shortcuts.
closes #4253
- checked for the CodeMirror-focused class on the CodeMirror div
- used length to determine whether CodeMirror-focused has been added
- determines whether the editor has been focused on
2014-11-02 09:50:42 +00:00
Hannah Wolfe
644f922510 Merge pull request #4324 from jaswilli/timed-save
Auto-save post at 60 second intervals
2014-10-27 17:38:54 +02:00
Jason Williams
0f17378b26 Enable JSCS checking on client.
Refs #4001
- grunt-jscs@0.8.1 which provides ES6 support.
2014-10-25 16:13:04 +00:00
Jason Williams
9aa13330ba Fix up PR #3491, remove lodash from admin
Refs #3491
2014-10-23 19:44:53 +00:00
Robert Jackson
a3456b7e1c Remove lodash from admin client.
* Adds `bind`, `isFinite`, and `isNumber` utility functions from lodash.
* Use new util funtions instead of lodash throughout the codebase.
* Remove lodash from vendor builds.
2014-10-23 18:27:09 +00:00
Jason Williams
5de2cb4471 Auto-save post at 60 second intervals
Refs #4259
- Auto-save the post at least once in any 60 second interval where
  there have been changes.
2014-10-22 15:26:27 +00:00
Jason Williams
2369080572 Ensure slug generation has completed prior to save
Refs #4307 Refs #4259
- Make sure that a slug has been generated prior to the first
  save that occurs on a post.
- Wait on in-flight slug generation requests before saving.
2014-10-20 19:15:01 +00:00
Jason Williams
58fda8a9a4 Cancel pending auto-save if manual save occurs
Closes #4309
2014-10-20 18:40:45 +00:00
Hannah Wolfe
fbccc36f77 More autosave improvements
issue #4305, issue #4259, issue #1413

- change new->edit transitionToRoute to be replaceRoute
- auto focus in the editor on transition to the edit route
- change the one-time autosave to happen on codemirror focusin instead of title focusout
- re-add removed tests, and reorder broken test
2014-10-18 17:27:05 +02:00
Jason Williams
b05da0f1e4 Auto-save changes
Refs #4259
- Auto-save new post when title loses focus.
- If a post has '(Untitled)' for a title, regenerate slugs
  on all title changes--same behavior as a new post that does
  not yet have a slug.
- Adjust some functional tests to handle the automatic transition
  from editor/new to editor/editor and the URL changes that go
  along with it.
2014-10-17 22:52:43 +00:00
John O'Nolan
8da76215ed Merge pull request #4303 from ErisDS/pr-4259
Autosave additions
2014-10-17 23:59:19 +02:00
Hannah Wolfe
af4e1809e8 Autosave additions
issue #4259, issue #1413

- decrease timeout by 1 sec
- really actually turn off nprogress
2014-10-17 18:39:39 +02:00
Hannah Wolfe
6e3fa3a2cf Merge pull request #4259 from novaugust/auto-save
Auto save draft posts
2014-10-17 19:04:07 +03:00
Paul Adam Davis
13f8cc61eb Remove console.error from shortcuts-route mixing
No issue

Safari (iOS 8 & OS X Yosemite) throws a massive hissy fit about `console.error` and goes on to break all the things.
This PR simply removes it.
2014-10-17 13:41:36 +01:00
Matt Enlow
4354458b11 Use DS.Model#eachAttribute in editor-base-controller
Closes #4279
2014-10-14 12:29:02 -06:00
Matt Enlow
a9fb2af7ea Autosave Draft posts
Ref #1413
- If the user stops typing for 5 seconds, a "typingPause" action is sent from the GhCodemirrorComponent
- Editor-base-controller ties the "typingPause" action to its "autosave"
- If a post is being saved and does not have a title, the title is set to "(Untitled)"
- Cleanup editor base controller property dependencies and code
2014-10-13 15:28:27 -06:00
surgesoft
b5a29cdca5 Change keyboard shortcut context
closes #4247
- added scope to every shortcut, the scope of shortcut is default to
  'default'
- add shortcut `enter` to modal which confirm the modal
- shortcut `enter` and `esc` now have scope 'modal'
- when lunch a modal, scope is switching to 'modal', and set back to
  'default' when close
- shortcut `enter` now confirm the dialog without conflicting with route
  shortcuts
2014-10-11 02:09:12 +08:00
Paul Adam Davis
e5b45c8d76 Rename popovers to dropdowns 2014-09-30 10:48:21 +01:00
Paul Adam Davis
bf69c9cf83 Fix flickering popover transitions
Closes #4138

- Removed JS animation to close in favour of CSS animations
2014-09-30 10:48:21 +01:00
Fabian Becker
30f56280e0 Meta data screen
closes #3939
- Add Seo Tab component to PSM
- Add new gh-blur-textarea component
- Refactor blur-input to use new text-input mixin
2014-09-21 15:13:06 +00:00
Matt Enlow
f29231aa70 Add Tab components
Closes #3937
- Add ghost tab components
- Remove extra container div from Application view
- Move right-outlet viewing logic to application level
- Prepare PSM.hbs for tabbing
2014-09-18 18:15:43 -06:00
Matt Enlow
986d3c1696 Fix editor scroll depending on cursor location
Closes #4027
2014-09-14 17:38:32 -06:00
Hannah Wolfe
f2eb90f606 Merge pull request #3999 from novaugust/emberify-posts-c-and-v
Emberify Posts mobile transitions
2014-09-12 11:19:34 +01:00
Matt Enlow
6f929eee4a Emberify Posts mobile transitions
Closes #3950

- Fixed up event attachment and removal in a few mixins
- Renamed content-list-content-view to something more understandable
- simplify transition from posts.index to posts.post
2014-09-10 20:58:10 -06:00
Fabian Becker
961ab5f064 Post Settings Menu - Step 1
closes #3936
- Implement new PSM
- Hook up close action
- Automatically close when view is destroyed
- Close on click and when pressing ESC
2014-09-10 17:31:19 +02:00
Jason Williams
1d6b1f9667 Prevent editor title from being overwritten
Closes #3955
- Change titleScratch from being bound to the title to being
  set when entering the editor so it is not overwritten on a
  model refresh.
- Ensure that the "unsaved content" dialog is shown when there are
  changes to the "scratch" fields after a post-settings-menu change.
- Add tests to prevent regression.
2014-09-04 19:27:59 +00:00
Matt Enlow
03bea5dbef js- prefix; fix content preview back button
Closes #1990, Ref #3810
- Add `js-` prefix to jQuery calls throughout code and templates
- move MarkdownComponent classNames to template
- Fix back button on posts content preview
- Remove dead code for preview tabbing jQuery
2014-09-02 22:29:32 -06:00
Jake Wright
349fd649f8 Fix markdown/preview tab for mobile
Fixes #3813

- Add togglePreview action to controller
- Implement action and bind attributes
- Remove the now pointless
- Update to comply with issue suggestions
2014-08-21 17:13:30 +01:00
Matt Enlow
20f40e7e32 Change Ember function.property() to Ember.computed
Closes #3417
2014-08-19 10:01:17 -06:00
Jason Williams
24a97db1be Revert post status on failed save.
Refs #3667, Refs #3776
- If saving a post fails, revert its status back to the
  pre-save value.
- Added tests to check post status after failed save attempt
  on both new and existing posts.
2014-08-15 00:22:10 +00:00
Robert Jackson
1d360b3d18
Do not focus post title when editing. 2014-08-08 11:37:24 -04:00
Hannah Wolfe
f7664194ca Merge pull request #3628 from novaugust/popover-btn-binding#3603
Add open class to popover buttons
2014-08-07 19:27:46 +01:00