Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity
38612 commits 234 branches 1697 tags 546 MiB
Commit graph

670 commits

Author SHA1 Message Date
Ronald Langeveld
b4fc45008a
Added hasLoaded state in Portal Frame (#19524) 
no issue

- added an additional state that keeps track on whether the iFrame
content has loaded, before checking whether Portal has loaded.
 2024-01-18 16:42:52 +00:00
Djordje Vlaisavljevic
501b1a2640
Updated design for sender and reply-to email address flow PROD-215 PROD-216 
refs PROD-215 PROD-216

- Added toast notifications for successful sender and reply-to email
address change behind the flag, instead of the modal
- Updated email template for verifying new sender or reply-to email
 2024-01-18 15:21:48 +00:00
Ronald Langeveld
3e67544331
Removed onLoad from iFrame element (#19522) 
no issue

- removed the onLoad function from the iFrame element and only rely on
the listener waiting for 'portal-ready' before showing Portal
 2024-01-18 15:09:52 +00:00
Daniel Lockyer
57c5f92770 Reverted "🎨 Added Offers to the new Settings (#19493)" 
This reverts commit c7d7b883cc.
 2024-01-18 15:04:59 +01:00
Sag
0f17f9a937
Updated design of the reply-to field for custom sending domains (#19515) 
fixes PROD-205
fixes PROD-219

- removed the right placeholder complexity
- the preview renders the current sender / reply-to address in
real-time, regardless of whether it's valid
- if the reply-to address does not match the custom sending domain, show
an inline error
 2024-01-18 14:39:43 +01:00
Ronald Langeveld
c7d7b883cc
🎨 Added Offers to the new Settings (#19493) 
no issue

- Removes flags for the new Offers in Admin X (Settings)
- Removes old Offers from the sidebar.
- See a new version of Offers in Settings. 🎨
 2024-01-18 12:56:08 +00:00
Ronald Langeveld
14bf2df834
Made offers iframe init load async (#19516) 
no issue

- ensures it waits for event data to load before rendering the iframe
which sometimes causes an undesired flashing experience.
 2024-01-18 12:38:41 +00:00
Ronald Langeveld
66238c7ccf
Added default string to href to Offers Portal iFrame (#19514) 
no issue

- potentially fixes a small performance issues to avoid the homepage of
your publication from being loaded should an href from Portal not exist
when loading Offers, that could cause flashing.
 2024-01-18 09:42:46 +00:00
Sodbileg Gansukh
8f4f013ed2
Design details on Offers cards and list (#19513) 2024-01-18 08:24:28 +00:00
Djordje Vlaisavljevic
4abcd17184 Added static design for banners 
refs PROD-215 PROD-322
 2024-01-17 21:09:24 +00:00
Sag
5ddd90a244
Updated Portal settings to render paid plans options only when relevant (#19507) 
fixes PROD-300
- hides "Prices available at signup" and "Price preselected at signup"
options in Portal settings, if no paid tier is active/visible
 2024-01-17 15:08:15 +00:00
Kevin Ansfield
100e7b70c6
✨ Added TK Reminders feature (#19491) 
no issue

- keep an eye on on https://ghost.org/changelog/ for full details
 2024-01-17 08:57:35 +00:00
Ronald Langeveld
3c4b981674
🐛 Fixed outside click exiting Code Injection modal (#19424) 
no issue

- fixed a bug causing the full screen code injection to close when
clicking out side of it, which could cause the loss of unsaved changes.
 2024-01-05 10:53:57 +00:00
Sodbileg Gansukh
3e98dd9edf
Simplified offers table UI (#19439) 
fixes PROD-283
 2024-01-04 10:45:44 +00:00
Sodbileg Gansukh
3611e99422
Close offer modal after archiving/reactivating (#19437) 
fixes PROD-284
 2024-01-04 02:17:53 +00:00
Sodbileg Gansukh
af1551bf8f
Moved learn more link to a separate line in Offers setting group (#19428) 
fixes PROD-281
 2024-01-03 06:57:32 +00:00
Princi Vershwal
62a5b7d61a
Removed onBlur error feedback in Recommendation edit modal (#19382) 
Fixes
[PROD-266](https://linear.app/tryghost/issue/PROD-266/remove-onblur-error-feedback-in-recommendation-edit-modal)
 2023-12-14 13:09:55 +00:00
Princi Vershwal
e0aca1c2fb
Removed onBlur error feedback in Custom Integration/Webhook modal (#19384) 
Fixes
[PROD-269](https://linear.app/tryghost/issue/PROD-269/remove-onblur-error-feedback-in-custom-integration-webhook-modal)
 2023-12-14 12:46:37 +00:00
Princi Vershwal
82d9e3a978
Removed onBlur error feedback in Custom Integration edit modal (#19383) 
Fixes
[PROD-268](https://linear.app/tryghost/issue/PROD-268/remove-onblur-error-feedback-in-custom-integration-edit-modal)
 2023-12-14 12:30:07 +00:00
Princi Vershwal
8d3f3d60f7
Removed onBlur error feedback on Tier detail modal (#19381) 
Fixes
[PROD-265](https://linear.app/tryghost/issue/PROD-265/remove-onblur-error-feedback-on-tier-detail-modal)
 2023-12-14 11:53:35 +00:00
Princi Vershwal
bb42faf694
Removed onBlur error feedback in Newsletter General settings (#19379) 
Fixes PROD-267
 2023-12-14 11:44:05 +00:00
Ronald Langeveld
0dc4ac380c
Portal Iframe Improvements in Admin X (#19377) 
refs PROD-4

- removed unnecessary props passed into the PortalFrame component.
 2023-12-14 09:42:30 +02:00
Princi Vershwal
3fef668394
Validation fix: Corrected fields should revert back from error-state (#19376) 
Fixes PROD-278
 2023-12-14 07:03:20 +00:00
Princi Vershwal
7b0ec35a1f
Fixed validation error: Corrected fields should revert back from erro… (#19374) 
Fixes
[PROD-272](https://linear.app/tryghost/issue/PROD-272/corrected-fields-should-revert-back-from-error-state)
 2023-12-14 05:32:50 +00:00
Ronald Langeveld
275cdd4db9
Added performance adjustments to Portal iFrames (#19373) 
refs PROD-4
 2023-12-14 06:54:39 +02:00
Djordje Vlaisavljevic
69a8f71bd1 Switched checkbox to a hint showing status 
refs PROD-276
 2023-12-13 16:58:50 +00:00
Djordje Vlaisavljevic
b0ac1e9afd Hid price preselect dropdown when only monthly or yearly are shown 
refs PROD-275
 2023-12-13 16:58:50 +00:00
Djordje Vlaisavljevic
b97f91f408 Changed portal settings to show free tier name instead of "Free" 
refs PROD-255
 2023-12-13 16:58:50 +00:00
Sodbileg Gansukh
f00b342e83
Fixed number formatting of offer redemptions count (#19365) 
fixes PROD-274

- corrected plural form of the label
- added number formatting
 2023-12-13 15:38:53 +00:00
Sodbileg Gansukh
6462f8f2ab
Fixed minor design issues in offers (#19363) 
fixes PROD-271, PROD-273
 2023-12-13 15:26:28 +00:00
Peter Zimon
58d9b8e382
Update migration in settings (#19278) 
refs.
7b40393d77

We're improving the usability and possibilities for publishers to
migrate from other platforms such as Substack, Medium or Mailchimp. This
PR applies changes to Ghost Settings to support the new flows, more
specifically:

- moves import and export functions out of Labs to its own setting,
directly available from search and the menu
- adds direct access to various platform migrations
- moves "Delete all content" to a dedicated setting group at the bottom
of all setting

---------

Co-authored-by: Jono Mingard <reason.koan@gmail.com>
 2023-12-13 16:25:29 +01:00
Ronald Langeveld
f23767fe12
Fixed offers asc/desc sorting not updating in component (#19361) 
refs
https://linear.app/tryghost/issue/PROD-8/when-i-sort-by-name-→-click-into-an-offer-→-go-back-to-the-list-it
 2023-12-13 13:46:11 +00:00
Princi Vershwal
f29d7975a8
Removed validation onBlur (#19358) 
Fixes
[PROD-209](https://linear.app/tryghost/issue/PROD-209/when-an-input-is-focused-and-a-modal-is-closed-error-messages-are)
 2023-12-13 11:07:15 +00:00
Ronald Langeveld
286194d61a
Added global state to avoid losing sorting state in Offers (#19355) 
refs
https://linear.app/tryghost/issue/PROD-8/when-i-sort-by-name-→-click-into-an-offer-→-go-back-to-the-list-it


- we now handle the state via a global state to ensure we aren't resetting the sorting options after each rerender.
 2023-12-13 12:25:06 +02:00
Sodbileg Gansukh
be47817ca0
Dark mode improvements for offers success screen (#19356) 2023-12-13 10:20:47 +00:00
Sodbileg Gansukh
3713273560
Dark mode improvements for offers (#19352) 
fixes PROD-262, PROD-261
 2023-12-13 07:40:40 +00:00
Princi Vershwal
830967d2ed
Edit cancle button fix (#19350) 
Fixes:
[PROD-213](https://linear.app/tryghost/issue/PROD-213/cancelling-should-act-two-ways-when-the-modal-is-opened-from-the-list)
 2023-12-13 07:16:26 +00:00
Sodbileg Gansukh
b7648e7bc2
Added design improvements to the Portal preview in offers (#19349) 
fixes PROD-251, PROD-252, PROD-254
 2023-12-13 06:17:12 +00:00
Princi Vershwal
7d530406f6
Add offer cancel button fix (#19348) 
Ref
[PROD-213](https://linear.app/tryghost/issue/PROD-213/cancelling-should-act-two-ways-when-the-modal-is-opened-from-the-list)
 2023-12-13 05:48:48 +00:00
Sodbileg Gansukh
03fd494e84
Hide copy link feature when there's no offer code (#19335) 
fixes PROD-253
 2023-12-12 15:57:55 +00:00
Sodbileg Gansukh
0a5c61acb2
Removed linking when there's no redemptions (#19332) 
fixes PROD-250
 2023-12-12 15:37:50 +00:00
Djordje Vlaisavljevic
5c19249473
Added yearly discount indicator to monthly/yearly toggle PROD-60 PROD-222 PROD 223 (#19276) 
refs PROD-60, PROD-222, PROD-223, PROD-89, PROD-94

- Indicator shows up in the monthly/yearly toggle if there are any paid
tiers with yearly discount, and shows the highest discount in order to
nudge visitors towards checking out yearly plan
- A couple of smaller portal improvements: typos, spacing, alignment

---------

Co-authored-by: Simon Backx <simon@ghost.org>
 2023-12-12 09:32:56 +00:00
Princi Vershwal
c1c3775748
Revert "Add offer cancle button fix" (#19324) 
Reverts TryGhost/Ghost#19297
 2023-12-12 07:27:17 +00:00
Sodbileg Gansukh
c932e9d60e
Updated copy of the add offer link in the settings group (#19323) 2023-12-12 12:28:53 +07:00
Sodbileg Gansukh
742a743a6b
Removed extra div when there's no offers to show in the settings group (#19322) 2023-12-12 05:03:43 +00:00
Daniël van der Winden
8c5c773398
Fixed white icon bg's in tier list in dark mode (#19310) 
Closes issue https://github.com/TryGhost/Ghost/issues/18872

Solves the problem of the bg-white class showing a white background
behind the checkmark icons in the tier list.
 2023-12-11 17:13:46 +01:00
Jono M
9ff482f985
Updated AdminX routing to work with and without a leading slash (#19312) 
no issue
 2023-12-11 14:43:06 +00:00
Ronald Langeveld
4c09a96a3c
Changed request type to fetching iframe content in previews (#19307) 
refs PROD-227

- Swapped out the request type from `POST` to `GET`.
 2023-12-11 14:28:35 +00:00
Jono M
8ab693d74d
Fixed wrong credentials usage in AdminX previews (#19281) 
refs PROD-227
 2023-12-11 14:01:53 +00:00
Princi Vershwal
5cb3ec6e0b
Add offer cancle button fix (#19297) 
Fixes PROD-213
 2023-12-11 04:40:35 +00:00