0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Commit graph

995 commits

Author SHA1 Message Date
Sag
2cc1e28eca
Cleaned up newEmailAddresses feature flag (#22001)
ref https://linear.app/ghost/issue/ENG-1416

- "New email addresses" feature was released in [Ghost
v5.78.0](https://github.com/TryGhost/Ghost/releases/tag/v5.78.0)
(commit:
7d0be3f1a9)
- In the context of DMARC changes from February 2024, we've allowed
self-hosters to change their sender and reply-to email addresses without
verification (cf. [Investigation For
Self-hosters](https://www.notion.so/ghost/Investigation-on-FROM-addresses-3f07d724e6044179b38e2793e1d9e797)
and [DMARC Product
Changes](https://www.notion.so/ghost/Working-Document-DMARC-Product-Changes-4cf1e435d8f2452f83cd92dddeaf9d67?pvs=4))
2025-01-15 10:56:47 +07:00
Peter Zimon
6ca066c8c3
Refined hover area for closed sidebar in Admin (#22004)
ref
https://linear.app/ghost/issue/DES-797/admin-visual-design-improvements

- When the sidebar is closed in Admin, the hover area to re-open it is
too narrow. This PR updates the width of this area so it's easier to
target.
2025-01-14 14:10:44 +01:00
Peter Zimon
9f13ad0716
🎨 Admin visual design updates (#21987)
ref DES-797

A lot of visual details of the Admin is outdated and inconsistent with
newer UI components such as settings. This PR improves several of these
inconsistencies and refreshes the visual design of the Admin outside
settings. In details the following components have been updated:

- Input fields and dropdowns use grey background color in Post settings
menu when not in-focus
- Got rid of the grey background for sections in Member details and Tag
details
- Updated typography details esp. as font-weights and sizes
- Updated modal corners, shadows
- Added a way to close the main navigation
- Updated main navigation styles
- Added flat background color for list items on hover
- Updated subscription cards in Member details
- Further smaller visual design changes
2025-01-13 17:23:43 +01:00
Daniël van der Winden
83d7691fe9
Fixed dark mode separator in Analytics settings (#21996)
The separator in Analytics settings wasn't showing in the right colour
in dark mode. This change fixes that.

Fixes
https://linear.app/ghost/issue/DES-1077/analytics-separators-have-wrong-colour-in-dark-mode
2025-01-13 14:47:38 +00:00
Daniël van der Winden
1c4d7b8cd7
Fixed dark mode separator in Access settings (#21995)
The separator in Access settings wasn't showing in the right colour in
dark mode. This change fixes that.

No issue.
2025-01-13 14:24:04 +00:00
Sam Lord
3cf1abfc49
Added a labs flag for Captcha
refs BAE-638
Currently unused, but adding this early to prevent future commits from
enabling the feature for all users
2025-01-09 15:43:03 +00:00
renovate[bot]
c7139a27c7
Added support for line breaks in more editor card fields (credit: @cathysarisky)
ref https://github.com/TryGhost/Ghost/issues/20027

- fixes quirky behaviour and adds full support for Shift+Enter line breaks across our various editor cards
2025-01-08 16:50:03 +00:00
Daniël van der Winden
171036e640
🎨 Made 5 settings quicker to edit at the top-level in Settings (#21976)
Based on our changes to the _Access_ and _Analytics_ cards in Settings,
we decided to update how we allow edits to a few other settings, too.

These changes allow the following settings to be manipulated at the
top-level in Settings, without having to click 'Edit' first.

- Timezone
- Default recipients for newsletters
- Publication language
- Social accounts
- Tips and donations

fixes
https://linear.app/ghost/issue/DES-1062/updates-to-editsave-method-of-settings-cards
2025-01-08 16:33:54 +00:00
Djordje Vlaisavljevic
30a60d903d Disable "Create" button after first click in "Create newsletter" modal
ref https://linear.app/ghost/issue/DES-505/double-click-on-newsletter-create-button-closes-the-modal

- It was possible to click this button again after the first click, which would close the modal and then open the "Edit newsletter" modal, which is confusing for the user. The button is now both disabled and in the loading state after the first click.
2025-01-07 16:56:13 +00:00
Djordje Vlaisavljevic
1d59399b41
Improved history modal (#21970)
ref https://linear.app/ghost/issue/DES-408/staff-filter-cut-off-in-history-in-rare-case, https://linear.app/ghost/issue/DES-313/adminx-history-doesnt-show-loader-when-actions-are-being-fetched, https://linear.app/ghost/issue/DES-314/adminx-history-pagination-is-cut-off

- Added missing loading states: bigger one for initial fetch, smaller one when loading the next page
- Added missing empty states: one for when there’s no history entries at all, another for when no entries match the currently applied filters
- Fixed last entry having the bottom part cut off
- Fixed type icon showing underneath the avatar
- Made “Filter” button larger to match the select field
2025-01-07 12:12:58 +00:00
Daniel Lockyer
1b26f06c48 Removed Admin UI for enabling URL cache
ref https://linear.app/ghost/issue/ENG-1803/remove-url-cache-code

- this was an experimental feature to persist the URL cache to disk so it can be read upon boot, which would save recalculating it and hopefully speed up boot times
- it was never fleshed out and the code is a bit of a hack, so it's not really worth keeping it around
- it's not trivial to delete the backend code because it's hooked into
  the E2E tests and they fail if you remove the flag (strange), so I'm
  just removing the UI so no-one can enable it
- I'll remove the backend code in a future commit
2025-01-07 11:11:42 +01:00
Sag
e67e2411f2
Added option to disable free signups (#21862)
ref https://linear.app/ghost/issue/ENG-1235

- problem: today, when a publisher removes the "free" tier from the
Portal settings, it doesn't disable free signups entirely. It removes
the free tier from the Portal UI, but free signup is still possible via
other avenues (signup form in themes, embeddable signup form on another
site, direct API call). This creates confusion/frustration for
publishers who thought they disabled free signups, but are still getting
unwanted free signups (spam). There is no way to disable free signups
entirely.

- solution: introduced a new "paid-members only" subscription access
setting, which blocks all free signups at the API level. If chosen, the
free tier is hidden in Portal and all free signup are blocked at the API
level with a readable error message (`This site only accepts paid
members.`)

![CleanShot 2024-12-10 at 09 09
28@2x](https://github.com/user-attachments/assets/c71b38b4-0d23-429c-a743-00772e82c787)
2024-12-20 02:43:48 +08:00
Kevin Ansfield
9602c93448 Revert "Removed i18n toggle from labs UI (#21927)"
This reverts commit fab5544217.
2024-12-19 18:09:30 +00:00
Hannah Wolfe
fab5544217
Removed i18n toggle from labs UI (#21927)
ref bb9a69e
ref https://linear.app/ghost/issue/ENG-1753/labs-flags-cleanup

- We promoted i18n to GA several weeks ago now, and it's going fine
- Removing the UI first to reduce confusion before cleaning up all the other references to the flag
- Also changed the i18n test to set the language back at the end of the test, to ensure no conflicts
2024-12-19 15:52:10 +00:00
Kevin Ansfield
4a3626696e Removed commentImprovements labs flag
closes https://linear.app/ghost/issue/PLG-300

- we're not planning on making any more comments improvements behind this flag so it can be removed
- all conditionals using it have been cleaned up previously when feature went GA
2024-12-19 15:30:42 +00:00
Peter Zimon
252918b70c
Adding Posts analytics React app (#21878)
ref https://linear.app/ghost/issue/DES-1021/create-posts-app

Part of establishing React patterns in Ghost is to build a well-defined
and fairly self-encapsulated app through which we can test assumptions
and define best practices. Our guinea pig is Post analytics for this
purpose. This PR creates a new React app (posts) using Shade (the new
design system).
2024-12-19 12:01:08 +01:00
Daniël van der Winden
ab2c7f18e2
🎨 Improved Access card layout in Settings (#21920)
As part of our efforts to add more personality to Settings, we've
identified areas where we can improve the UX.

This change makes it easier to manipulate Access settings by removing a
step from the flow.

fixes
https://linear.app/ghost/issue/DES-484/improve-access-card-layout-in-settings

**Before**
<img width="1718" alt="access-card-before"
src="https://github.com/user-attachments/assets/8c0f8f14-31b9-4712-93d2-97eb0f05c965"
/>

**After**
<img width="1718" alt="access-card-after"
src="https://github.com/user-attachments/assets/5831a7cc-fbad-4d4b-bccc-6e86be6a8c65"
/>
2024-12-19 11:15:46 +01:00
Hannah Wolfe
d2b7872a08
Revert "Removed i18n toggle from labs UI (#21916)"
This reverts commit d8820230fc.
2024-12-19 09:26:27 +00:00
Hannah Wolfe
d8820230fc
Removed i18n toggle from labs UI (#21916)
ref
bb9a69edfe

- We promoted i18n to GA several weeks ago now, and it's going fine
- Removing the UI first to reduce confusion
- This is before clearning up all the other references to the flag
2024-12-19 06:34:04 +00:00
Kevin Ansfield
21e7a8e4b6
Revert "🎨 Improved Access card layout in Settings (#21913)"
no issue

This reverts commit 040b290fbd.

- the commit has broken browser tests, reverting to get back in a green state
- will be re-introduced in a follow-up PR
2024-12-18 20:34:43 +00:00
Daniël van der Winden
040b290fbd
🎨 Improved Access card layout in Settings (#21913)
As part of our efforts to add more personality to Settings, we've
identified areas where we can improve the UX.

This change makes it easier to manipulate Access settings by removing a
step from the flow.

fixes
https://linear.app/ghost/issue/DES-484/improve-access-card-layout-in-settings

**Before**
<img width="1718" alt="access-card-before"
src="https://github.com/user-attachments/assets/8c0f8f14-31b9-4712-93d2-97eb0f05c965"
/>

**After**
<img width="1718" alt="access-card-after"
src="https://github.com/user-attachments/assets/5831a7cc-fbad-4d4b-bccc-6e86be6a8c65"
/>
2024-12-18 14:29:07 +00:00
Daniël van der Winden
ea4e73e558
Added a header image to Integrations settings (#21902)
As part of adding more personality to our Settings, this change adds a
header image to the Integrations settings.

fixes
https://linear.app/ghost/issue/DES-481/add-image-to-integrations-card-in-settings
2024-12-18 11:47:45 +01:00
Sodbileg Gansukh
c2bd0d9d07
Fixed theme management menu alignment (#21896)
ref DES-933

- when three dot buttons are clicked in the theme management modal, the
menu alignment was wrong
- this fixes the issue by aligning the button and the menu by the right
edge
2024-12-17 03:14:11 +00:00
Sodbileg Gansukh
b6f94c5fdb
Cleaned up the customFonts feature flag (#21889)
ref DES-1025
2024-12-16 18:13:15 +08:00
Sanne de Vries
8e5730680e
Improved discoverability of email design settings (#21869)
No ref
- Added "design" and "customization" to the keywords for the newsletters
settings
- Added a description to the newsletters settings
2024-12-11 13:35:32 +00:00
Steve Larson
428eebeaf8
Added custom font support for themes (#21817)
ref [DES-949](https://linear.app/tryghost/issue/DES-949/

177e604501

This adds custom fonts feature allowing users to select heading and body
fonts for their themes from a curated list. This allows publishers to
have more control over their brand, and allows themes to have a wider
range of styles to appeal to different audiences.

Without custom fonts support, themes will continue to work as normal,
but users won't be able to customize their typography. As for the
official themes, all of them will support custom fonts.
2024-12-05 16:39:41 +00:00
Daniel Lockyer
4c13f188ce Removed Collections code from Admin
ref https://linear.app/ghost/issue/ENG-1805/remove-collections-code

- we're removing this feature as it's not finished to the degree we
  would like, so this commit removes all references to it from Admin in
  order to keep things clean
2024-12-04 17:36:40 +01:00
Sodbileg Gansukh
ea0e598bf2
Added custom fonts feature check (#21738)
ref DES-1011

- previously, we were hiding the old font settings from the official themes without checking if they support the custom fonts or not
- now we use the gscan warning info to check this — only when there's support, we hide the settings which means users with the older version will get the old settings back
- also added two new tests for this procedure
2024-12-04 13:42:44 +08:00
Hannah Wolfe
675b29a418
🔥 Removed UI for AMP (#21762)
closes
https://linear.app/ghost/issue/ENG-1807/further-deprecate-amp-by-removing-the-ui

- AMP has been deprecated for a year, and will be removed in Ghost 6.0
- As the next step towards removing it, we're removing the UI, meaning
new sites can't enable it
- This will hopefully help the transition to dropping it be smoother and
especially prevent newer users from spending a lot of time on AMP in the
run up to it going away
- NOTE: this only removes the UI. All the logic remains, you can still enable AMP via the API/settings table in the DB.
2024-12-02 12:12:52 +00:00
Daniel Lockyer
f6d774ee93 Removed Lexical multiplayer experiment
fix https://linear.app/ghost/issue/ENG-1804/remove-lexicalmultiplayer-code

- this experiment never went anywhere and we'll probably change our plan
  in the future, so this commit cleans up all the relevant code in this
  repo for the feature, in order to cut down on the code we have
2024-11-28 16:00:10 +01:00
Princi Vershwal
6a70ba8895
Moved staff2fa flag to BETA_FEATURES (#21749)
Closes https://linear.app/ghost/issue/ENG-1800/move-staff2fa-to-beta-features-and-disable-developer-experiments

Currently we have this flag in ALPHA_FEATURES. We want to enable 2fa for selected sites but we would want to disable developer experiments for them, so they don't see the UI and enable random things.
2024-11-28 12:13:59 +00:00
Ronald Langeveld
72125f352b
Removed blocking tests (#21747)
ref https://ghost.slack.com/archives/C02G9E68C/p1732783603483239

- Need to create a patch release, however this test is suddenly failing.
- Fails at  const fileChooserPromise = page.waitForEvent('filechooser');
- reason is not clear, however, cannot reproduce.
2024-11-28 09:16:34 +00:00
Steve Larson
c046bbda91
🐛 Fixed Istanbul timezone (#21686)
ref https://linear.app/ghost/issue/ENG-1781/
- updated Istanbul TZ to +03

Thanks to @muratcorlu for the PR to TryGhost/SDK.
2024-11-21 17:23:21 +00:00
Sodbileg Gansukh
9493fbefcc
Moved the custom fonts feature to public beta (#21664)
ref DES-985
2024-11-21 19:06:40 +08:00
Sodbileg Gansukh
1f501c1e58
Added author name as an additional check for official themes (#21665)
ref DES-982

- we're hiding font-related theme settings from official themes to make room for the new custom font settings
- this adds author name as an additional check on top of the existing ones (theme name and corresponding setting keys)
2024-11-21 12:04:24 +08:00
Steve Larson
2447f37a14
Reverted custom fonts flag (#21645)
ref https://ghost.slack.com/archives/C025584CA/p1731950126867179

- moved custom fonts functionality back to a labs flag
- reverted gscan version to 4.45 which doesn't include the custom fonts
checks/warnings
2024-11-18 17:45:03 +00:00
Ronald Langeveld
e254ddbd17
🐛 Fixed marketplace theme installation route (#21616)
no issue

- Fixes a potential regression that caused the marketplace install route
not to route correctly.
2024-11-14 03:41:47 +00:00
John O'Nolan
e7a80d79f3
Updated link to Pintura integration 2024-11-12 08:52:17 -05:00
Sodbileg Gansukh
9ffc5ca79a
Fixed embeddable signup form preview and generated code (#21592)
ref ENG-1671
2024-11-12 14:33:52 +08:00
Princi Vershwal
7f158c0e18
🐛 Fixed Admin navigation settings, pressing ENTER will now create a new navigation item (#21591)
Ref
https://linear.app/ghost/issue/DES-73/enter-should-create-new-navigation-itemmove-to-next-field
2024-11-12 05:10:15 +00:00
Sodbileg Gansukh
177e604501
Added custom fonts (#21564)
ref DES-949

This adds custom fonts feature allowing users to select heading and body fonts for their themes from a curated list. This allows publishers to have more control over their brand, and allows themes to have a wider range of styles to appeal to different audiences. 

Without custom fonts support, themes will continue to work as normal, but users won't be able to customize their typography. As for the official themes, all of them will support custom fonts.

---------

Co-authored-by: Aileen Booker <AileenCGN@gmail.com>
2024-11-11 18:38:02 +08:00
Daniël van der Winden
eae76703eb
Custom Integrations and Webhooks layout fixes (#21565)
fixes
https://linear.app/ghost/issue/DES-790/some-urls-not-wrapping-in-integration-detail-modal

- Webhook URLs were breaking out of the modal container. They now wrap
across a few lines.
- Long descriptions of Custom Integrations caused the integration's icon
to scale down. That no longer happens.
- Descriptions of Custom Integrations wrap properly.
2024-11-07 14:24:15 +00:00
Daniël van der Winden
86ecedf079
Revert "Admin navigation settings fix (#21323)" (#21563)
This reverts commit eaed33972f.

The fix we shipped for using the `RETURN` key to create navigation items
in Admin broke something with regards to saving the URL, so we're
reverting that change.
2024-11-07 12:34:34 +01:00
Sodbileg Gansukh
9516d144a0
Used theme package name for hiding theme-specific font settings (#21545)
ref DES-929
2024-11-06 10:42:32 +00:00
Sodbileg Gansukh
e25d5cc105
Hide typography related theme settings from official themes (#21530)
ref DES-929
2024-11-06 12:26:20 +08:00
Daniël van der Winden
6e8e817a47
Makes newsletter comments toggle conditional (#21517)
fixes
https://linear.app/ghost/issue/DES-796/shouldnt-show-email-template-option-when-commenting-is-disabled

Previously, if you had comments turned off on your site, you would still
see the toggle in newsletter settings. Clicking it would do nothing.

Now, if comments are enabled (for all members, or paid members), it will
show; if they're not, it won't.



https://github.com/user-attachments/assets/80b8e2dc-a0ed-40bc-ada5-40141676e38b
2024-11-04 16:18:04 +01:00
Sodbileg Gansukh
c9f5b72b3c
Made visual updates to the custom fonts selector (#21510)
ref DES-930
2024-11-04 16:42:04 +08:00
renovate[bot]
4f4662490f
Update Koenig packages (#21480) 2024-10-31 10:11:27 +00:00
Sodbileg Gansukh
e01b952ed2
Made the tabs sticky in design and newsletter settings (#21477)
ref DES-927, DES-928
2024-10-31 13:30:25 +08:00
Daniël van der Winden
4a8da45895
Fixed searchbar's X button overlapping with Settings' X button (#21449)
fixes
https://linear.app/ghost/issue/DES-316/adminx-settings-search-overlaps-with-modal-close-x-when-in-mobile-view

Regression, solved by removing an overexcited media query.
2024-10-29 11:03:43 +00:00