From fe9b01910d8e5909fadbc36c94408243feb07b72 Mon Sep 17 00:00:00 2001 From: Chris Raible Date: Wed, 30 Oct 2024 12:39:41 -0700 Subject: [PATCH] Cleaned up browser test output in CI (#21462) no issue - The browser test output in CI is really noisy, because the `NX_DAEMON` doens't run in CI, but we're trying to use NX to watch and rebuild the typescript modules. This is outputting a ton of "NX Daemon is not running" type of errors, which make it difficult to sift through the actual test results. - We don't actually need to watch the typescript files, we just need to build them once before starting. This is defined as an NX dependency for the browser tests target, so we don't need to explicitly build the TS packages at all. Removing the typescript watch & build command removes the noisy errors, without impacting how the tests actually run. --- .github/scripts/dev.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/dev.js b/.github/scripts/dev.js index 10c42f0abe..a6a7b96f49 100644 --- a/.github/scripts/dev.js +++ b/.github/scripts/dev.js @@ -95,7 +95,7 @@ if (DASH_DASH_ARGS.includes('ghost')) { } else if (DASH_DASH_ARGS.includes('admin')) { commands = [COMMAND_ADMIN, ...COMMANDS_ADMINX]; } else if (DASH_DASH_ARGS.includes('browser-tests')) { - commands = [COMMAND_BROWSERTESTS, COMMAND_TYPESCRIPT]; + commands = [COMMAND_BROWSERTESTS]; } else { commands = [COMMAND_GHOST, COMMAND_TYPESCRIPT, COMMAND_ADMIN, ...COMMANDS_ADMINX]; }