Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Fixed unnecessary requests with loading comment counts

Browse source 
refs https://github.com/TryGhost/Team/issues/2082

- if a site has comments enabled but doesn't use the `comments_count`
  helper, the comments-count.min.js will still be loaded and it'll send
  a POST request to Ghost with an empty array of post IDs to fetch
- this is unnecessary and we should avoid this extra request for pages
  that don't need to show comment counts
- this commit prevents the comment-counts JS from sending the request if
  there are no post IDs to fetch
This commit is contained in:
Daniel Lockyer 2022-10-17 10:24:21 +07:00 committed by Daniel Lockyer
parent 6b7088ba20
commit fd9401503b
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ghost/core/core/frontend/src/comment-counts/js/comment-counts.js
View file

@ -63,6 +63,10 @@
const ids = Array.from(fetchingIds); const ids = Array.from(fetchingIds);
fetchingIds.clear(); fetchingIds.clear();
if (!ids.length) {
return;
}
const rawRes = await fetch(api, { const rawRes = await fetch(api, {
method: 'POST', method: 'POST',
headers: { headers: {