Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-01 02:41:39 -05:00
Code Issues Activity

Fixed unsupported .cleanup() calls on react editor

Browse source 
no issue

- `react-editor` controller has much of the same code as the normal editor controller but not all of the editor-instance methods are supported in the react editor yet
- commented out the remaining `.cleanup()` calls that are intended to remove empty cards because the method does not exist and was throwing errors when leaving the react-editor route
This commit is contained in:
Kevin Ansfield 2022-07-27 14:14:05 +01:00
parent 7a9435d524
commit fd0398d5e2
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
ghost/admin/app/controllers/react-editor.js vendored
View file

@ -532,10 +532,11 @@ export default class ReactEditorController extends Controller {
*beforeSaveTask(options = {}) {
// ensure we remove any blank cards when performing a full save
if (!options.backgroundSave) {
if (this._koenig) {
this._koenig.cleanup();
this.set('hasDirtyAttributes', true);
}
// TODO: not yet implemented in react editor
// if (this._koenig) {
// this._koenig.cleanup();
// this.set('hasDirtyAttributes', true);
// }
}
// TODO: There's no need for (at least) most of these scratch values.
@ -821,9 +822,10 @@ export default class ReactEditorController extends Controller {
// - blank cards could be left around due to autosave triggering whilst
// a blank card is present then the user attempting to leave
// - will mark the post as dirty so it gets saved when transitioning
if (this._koenig && post.isDraft) {
this._koenig.cleanup();
}
// TODO: not yet implemented in react editor
// if (this._koenig && post.isDraft) {
// this._koenig.cleanup();
// }
let hasDirtyAttributes = this.hasDirtyAttributes;
let state = post.getProperties('isDeleted', 'isSaving', 'hasDirtyAttributes', 'isNew');