Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Fixed importer breaking any posts written in the new editor (#17230)

Browse source 
refs @TryGhost/Product#3551

- PostsImporter would convert the HTML from the import file into
Mobiledoc, even if the post was written in Lexical
- As a result, the imported posts would have both mobiledoc & lexical
fields populated, which prevents the post from being updated in the
Lexical editor
- Added a check to see if the post was written in Lexical, and if so,
skip the HTML > Mobiledoc conversion
This commit is contained in:
Chris Raible 2023-07-06 18:37:19 -07:00 • committed by GitHub
parent c6b8097ff9
commit fc7e150cc2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ghost/core/core/server/data/importer/importers/data/PostsImporter.js
View file

@ -237,7 +237,7 @@ class PostsImporter extends BaseImporter {
// CASE 1: you are importing old editor posts
// CASE 2: you are importing Koenig Beta posts
// CASE 3: you are importing Koenig 2.0 posts
if (model.mobiledoc) {
if (model.mobiledoc && !model.lexical) {
let mobiledoc;
try {
@ -272,7 +272,7 @@ class PostsImporter extends BaseImporter {
model.mobiledoc = JSON.stringify(mobiledoc);
model.html = mobiledocLib.mobiledocHtmlRenderer.render(JSON.parse(model.mobiledoc));
} else if (model.html) {
} else if (model.html && !model.lexical) {
model.mobiledoc = JSON.stringify(mobiledocLib.htmlToMobiledocConverter(model.html));
model.html = mobiledocLib.mobiledocHtmlRenderer.render(JSON.parse(model.mobiledoc));
}

16
ghost/core/test/unit/server/data/importer/importers/data/posts.test.js
View file

@ -120,5 +120,21 @@ describe('PostsImporter', function () {
// @TODO: need to check this mapping
//post.newsletter_id.should.eql();
});
it('Doesn\'t populate the mobiledoc column if it is a lexical post', function () {
const fakePosts = [{
slug: 'post-with-newsletter',
lexical: '{"root":{"children":[{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"Bananas!","type":"text","version":1}],"direction":"ltr","format":"","indent":0,"type":"paragraph","version":1}],"direction":"ltr","format":"","indent":0,"type":"root","version":1}}',
html: '<p>Bananas!</p>'
}];
const importer = new PostsImporter({posts: fakePosts});
importer.beforeImport();
const post = find(importer.dataToImport, {slug: 'post-with-newsletter'});
should.exist(post);
should.equal(post.mobiledoc, null);
});
});
});