From 71c6b3338557f7927387543f781605a4296e63fc Mon Sep 17 00:00:00 2001
From: Jilles Soeters <info@jilles.me>
Date: Wed, 5 Nov 2014 13:38:07 +0000
Subject: [PATCH] Remove hash after the url when clicking Meta Data

Removes that hash appended to the URL when clicking Meta Data in post settings.

Closes #4386

When clicking 'Meta Data' the click event appends a # to the URL. I replaced the a with a button element so that won't happen anymore. The button has a type attribute because it will try and submit the form without it. Added text-align: left to the navlist button because the button centers it's content by default.
---
 core/client/assets/sass/patterns/navlist.scss | 4 ++++
 core/client/templates/-navbar.hbs             | 2 +-
 core/client/templates/post-settings-menu.hbs  | 4 ++--
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/core/client/assets/sass/patterns/navlist.scss b/core/client/assets/sass/patterns/navlist.scss
index f4030cd221..0819b78392 100644
--- a/core/client/assets/sass/patterns/navlist.scss
+++ b/core/client/assets/sass/patterns/navlist.scss
@@ -43,6 +43,10 @@
         border-bottom: 1px solid #E0DFD7;
     }
 
+    button {
+        text-align: left;
+    }
+
     a {
         color: $darkgrey;
     }
diff --git a/core/client/templates/-navbar.hbs b/core/client/templates/-navbar.hbs
index e2fc3a90f8..89b04ef9ae 100644
--- a/core/client/templates/-navbar.hbs
+++ b/core/client/templates/-navbar.hbs
@@ -29,7 +29,7 @@
 
     }}
 
-    <div class="nav-item user-menu" data-href="#">
+    <div class="nav-item user-menu">
         {{#gh-dropdown-button dropdownName="user-menu" tagName="div" classNames="nav-label clearfix"}}
             {{#if session.user.image}}
             <div class="image"><img {{bind-attr src=session.user.image alt=userImageAlt}} /></div>
diff --git a/core/client/templates/post-settings-menu.hbs b/core/client/templates/post-settings-menu.hbs
index a8d8061f34..34cab541fa 100644
--- a/core/client/templates/post-settings-menu.hbs
+++ b/core/client/templates/post-settings-menu.hbs
@@ -42,10 +42,10 @@
 
             <ul class="nav-list nav-list-block">
                 {{#gh-tab tagName="li" classNames="nav-list-item"}}
-                    <a href="#">
+                    <button type="button">
                         <b>Meta Data</b>
                         <span>Extra content for SEO and social media.</span>
-                    </a>
+                    </button>
                 {{/gh-tab}}
             </ul>