From fab554421796c17c0ab2269f5052308f932ddbd8 Mon Sep 17 00:00:00 2001
From: Hannah Wolfe <github.erisds@gmail.com>
Date: Thu, 19 Dec 2024 15:52:10 +0000
Subject: [PATCH] Removed i18n toggle from labs UI (#21927)

ref bb9a69e
ref https://linear.app/ghost/issue/ENG-1753/labs-flags-cleanup

- We promoted i18n to GA several weeks ago now, and it's going fine
- Removing the UI first to reduce confusion before cleaning up all the other references to the flag
- Also changed the i18n test to set the language back at the end of the test, to ensure no conflicts
---
 .../settings/advanced/labs/BetaFeatures.tsx   |  4 ---
 .../core/test/e2e-browser/admin/i18n.spec.js  | 25 ++++++++++---------
 2 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/apps/admin-x-settings/src/components/settings/advanced/labs/BetaFeatures.tsx b/apps/admin-x-settings/src/components/settings/advanced/labs/BetaFeatures.tsx
index 97daa8bb2c..37ecb00ff4 100644
--- a/apps/admin-x-settings/src/components/settings/advanced/labs/BetaFeatures.tsx
+++ b/apps/admin-x-settings/src/components/settings/advanced/labs/BetaFeatures.tsx
@@ -23,10 +23,6 @@ const BetaFeatures: React.FC = () => {
                 action={<FeatureToggle flag="additionalPaymentMethods" />}
                 detail={<>Enable support for CashApp, iDEAL, Bancontact, and others. <a className='text-green' href="https://ghost.org/help/payment-methods" rel="noopener noreferrer" target="_blank">Learn more &rarr;</a></>}
                 title='Additional payment methods' />
-            <LabItem
-                action={<FeatureToggle flag='i18n' />}
-                detail={<>Translate your membership flows into your publication language (<a className='text-green' href="https://github.com/TryGhost/Ghost/tree/main/ghost/i18n/locales" rel="noopener noreferrer" target="_blank">supported languages</a>). Don’t see yours? <a className='text-green' href="https://forum.ghost.org/t/help-translate-ghost-beta/37461" rel="noopener noreferrer" target="_blank">Get involved</a></>}
-                title='Portal translation' />
             <LabItem
                 action={<div className='flex flex-col items-end gap-1'>
                     <FileUpload
diff --git a/ghost/core/test/e2e-browser/admin/i18n.spec.js b/ghost/core/test/e2e-browser/admin/i18n.spec.js
index d9d3411198..9f16ca380f 100644
--- a/ghost/core/test/e2e-browser/admin/i18n.spec.js
+++ b/ghost/core/test/e2e-browser/admin/i18n.spec.js
@@ -6,21 +6,19 @@ const {createPostDraft} = require('../utils');
  * @param {import('@playwright/test').Page} page
  */
 
+async function setLanguage(sharedPage, language) {
+    await sharedPage.goto('/ghost/#/settings/publication-language');
+    const section = sharedPage.getByTestId('publication-language');
+    await section.getByRole('button', {name: 'Edit'}).click();
+    const input = section.getByPlaceholder('Site language');
+    await input.fill(language);
+    await section.getByRole('button', {name: 'Save'}).click();
+}
+
 test.describe('i18n', () => {
     test.describe('Newsletter', () => {
         test('changing the site language immediately translates strings in newsletters', async ({sharedPage}) => {
-            await sharedPage.goto('/ghost/#/settings/publication-language');
-            const section = sharedPage.getByTestId('publication-language');
-            await section.getByRole('button', {name: 'Edit'}).click();
-            const input = section.getByPlaceholder('Site language');
-            await input.fill('fr');
-            await section.getByRole('button', {name: 'Save'}).click();
-
-            const labsSection = sharedPage.getByTestId('labs');
-            await labsSection.getByRole('button', {name: 'Open'}).click();
-            let portalLabel = labsSection.getByText('Portal translation');
-            let portalToggle = portalLabel.locator('..').locator('..').locator('..').getByRole('switch');
-            await portalToggle.click();
+            await setLanguage(sharedPage, 'fr');
 
             const postData = {
                 title: 'Publish and email post',
@@ -41,6 +39,9 @@ test.describe('i18n', () => {
             const metaText = await sharedPage.frameLocator('iframe.gh-pe-iframe').locator('td.post-meta').first().textContent();
             expect(metaText).toContain('Par Joe Bloggs');
             expect(metaText).not.toContain('By Joe Bloggs');
+
+            // Set the language back before the next test!
+            await setLanguage(sharedPage, 'en');
         });
     });
 });