Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

🐛 Fixed default email recipients always being "everyone" rather than matching post visibility (#16247)

Browse source 
refs https://github.com/TryGhost/Ghost/issues/16125

The previous fix for incorrect recipient details being shown when
re-sending a failed email introduced another bug that prevented the
"Match post visibility" default recipients setting from working.

- the server always sets `post.emailSegment` to `'all'` for new posts so
the publish flow recipient filter logic that checked for
`post.emailSegment` being present always defaulted to `'all'` rather
than falling back to the selected default recipients setting
- when a post has been published but the email failed it will have its
`newsletter` value set so we can use that as a check for using the
`post.emailSegment` value in place of the default recipients setting
This commit is contained in:
Kevin Ansfield 2023-02-08 11:41:48 +00:00 • committed by Daniel Lockyer
parent 93a10d8f4f
commit f7aefa2feb
No known key found for this signature in database
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/utils/publish-options.js
View file

@ -168,7 +168,7 @@ export default class PublishOptions {
}
get recipientFilter() {
return this.selectedRecipientFilter || this.post.emailSegment || this.defaultRecipientFilter;
return this.selectedRecipientFilter || (this.post.newsletter && this.post.emailSegment) || this.defaultRecipientFilter;
}
get defaultRecipientFilter() {