From f6c81033d7d6116fb7dc981eab92792dab09b2d4 Mon Sep 17 00:00:00 2001 From: Naz Date: Tue, 26 Oct 2021 16:01:10 +0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20500=20error=20when=20vis?= =?UTF-8?q?iting=20an=20email-only=20post=20link?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit refs https://github.com/TryGhost/Ghost/commit/74280cfbeae70d1a21bc1a75873302df528d5d05 - We allow to send email-only posts when using v4 Admin API, but it's possible to configure a v3 Theme with a site instance which resulta in an unsupported behavior throwing a 500. - With this fix a 404 will be returned when an email-only post is viewed through the public email-only post URL --- core/frontend/services/routing/router-manager.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/core/frontend/services/routing/router-manager.js b/core/frontend/services/routing/router-manager.js index 9926e92998..d939034825 100644 --- a/core/frontend/services/routing/router-manager.js +++ b/core/frontend/services/routing/router-manager.js @@ -108,9 +108,11 @@ class RouterManager { this.siteRouter.mountRouter(unsubscribeRouter.router()); this.registry.setRouter('unsubscribeRouter', unsubscribeRouter); - const emailRouter = new EmailRouter(RESOURCE_CONFIG); - this.siteRouter.mountRouter(emailRouter.router()); - this.registry.setRouter('emailRouter', emailRouter); + if (RESOURCE_CONFIG.QUERY.email) { + const emailRouter = new EmailRouter(RESOURCE_CONFIG); + this.siteRouter.mountRouter(emailRouter.router()); + this.registry.setRouter('emailRouter', emailRouter); + } const previewRouter = new PreviewRouter(RESOURCE_CONFIG); this.siteRouter.mountRouter(previewRouter.router());