🐛 Fixed missing benefits from signup page

- tiers api structure changed how benefits data is returned
- transformation of tier benefits was missing a return

ghost/portal/src/utils/helpers.js

@@ -732,7 +732,7 @@ function createYearlyPrice({tier, priceId}) {
 }
 
 function createBenefits({tier}) {
-    tier?.benefits?.map((benefit) => {
+    return tier?.benefits?.map((benefit) => {
         return {
             name: benefit
         };

ghost/portal/src/utils/helpers.test.js

@@ -1,6 +1,6 @@
-import {getCurrencySymbol, getFreeProduct, getMemberName, getMemberSubscription, getPriceFromSubscription, getPriceIdFromPageQuery, getSupportAddress, hasMultipleProducts, isActiveOffer, isInviteOnlySite, isPaidMember, isSameCurrency} from './helpers';
+import {getCurrencySymbol, getFreeProduct, getMemberName, getMemberSubscription, getPriceFromSubscription, getPriceIdFromPageQuery, getSupportAddress, hasMultipleProducts, isActiveOffer, isInviteOnlySite, isPaidMember, isSameCurrency, transformApiTiersData} from './helpers';
 import * as Fixtures from './fixtures-generator';
-import {site as FixturesSite, member as FixtureMember, offer as FixtureOffer} from '../utils/test-fixtures';
+import {site as FixturesSite, member as FixtureMember, offer as FixtureOffer, transformTierFixture as TransformFixtureTiers} from '../utils/test-fixtures';
 import {isComplimentaryMember} from '../utils/helpers';
 
 describe('Helpers - ', () => {
@@ -236,4 +236,13 @@ describe('Helpers - ', () => {
             expect(value).toBe(expectedPriceId);
         });
     });
+
+    describe('transformApiTiersData - ', () => {
+        test('can correctly transform tiers data ', () => {
+            const transformedTiers = transformApiTiersData({tiers: TransformFixtureTiers});
+
+            expect(transformedTiers[0].benefits).toHaveLength(2);
+            expect(transformedTiers[1].benefits).toHaveLength(3);
+        });
+    });
 });

ghost/portal/src/utils/test-fixtures.js

@@ -1,7 +1,30 @@
 /* eslint-disable no-unused-vars*/
 import {getFreeProduct, getMemberData, getOfferData, getPriceData, getProductData, getSiteData, getSubscriptionData, getTestSite} from './fixtures-generator';
 
-const singleSiteTier = [
+export const transformTierFixture = [
+    getFreeProduct({
+        name: 'Free',
+        description: 'Free tier description',
+        numOfBenefits: 2
+    })
+    ,
+    getProductData({
+        name: 'Bronze',
+        // description: 'Access to all members articles',
+        description: '',
+        monthlyPrice: getPriceData({
+            interval: 'month',
+            amount: 700
+        }),
+        yearlyPrice: getPriceData({
+            interval: 'year',
+            amount: 7000
+        }),
+        numOfBenefits: 3
+    })
+];
+
+export const singleSiteTier = [
     getFreeProduct({
         name: 'Free',
         description: 'Free tier description',