From f478e4f9c83d2ffa5ca18791aa801d793e4121aa Mon Sep 17 00:00:00 2001
From: kirrg001 <katharina.irrgang@googlemail.com>
Date: Tue, 19 Sep 2017 11:56:45 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20=20Enabled=20Unsplash=20by=20def?=
 =?UTF-8?q?ault?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

refs https://github.com/TryGhost/Ghost/issues/8859

There are four cases:

- unsplash setting is empty (default), admin can enable the app by default (hardcoded isActive:true)
- unsplash settings are set, unsplash is disabled, admin detects that app was disabled on purpose
- unsplash setting is set, unsplash is enabled and has a key, app is enabled, old key get's ignored and overridden on the next save
- unsplash setting is set, unsplash is enabled and has no key, app is enabled
---
 core/server/data/schema/default-settings.json    | 2 +-
 core/test/functional/routes/api/settings_spec.js | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/core/server/data/schema/default-settings.json b/core/server/data/schema/default-settings.json
index 7a58349997..6ce0109b4f 100644
--- a/core/server/data/schema/default-settings.json
+++ b/core/server/data/schema/default-settings.json
@@ -82,7 +82,7 @@
             "defaultValue": "[{\"url\":\"\"}]"
         },
         "unsplash": {
-            "defaultValue": ""
+            "defaultValue": "{\"isActive\": true}"
         }
     },
     "theme": {
diff --git a/core/test/functional/routes/api/settings_spec.js b/core/test/functional/routes/api/settings_spec.js
index 9ed9a5c35b..be411ede4f 100644
--- a/core/test/functional/routes/api/settings_spec.js
+++ b/core/test/functional/routes/api/settings_spec.js
@@ -1,4 +1,5 @@
 var should = require('should'),
+    _ = require('lodash'),
     supertest = require('supertest'),
     testUtils = require('../../../utils'),
     config = require('../../../../../core/server/config'),
@@ -48,6 +49,10 @@ describe('Settings API', function () {
                 should.exist(jsonResponse);
 
                 testUtils.API.checkResponse(jsonResponse, 'settings');
+
+                JSON.parse(_.find(jsonResponse.settings, {key: 'unsplash'}).value).isActive.should.eql(true);
+                JSON.parse(_.find(jsonResponse.settings, {key: 'amp'}).value).should.eql(true);
+
                 done();
             });
     });