Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-01 02:41:39 -05:00
Code Issues Activity

🐛 Fixed incorrect automatic CSV download when bulk-deleting members

Browse source 
closes https://github.com/TryGhost/Team/issues/1265

- we were generating the correct query params for the export endpoint but those query params weren't applied to the export URL before fetching it meaning the default GET behaviour of listing first 15 members was always being used when generating the backup CSV
This commit is contained in:
Kevin Ansfield 2022-01-05 12:21:52 +00:00
parent 6a673ce8e1
commit f1bcb073a3
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/controllers/members.js
View file

@ -428,9 +428,9 @@ export default class MembersController extends Controller {
// needs to fetch the file and trigger a download directly rather than
// via an iframe. The iframe approach can't tell us when a download has
// started/finished meaning we could end up deleting the data before exporting it
const exportUrl = ghostPaths().url.api('members/upload');
const exportParams = new URLSearchParams(this.getApiQueryObject());
exportParams.set('limit', 'all');
const exportUrl = `${ghostPaths().url.api('members/upload')}?${exportParams.toString()}`;
yield fetch(exportUrl, {method: 'GET'})
.then(res => res.blob())

9
ghost/admin/tests/acceptance/members-test.js
View file

@ -180,10 +180,19 @@ describe('Acceptance: Members', function () {
expect(find('[data-test-modal="delete-members"]')).to.exist;
expect(find('[data-test-text="delete-count"]')).to.have.text('5 members');
// ensure export endpoint gets hit with correct query params when deleting
let exportQueryParams;
this.server.get('/members/upload', (schema, request) => {
exportQueryParams = request.queryParams;
});
await click('[data-test-button="confirm"]');
expect(exportQueryParams).to.deep.equal({filter: 'label:[label-0]', limit: 'all'});
expect(find('[data-test-text="deleted-count"]')).to.have.text('5 members');
expect(find('[data-test-button="confirm"]')).to.not.exist;
// members filter is reset
// TODO: fix query params reset for empty strings
expect(currentURL()).to.equal('/members?search=');