Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

🐛 Fixed AssetHelper not working with svg (#13978)

Browse source 
loses TryGhost#13971

This fixes an issue with links containing # anchor. It makes sure the # part is at the end of the url like url?v=hash#anhor

Co-authored-by: Hannah Wolfe <github.erisds@gmail.com>
This commit is contained in:
Torsten Zander 2022-02-07 16:07:18 +01:00 • committed by GitHub
parent af240816d8
commit f1b71f7fd7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
core/frontend/meta/asset-url.js
View file

@ -41,9 +41,20 @@ function getAssetUrl(path, hasMinFile) {
config.set('assetHash', (crypto.createHash('md5').update(Date.now().toString()).digest('hex')).substring(0, 10)); config.set('assetHash', (crypto.createHash('md5').update(Date.now().toString()).digest('hex')).substring(0, 10));
} }
// if url has # make sure the hash is at th right place
let anchor;
if (path.match('#')) {
const index = output.indexOf('#');
anchor = output.substring(index);
output = output.slice(0, index);
}
// Finally add the asset hash to the output URL // Finally add the asset hash to the output URL
output += '?v=' + config.get('assetHash'); output += '?v=' + config.get('assetHash');
if (anchor) {
output += anchor;
}
return output; return output;
} }

5
test/unit/frontend/meta/asset-url.test.js
View file

@ -34,6 +34,11 @@ describe('getAssetUrl', function () {
testUrl.should.equal('/public/myfile.js?v=' + config.get('assetHash')); testUrl.should.equal('/public/myfile.js?v=' + config.get('assetHash'));
}); });
it('should return hash before #', function () {
const testUrl = getAssetUrl('myfile.svg#arrow-up');
testUrl.should.equal(`/assets/myfile.svg?v=${config.get('assetHash')}#arrow-up`);
});
describe('favicon', function () { describe('favicon', function () {
it('should not add asset to url if favicon.ico', function () { it('should not add asset to url if favicon.ico', function () {
const testUrl = getAssetUrl('favicon.ico'); const testUrl = getAssetUrl('favicon.ico');