Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-13 22:41:32 -05:00
Code Issues Activity

Removed paid conversions column from incoming recommendations

Browse source 
fixes https://github.com/TryGhost/Product/issues/3968
This commit is contained in:
Simon Backx 2023-09-28 15:20:46 +02:00 • committed by Simon Backx
parent 44ad71e06a
commit f1a2565ac2
1 changed files with 7 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
apps/admin-x-settings/src/components/settings/site/recommendations/IncomingRecommendationList.tsx
View file

@ -18,7 +18,7 @@ interface IncomingRecommendationListProps {
const IncomingRecommendationItem: React.FC<{mention: Mention, stats: ReferrerHistoryItem[]}> = ({mention, stats}) => { const IncomingRecommendationItem: React.FC<{mention: Mention, stats: ReferrerHistoryItem[]}> = ({mention, stats}) => {
const cleanedSource = mention.source.replace('/.well-known/recommendations.json', ''); const cleanedSource = mention.source.replace('/.well-known/recommendations.json', '');
const {signups, paidConversions, hasPaidColumn} = useMemo(() => { const signups = useMemo(() => {
// Note: this should match the `getDomainFromUrl` method from OutboundLinkTagger // Note: this should match the `getDomainFromUrl` method from OutboundLinkTagger
let cleanedDomain = cleanedSource; let cleanedDomain = cleanedSource;
try { try {
@ -27,19 +27,12 @@ const IncomingRecommendationItem: React.FC<{mention: Mention, stats: ReferrerHis
// Ignore invalid urls // Ignore invalid urls
} }
return stats.reduce((acc, stat) => { return stats.reduce((s, stat) => {
acc.hasPaidColumn = acc.hasPaidColumn || stat.paid_conversions > 0;
if (stat.source === cleanedDomain) { if (stat.source === cleanedDomain) {
acc.signups += stat.signups; return s + stat.signups;
acc.paidConversions += stat.paid_conversions;
return acc;
} }
return acc; return s;
}, { }, 0);
signups: 0,
paidConversions: 0,
hasPaidColumn: false
});
}, [stats, cleanedSource]); }, [stats, cleanedSource]);
const showDetails = () => { const showDetails = () => {
@ -47,8 +40,7 @@ const IncomingRecommendationItem: React.FC<{mention: Mention, stats: ReferrerHis
window.open(cleanedSource, '_blank'); window.open(cleanedSource, '_blank');
}; };
const freeMembersLabel = (signups - paidConversions) === 1 ? 'free member' : 'free members'; const freeMembersLabel = (signups) === 1 ? 'free member' : 'free members';
const paidConversionsLabel = (paidConversions === 1) ? 'paid member' : 'paid members';
return ( return (
<TableRow hideActions> <TableRow hideActions>
@ -63,14 +55,8 @@ const IncomingRecommendationItem: React.FC<{mention: Mention, stats: ReferrerHis
</div> </div>
</TableCell> </TableCell>
<TableCell className='hidden align-middle md:!visible md:!table-cell' onClick={showDetails}> <TableCell className='hidden align-middle md:!visible md:!table-cell' onClick={showDetails}>
{(signups - paidConversions) === 0 ? <span className="text-grey-500">-</span> : (<div className='-mt-px flex grow items-end gap-1'><span>{signups - paidConversions}</span><span className='-mb-px whitespace-nowrap text-sm lowercase text-grey-700'>{freeMembersLabel}</span></div>)} {signups === 0 ? <span className="text-grey-500">-</span> : (<div className='-mt-px flex grow items-end gap-1'><span>{signups}</span><span className='-mb-px whitespace-nowrap text-sm lowercase text-grey-700'>{freeMembersLabel}</span></div>)}
</TableCell> </TableCell>
{hasPaidColumn &&
<TableCell className='hidden align-middle md:!visible md:!table-cell' onClick={showDetails}>
{paidConversions === 0 && <span className="dark:text-grey-900">-</span>}
{paidConversions > 0 && (<div className='-mt-px flex grow items-end gap-1'><span>{paidConversions}</span><span className='whitespace-nowrap text-xs text-grey-700'>{paidConversionsLabel}</span></div>)}
</TableCell>
}
</TableRow> </TableRow>
); );
}; };