Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-01 02:41:39 -05:00
Code Issues Activity

Updated newsletter paywall cta design (#15111)

Browse source 
refs https://github.com/TryGhost/Team/issues/1705

- Made `max-width` smaller to avoid super-long lines
- Added `span` elements with `nowrap` to avoid one or two-word orphans

Co-authored-by: Rishabh <zrishabhgarg@gmail.com>
This commit is contained in:
Djordje Vlaisavljevic 2022-07-28 12:40:09 +02:00 • committed by GitHub
parent 590bd7bdb8
commit f0d1cf2d66
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ghost/core/core/server/services/mega/post-email-serializer.js
View file

@ -350,9 +350,9 @@ function renderPaywallCTA(post) {
style="position: relative; display: block; width: 100%; margin: 3em 0; padding: 0; height: 1px; border: 0; border-top: 1px solid #e5eff5;">
<h2
style="margin-top: 0; font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; line-height: 1.11em; font-weight: 700; text-rendering: optimizeLegibility; margin: 1.5em 0 0.5em 0; font-size: 26px;">
Subscribe to continue reading.</h2>
<p style="margin: 0 auto 1.5em auto; line-height: 1.6em; max-width: 480px;">Become a paid member of ${siteTitle} to get access to all
subscriber-only content.</p>
Subscribe to <span style="white-space: nowrap; font-size: 26px !important;">continue reading.</span></h2>
<p style="margin: 0 auto 1.5em auto; line-height: 1.6em; max-width: 440px;">Become a paid member of ${siteTitle} to get access to
<span style="white-space: nowrap;">all subscriber-only content.</span></p>
<div class="btn btn-accent" style="box-sizing: border-box; width: 100%; display: table;">
<table border="0" cellspacing="0" cellpadding="0" align="center"
style="border-collapse: separate; mso-table-lspace: 0pt; mso-table-rspace: 0pt; width: auto;">

8
ghost/core/test/unit/server/services/mega/post-email-serializer.test.js
View file

@ -105,12 +105,12 @@ describe('Post Email Serializer', function () {
let output = renderEmailForSegment(email, 'status:free');
output.html.should.containEql(`<p>Free content</p>`);
output.html.should.containEql(`Subscribe to continue reading`);
output.html.should.containEql(`Subscribe to`);
output.html.should.containEql(`https://site.com/blah/#/portal/signup`);
output.html.should.not.containEql(`<p>Members content</p>`);
output.plaintext.should.containEql(`Free content`);
output.plaintext.should.containEql(`Subscribe to continue reading`);
output.plaintext.should.containEql(`Subscribe to`);
output.plaintext.should.containEql(`https://site.com/blah/#/portal/signup`);
output.plaintext.should.not.containEql(`Members content`);
});
@ -146,12 +146,12 @@ describe('Post Email Serializer', function () {
let output = renderEmailForSegment(email, 'status:free');
output.html.should.containEql(`<p>Free content</p>`);
output.html.should.containEql(`Subscribe to continue reading`);
output.html.should.containEql(`Subscribe to`);
output.html.should.containEql(`https://site.com/blah/#/portal/signup`);
output.html.should.not.containEql(`<p>Members content</p>`);
output.plaintext.should.containEql(`Free content`);
output.plaintext.should.containEql(`Subscribe to continue reading`);
output.plaintext.should.containEql(`Subscribe to`);
output.plaintext.should.containEql(`https://site.com/blah/#/portal/signup`);
output.plaintext.should.not.containEql(`Members content`);
});