Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity

🎨 🔦 theme url is no longer defined in config

Browse source 
refs #6982
- it's for now defined where all theme properties get set: in api/settings.js
- it's not the best place, but for now the place where i think it makes the most sense
- see https://github.com/TryGhost/Ghost/blob/playground/core/server/api/settings.js#L63

[ci skip]
This commit is contained in:
kirrg001 2016-09-13 22:13:52 +02:00 • committed by Hannah Wolfe
parent bd4590d0b5
commit ef50c6a149
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/test/unit/config_spec.js
View file

@ -47,14 +47,13 @@ describe('Config', function () {
var themeConfig = config.get('theme'); var themeConfig = config.get('theme');
// This will fail if there are any extra keys // This will fail if there are any extra keys
themeConfig.should.have.keys('url', 'title', 'description', 'logo', 'cover', 'timezone'); themeConfig.should.have.keys('title', 'description', 'logo', 'cover', 'timezone');
}); });
it('should have the correct values for each key', function () { it('should have the correct values for each key', function () {
var themeConfig = config.get('theme'); var themeConfig = config.get('theme');
// Check values are as we expect // Check values are as we expect
themeConfig.should.have.property('url', 'http://my-ghost-blog.com');
themeConfig.should.have.property('title', 'casper'); themeConfig.should.have.property('title', 'casper');
themeConfig.should.have.property('description', 'casper'); themeConfig.should.have.property('description', 'casper');
themeConfig.should.have.property('logo', 'casper'); themeConfig.should.have.property('logo', 'casper');
@ -69,7 +68,6 @@ describe('Config', function () {
// Check values are as we expect // Check values are as we expect
themeConfig.should.have.property('timezone', 'Etc/UTC'); themeConfig.should.have.property('timezone', 'Etc/UTC');
themeConfig.should.have.property('url');
configUtils.set({ configUtils.set({
theme: { theme: {
@ -77,8 +75,7 @@ describe('Config', function () {
} }
}); });
config.theme.should.have.property('timezone', 'Africa/Cairo'); config.get('theme').should.have.property('timezone', 'Africa/Cairo');
config.theme.should.have.property('url');
}); });
it('should set theme object with timezone by default', function () { it('should set theme object with timezone by default', function () {
@ -87,7 +84,6 @@ describe('Config', function () {
// Check values are as we expect // Check values are as we expect
themeConfig.should.have.property('theme'); themeConfig.should.have.property('theme');
themeConfig.theme.should.have.property('timezone', 'Etc/UTC'); themeConfig.theme.should.have.property('timezone', 'Etc/UTC');
themeConfig.theme.should.have.property('url');
}); });
}); });