Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-25 02:31:59 -05:00
Code Issues Activity

Refined source attribution table on dashboard

Browse source 
- added back 2 column design for source attribution table
This commit is contained in:
Rishabh 2022-10-07 13:01:48 +05:30 • committed by Rishabh Garg
parent 9fc830e662
commit ed688f2cd7
1 changed files with 8 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
ghost/admin/app/components/member-attribution/source-attribution-table.hbs
View file

@ -1,22 +1,18 @@
<div ...attributes> <div ...attributes>
<div class="gh-dashboard-list-header"> <div class="gh-dashboard-list-header">
<div class="gh-dashboard-list-title gh-dashboard-list-title-sources">Sources</div> <div class="gh-dashboard-list-title gh-dashboard-list-title-sources">Sources</div>
{{#if (eq @sortColumn "signups")}} <div
class="gh-dashboard-list-title {{if (eq @sortColumn "signups") "sorted-by"}}"
>
Free signups{{svg-jar "arrow-down-fill"}}
</div>
{{#if this.membersUtils.paidMembersEnabled}}
<div <div
class="gh-dashboard-list-title {{if (eq @sortColumn "signups") "sorted-by"}}" class="gh-dashboard-list-title {{if (eq @sortColumn "paid") "sorted-by"}}"
> >
Free signups{{svg-jar "arrow-down-fill"}} <span class="hide-when-small">Paid </span>Conversions{{svg-jar "arrow-down-fill"}}
</div> </div>
{{/if}} {{/if}}
{{#if (eq @sortColumn "paid")}}
{{#if this.membersUtils.paidMembersEnabled}}
<div
class="gh-dashboard-list-title {{if (eq @sortColumn "paid") "sorted-by"}}"
>
<span class="hide-when-small">Paid </span>Conversions{{svg-jar "arrow-down-fill"}}
</div>
{{/if}}
{{/if}}
</div> </div>
<div class="gh-dashboard-list-body"> <div class="gh-dashboard-list-body">
{{#each this.sources as |sourceData|}} {{#each this.sources as |sourceData|}}
@ -26,7 +22,6 @@
{{!-- <sup class="gh-dashboard-list-asterisk">*</sup> --}} {{!-- <sup class="gh-dashboard-list-asterisk">*</sup> --}}
</span> </span>
</div> </div>
{{#if (eq @sortColumn "signups")}}
<div class="gh-dashboard-list-item-sub gh-dashboard-list-item-sub-signup {{if (eq @sortColumn "signups") "sorted-by"}}"> <div class="gh-dashboard-list-item-sub gh-dashboard-list-item-sub-signup {{if (eq @sortColumn "signups") "sorted-by"}}">
{{#if sourceData.signups}} {{#if sourceData.signups}}
<span class="gh-dashboard-metric-minivalue"> <span class="gh-dashboard-metric-minivalue">
@ -38,8 +33,6 @@
</span> </span>
{{/if}} {{/if}}
</div> </div>
{{/if}}
{{#if (eq @sortColumn "paid")}}
{{#if this.membersUtils.paidMembersEnabled}} {{#if this.membersUtils.paidMembersEnabled}}
<div class="gh-dashboard-list-item-sub gh-dashboard-list-item-sub-paid {{if (eq @sortColumn "paid") "sorted-by"}}"> <div class="gh-dashboard-list-item-sub gh-dashboard-list-item-sub-paid {{if (eq @sortColumn "paid") "sorted-by"}}">
{{#if sourceData.paidConversions}} {{#if sourceData.paidConversions}}
@ -53,7 +46,6 @@
{{/if}} {{/if}}
</div> </div>
{{/if}} {{/if}}
{{/if}}
</div> </div>
{{/each}} {{/each}}
{{#if this.others}} {{#if this.others}}
@ -62,7 +54,6 @@
<span class="gh-dashboard-list-text" role="button" aria-label="Show sources" <span class="gh-dashboard-list-text" role="button" aria-label="Show sources"
{{on "click" this.openAllSources}}>Other sources <span class="gh-dashboard-list-item-other-source-arrow">→</span></span> {{on "click" this.openAllSources}}>Other sources <span class="gh-dashboard-list-item-other-source-arrow">→</span></span>
</div> </div>
{{#if (eq @sortColumn "signups")}}
<div class="gh-dashboard-list-item-sub"> <div class="gh-dashboard-list-item-sub">
{{#if this.others.signups}} {{#if this.others.signups}}
<span class="gh-dashboard-metric-minivalue"> <span class="gh-dashboard-metric-minivalue">
@ -74,8 +65,6 @@
</span> </span>
{{/if}} {{/if}}
</div> </div>
{{/if}}
{{#if (eq @sortColumn "paid")}}
{{#if this.membersUtils.paidMembersEnabled}} {{#if this.membersUtils.paidMembersEnabled}}
<div class="gh-dashboard-list-item-sub"> <div class="gh-dashboard-list-item-sub">
{{#if this.others.paidConversions}} {{#if this.others.paidConversions}}
@ -89,7 +78,6 @@
{{/if}} {{/if}}
</div> </div>
{{/if}} {{/if}}
{{/if}}
</div> </div>
{{/if}} {{/if}}
</div> </div>