Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
Code Issues Activity

Renamed PopupModal to PopupBox

Browse source 
refs https://github.com/TryGhost/Team/issues/1858

- PopupBox better reflects that it contains a Popup and is not a Popup
- In line with ContentBox, that contains the iframe with the comments content
This commit is contained in:
Simon Backx 2022-08-31 15:31:38 +02:00
parent fd7cebe906
commit e8eeacac9e
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/comments-ui/src/App.js
View file

@ -6,7 +6,7 @@ import AppContext from './AppContext';
import {hasMode} from './utils/check-mode'; import {hasMode} from './utils/check-mode';
import setupGhostApi from './utils/api'; import setupGhostApi from './utils/api';
import ContentBox from './components/ContentBox'; import ContentBox from './components/ContentBox';
import PopupModal from './components/PopupModal'; import PopupBox from './components/PopupBox';
function AuthFrame({adminUrl, onLoad}) { function AuthFrame({adminUrl, onLoad}) {
const iframeStyle = { const iframeStyle = {
@ -305,7 +305,7 @@ export default class App extends React.Component {
<ContentBox done={done} /> <ContentBox done={done} />
</CommentsFrame> </CommentsFrame>
<AuthFrame adminUrl={this.props.adminUrl} onLoad={this.initAdminAuth.bind(this)}/> <AuthFrame adminUrl={this.props.adminUrl} onLoad={this.initAdminAuth.bind(this)}/>
<PopupModal /> <PopupBox />
</AppContext.Provider> </AppContext.Provider>
</SentryErrorBoundary> </SentryErrorBoundary>
); );

2
apps/comments-ui/src/components/PopupModal.js → apps/comments-ui/src/components/PopupBox.js
View file

@ -3,7 +3,7 @@ import AppContext from '../AppContext';
import Pages from '../pages'; import Pages from '../pages';
import GenericPopup from './popups/GenericPopup'; import GenericPopup from './popups/GenericPopup';
export default function PopupModal(props) { export default function PopupBox(props) {
const {popup} = useContext(AppContext); const {popup} = useContext(AppContext);
// To make sure we can properly animate a popup that goes away, we keep a state of the last visible popup // To make sure we can properly animate a popup that goes away, we keep a state of the last visible popup