mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-24 23:48:13 -05:00
Fixed missing seo description in post preview modal
refs https://github.com/TryGhost/Team/issues/459 - the SERP description was not falling back to the server-side generated `excerpt` field on the post - removed outdated dynamic description generation from markdown card, should be replaced with dynamic description generation from mobiledoc if needed
This commit is contained in:
parent
4108ec735a
commit
e8970841d2
1 changed files with 1 additions and 23 deletions
|
@ -1,5 +1,4 @@
|
|||
import Component from '@glimmer/component';
|
||||
import formatMarkdown from 'ghost-admin/utils/format-markdown';
|
||||
import {inject as service} from '@ember/service';
|
||||
|
||||
export default class ModalPostPreviewSocialComponent extends Component {
|
||||
|
@ -9,7 +8,6 @@ export default class ModalPostPreviewSocialComponent extends Component {
|
|||
get _fallbackDescription() {
|
||||
return this.args.post.customExcerpt ||
|
||||
this.serpDescription ||
|
||||
this.args.post.excerpt ||
|
||||
this.settings.get('description');
|
||||
}
|
||||
|
||||
|
@ -43,27 +41,7 @@ export default class ModalPostPreviewSocialComponent extends Component {
|
|||
}
|
||||
|
||||
get serpDescription() {
|
||||
const metaDescription = this.args.post.metaDescription;
|
||||
|
||||
if (metaDescription) {
|
||||
return metaDescription;
|
||||
}
|
||||
|
||||
const mobiledoc = this.args.post.scratch;
|
||||
const [markdownCard] = (mobiledoc && mobiledoc.cards) || [];
|
||||
const markdown = markdownCard && markdownCard[1] && markdownCard[1].markdown;
|
||||
|
||||
let serpDescription;
|
||||
|
||||
const div = document.createElement('div');
|
||||
div.innerHTML = formatMarkdown(markdown, false);
|
||||
|
||||
// Strip HTML
|
||||
serpDescription = div.textContent;
|
||||
// Replace new lines and trim
|
||||
serpDescription = serpDescription.replace(/\n+/g, ' ').trim();
|
||||
|
||||
return serpDescription;
|
||||
return this.args.post.metaDescription || this.args.post.excerpt;
|
||||
}
|
||||
|
||||
// Facebook
|
||||
|
|
Loading…
Add table
Reference in a new issue