Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Add rss to the list of reserved post titles/slugs.

Browse source 
closes #1880
- added `rss` to core/server/models `generateSlug` reserved keywords
- added integration test for safe slug generation to core/test/integration/model/model_posts_spec.js
This commit is contained in:
nicovalencia 2014-01-07 16:08:28 -07:00
parent 8f02b3341b
commit e8746a2375
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/server/models/base.js
View file

@ -227,7 +227,7 @@ ghostBookshelf.Model = ghostBookshelf.Model.extend({
// Remove non ascii characters
slug = unidecode(slug);
// Check the filtered slug doesn't match any of the reserved keywords
slug = /^(ghost|ghost\-admin|admin|wp\-admin|wp\-login|dashboard|logout|login|signin|signup|signout|register|archive|archives|category|categories|tag|tags|page|pages|post|posts|user|users)$/g
slug = /^(ghost|ghost\-admin|admin|wp\-admin|wp\-login|dashboard|logout|login|signin|signup|signout|register|archive|archives|category|categories|tag|tags|page|pages|post|posts|user|users|rss)$/g
.test(slug) ? slug + '-post' : slug;
//if slug is empty after trimming use "post"

12
core/test/integration/model/model_posts_spec.js
View file

@ -255,6 +255,18 @@ describe('Post Model', function () {
}).then(null, done);
});
it('can generate a safe slug when a reserved keyword is used', function(done) {
var newPost = {
title: 'rss',
markdown: 'Test Content 1'
};
PostModel.add(newPost).then(function (createdPost) {
createdPost.get('slug').should.not.equal('rss');
done();
});
});
it('can generate slugs without non-ascii characters', function (done) {
var newPost = {
title: 'भुते धडकी भरवणारा आहेत',