Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Ensured that we do not insert orphaned rows (#190)

Browse source 
no-issue

Previously we would blindly put subscriptions into the database when we
received a webhook, which could result in orphaned rows that were not
linked to a customer (and by extension a member)

This updates the logic so that we will only add subscriptions if we have
a record of their customer.

Customers are only added during a checkout.session.completed webhook, at
which point a member is guarunteed, but for formailty and safety against
changes in the flow, the logic has been applied to inserting customers
too.
This commit is contained in:
Fabien 'egg' O'Carroll 2020-07-24 15:39:01 +02:00 • committed by GitHub
parent 20e3b6cc8a
commit e7484638e3
2 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
ghost/members-api/index.js
View file

@ -41,6 +41,7 @@ module.exports = function MembersApi({
const {encodeIdentityToken, decodeToken} = Tokens({privateKey, publicKey, issuer});
const metadata = Metadata({
Member,
StripeWebhook,
StripeCustomer,
StripeCustomerSubscription

20
ghost/members-api/lib/metadata.js
View file

@ -1,4 +1,5 @@
module.exports = function ({
Member,
StripeWebhook,
StripeCustomer,
StripeCustomerSubscription
@ -9,15 +10,26 @@ module.exports = function ({
}
if (metadata.customer) {
await StripeCustomer.upsert(metadata.customer, {
customer_id: metadata.customer.customer_id
const member = await Member.findOne({
id: metadata.customer.member_id
});
if (member) {
await StripeCustomer.upsert(metadata.customer, {
customer_id: metadata.customer.customer_id
});
}
}
if (metadata.subscription) {
await StripeCustomerSubscription.upsert(metadata.subscription, {
subscription_id: metadata.subscription.subscription_id
const customer = await StripeCustomer.findOne({
customer_id: metadata.subscription.customer_id
});
if (customer) {
await StripeCustomerSubscription.upsert(metadata.subscription, {
subscription_id: metadata.subscription.subscription_id
});
}
}
if (metadata.webhook) {