Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Fixed member list not loading on scroll with filtering

Browse source 
closes https://github.com/TryGhost/Team/issues/971
reverts abe5c6d681

We use vertical-collection to allow infinite loading + scrolling for members list instead of loading and rendering all members at once. The behavior was not working correctly with updated list for filtering feature, as we dynamically update columns. This change fixes the scroll behavior and members loading together by updating the containerSelector for vertical collection.
This commit is contained in:
Rishabh 2021-09-07 16:42:20 +05:30
parent 35209cd5c0
commit e70e0e273d
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/styles/components/lists.css
View file

@ -302,7 +302,7 @@ ul.nostyle li {
position: relative;
overflow: scroll;
max-width: calc(100% + 96px);
/* height: calc(100vh - 96px); */
height: calc(100vh - 96px);
margin: 0 -48px -81px;
padding: 0 48px 0 0;
}

3
ghost/admin/app/templates/members.hbs
View file

@ -33,6 +33,7 @@
<GhMembersFilterLabs
@isFiltered={{this.isFiltered}}
@onApplyFilter={{this.applyFilter}}
@defaultFilterParam={{this.defaultFilterParam}}
@onApplySoftFilter={{this.applySoftFilter}}
@onResetSoftFilter={{this.resetSoftFilter}}
@onResetFilter={{this.resetFilter}}
@ -126,7 +127,7 @@
{{/each}}
</tr>
</thead>
<VerticalCollection @tagName="tbody" @items={{this.members}} @key="id" @containerSelector=".gh-main" @estimateHeight={{69}} @staticHeight={{true}} @bufferSize={{20}} as |member|>
<VerticalCollection @tagName="tbody" @items={{this.members}} @key="id" @containerSelector=".gh-list-scrolling" @estimateHeight={{69}} @staticHeight={{true}} @bufferSize={{20}} as |member|>
<GhMembersListItemLabs
@member={{member}}
@filterColumns={{this.filterColumns}}