Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-18 02:21:47 -05:00
Code Issues Activity

Removed cookie based caching

Browse source 
no-issue

This was just a temporary stopgap. The correct solution is to cache in the backend
This commit is contained in:
Fabien O'Carroll 2019-10-08 13:25:07 +07:00
parent baee3ad0ac
commit e6c8f77d4e
1 changed files with 0 additions and 80 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

80
ghost/members-ssr/index.js
View file

@ -20,7 +20,6 @@ const {
*/
const SIX_MONTHS_MS = 1000 * 60 * 60 * 24 * 184;
const ONE_DAY_MS = 1000 * 60 * 60 * 24;
class MembersSSR {
/**
@ -31,8 +30,6 @@ class MembersSSR {
* @prop {boolean} [cookieSecure = true] - Whether the cookie should have Secure flag
* @prop {string} [cookieName] - The name of the members-ssr cookie
* @prop {number} [cookieMaxAge] - The max age in ms of the members-ssr cookie
* @prop {string} [cookieCacheName] - The name of the members-ssr-cache cookie
* @prop {number} [cookieCacheMaxAge] - The max age in ms of the members-ssr-cache cookie
* @prop {string} [cookiePath] - The Path flag for the cookie
*/
@ -46,8 +43,6 @@ class MembersSSR {
cookieSecure = true,
cookieName = 'members-ssr',
cookieMaxAge = SIX_MONTHS_MS,
cookieCacheName = 'members-ssr-cache',
cookieCacheMaxAge = ONE_DAY_MS,
cookiePath = '/',
cookieKeys,
getMembersApi
@ -64,7 +59,6 @@ class MembersSSR {
}
this.sessionCookieName = cookieName;
this.cacheCookieName = cookieCacheName;
/**
* @type SetCookieOptions
@ -77,17 +71,6 @@ class MembersSSR {
path: cookiePath
};
/**
* @type SetCookieOptions
*/
this.cacheCookieOptions = {
signed: true,
httpOnly: true,
sameSite: 'lax',
maxAge: cookieCacheMaxAge,
path: cookiePath
};
/**
* @type CookiesOptions
*/
@ -154,60 +137,6 @@ class MembersSSR {
return value;
}
/**
* @method _removeCacheCookie
*
* @param {Request} req
* @param {Response} res
*/
_removeCacheCookie(req, res) {
const cookies = this._getCookies(req, res);
cookies.set(this.cacheCookieName, this.cacheCookieOptions);
}
/**
* @method _setCacheCookie
*
* @param {Request} req
* @param {Response} res
* @param {object} value
*/
_setCacheCookie(req, res, value) {
if (!value) {
return this._removeCacheCookie(req, res);
}
const cookies = this._getCookies(req, res);
cookies.set(this.cacheCookieName, JSON.stringify(value), this.cacheCookieOptions);
}
/**
* @method _getCacheCookie
*
* @param {Request} req
* @param {Response} res
*
* @returns {object|null} The cookie value
*/
_getCacheCookie(req, res) {
const cookies = this._getCookies(req, res);
const value = cookies.get(this.cacheCookieName, {signed: true});
if (!value) {
return null;
}
try {
const parsed = JSON.parse(value);
if (!parsed) {
throw new Error('Parsed value was falsy');
}
return parsed;
} catch (err) {
this._removeCacheCookie(req, res);
throw new BadRequestError({
message: `Invalid JSON found in cookie ${this.cacheCookieName}`
});
}
}
/**
* @method _getMemberDataFromToken
*
@ -269,7 +198,6 @@ class MembersSSR {
const member = await this._getMemberDataFromToken(token);
this._setSessionCookie(req, res, member.email);
this._setCacheCookie(req, res, member);
return member;
}
@ -283,7 +211,6 @@ class MembersSSR {
*/
async deleteSession(req, res) {
this._removeSessionCookie(req, res);
this._removeCacheCookie(req, res);
}
/**
@ -297,14 +224,7 @@ class MembersSSR {
async getMemberDataFromSession(req, res) {
const email = this._getSessionCookies(req, res);
const cachedMember = this._getCacheCookie(req, res);
if (cachedMember) {
return cachedMember;
}
const member = await this._getMemberIdentityData(email);
this._setCacheCookie(req, res, member);
return member;
}