From e54a8b5112f8d76cacea279fc24c1fc3a5bdd8cc Mon Sep 17 00:00:00 2001 From: Rish Date: Thu, 30 Apr 2020 13:34:29 +0530 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20next=20middleware=20call?= =?UTF-8?q?=20after=20magic=20link=20redirect?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit no issue We changed the magic link route handling from setting global value to just redirecting to frontend in [this](https://github.com/TryGhost/Ghost/commit/d8d5d6b7d095eb16406ad52b8feb5e8e57823452#diff-0d54454fd954b0203a71ec52df4bd4c0R96-R98) commit, but missed removing `next()` call which attempts to send response again causing Unhandled rejection error. This change simply removes the extra `next()` call --- core/server/services/members/middleware.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/core/server/services/members/middleware.js b/core/server/services/members/middleware.js index dd3140b130..87ebe2fe47 100644 --- a/core/server/services/members/middleware.js +++ b/core/server/services/members/middleware.js @@ -94,8 +94,6 @@ const createSessionFromMagicLink = async function (req, res, next) { // Do a standard 302 redirect res.redirect(redirectPath); - - next(); } catch (err) { common.logging.warn(err.message); return next();