0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00

Cleaned up some e2e/integration tests

- e2e tests are tests that cover critical functionality by booting ghost
- integration tests are more like unit tests, but need to initialise and use a db
- so settings shouldn't start Ghost, url service is critical and should be in integration, and preview is critical and should be in e2e
This commit is contained in:
Hannah Wolfe 2021-10-06 14:40:39 +01:00
parent 726db1c0ec
commit e4074286df
No known key found for this signature in database
GPG key ID: 9F8C7532D0A6BA55
3 changed files with 8 additions and 8 deletions

View file

@ -7,8 +7,8 @@ const should = require('should');
const sinon = require('sinon'); const sinon = require('sinon');
const supertest = require('supertest'); const supertest = require('supertest');
const cheerio = require('cheerio'); const cheerio = require('cheerio');
const testUtils = require('../../utils'); const testUtils = require('../utils');
const config = require('../../../core/shared/config'); const config = require('../../core/shared/config');
const ghost = testUtils.startGhost; const ghost = testUtils.startGhost;
let request; let request;

View file

@ -12,7 +12,7 @@ const testUtils = require('../../utils');
describe('Settings', function () { describe('Settings', function () {
before(function () { before(function () {
return testUtils.startGhost(); return testUtils.setup();
}); });
// Allowlist: Only this list needs updating when a core setting is added/removed/renamed // Allowlist: Only this list needs updating when a core setting is added/removed/renamed

View file

@ -2,11 +2,11 @@ const _ = require('lodash');
const should = require('should'); const should = require('should');
const sinon = require('sinon'); const sinon = require('sinon');
const rewire = require('rewire'); const rewire = require('rewire');
const testUtils = require('../../utils'); const testUtils = require('../utils');
const configUtils = require('../../utils/configUtils'); const configUtils = require('../utils/configUtils');
const models = require('../../../core/server/models'); const models = require('../../core/server/models');
const events = require('../../../core/server/lib/common/events'); const events = require('../../core/server/lib/common/events');
const UrlService = rewire('../../../core/frontend/services/url/UrlService'); const UrlService = rewire('../../core/frontend/services/url/UrlService');
/** /**
* @NOTE * @NOTE