From e3b302676b84579a18533c9ab76e12b2a2006c2d Mon Sep 17 00:00:00 2001
From: Matt Enlow <matt@novaugust.net>
Date: Sat, 14 Jun 2014 14:45:50 -0600
Subject: [PATCH] Create boundOneWay util function

Closes #2958
- Created `boundOneWay` util to extract common pattern of having a oneWay property that doesn't break its binding after being set
- Changed `EditorControllerMixin.willPublish`,  `PostSettingsMenuController.publishedAtValue` and `.slugValue` to use the new `boundOneWay` util
---
 core/client/controllers/post-settings-menu.js | 17 +++-------------
 core/client/mixins/editor-base-controller.js  |  9 ++-------
 core/client/utils/bound-one-way.js            | 20 +++++++++++++++++++
 3 files changed, 25 insertions(+), 21 deletions(-)
 create mode 100644 core/client/utils/bound-one-way.js

diff --git a/core/client/controllers/post-settings-menu.js b/core/client/controllers/post-settings-menu.js
index 262749580e..52adb3ec15 100644
--- a/core/client/controllers/post-settings-menu.js
+++ b/core/client/controllers/post-settings-menu.js
@@ -1,6 +1,7 @@
 /* global moment */
 import {parseDateString, formatDate} from 'ghost/utils/date-formatting';
 import SlugGenerator from 'ghost/models/slug-generator';
+import boundOneWay from 'ghost/utils/bound-one-way';
 
 var PostSettingsMenuController = Ember.ObjectController.extend({
     isStaticPage: function (key, val) {
@@ -29,21 +30,9 @@ var PostSettingsMenuController = Ember.ObjectController.extend({
         }
         return formatDate(moment());
     }.property('publishedAtValue'),
+    publishedAtValue: boundOneWay('published_at', formatDate),
 
-    publishedAtValue: function (key, value) {
-        if (arguments.length > 1) {
-            return value;
-        }
-        return formatDate(this.get('published_at'));
-    }.property('published_at'),
-
-    slugValue: function (key, value) {
-        if (arguments.length > 1) {
-            return value;
-        }
-        return this.get('slug');
-    }.property('slug'),
-
+    slugValue: boundOneWay('slug'),
     //Lazy load the slug generator for slugPlaceholder
     slugGenerator: Ember.computed(function () {
         return SlugGenerator.create({ghostPaths: this.get('ghostPaths')});
diff --git a/core/client/mixins/editor-base-controller.js b/core/client/mixins/editor-base-controller.js
index d0d797fde1..11cd5bab71 100644
--- a/core/client/mixins/editor-base-controller.js
+++ b/core/client/mixins/editor-base-controller.js
@@ -1,6 +1,7 @@
 /* global console */
 import MarkerManager from 'ghost/mixins/marker-manager';
 import PostModel from 'ghost/models/post';
+import boundOneWay from 'ghost/utils/bound-one-way';
 
 // this array will hold properties we need to watch
 // to know if the model has been changed (`controller.isDirty`)
@@ -19,12 +20,7 @@ var EditorControllerMixin = Ember.Mixin.create(MarkerManager, {
      * Only with a user-set value (via setSaveType action)
      * can the post's status change.
      */
-    willPublish: function (key, value) {
-        if (arguments.length > 1) {
-            return value;
-        }
-        return this.get('isPublished');
-    }.property('isPublished'),
+    willPublish: boundOneWay('isPublished'),
 
     // set by the editor route and `isDirty`. useful when checking
     // whether the number of tags has changed for `isDirty`.
@@ -120,7 +116,6 @@ var EditorControllerMixin = Ember.Mixin.create(MarkerManager, {
         tags.removeObjects(oldTags);
         oldTags.invoke('deleteRecord');
     },
-
     actions: {
         save: function () {
             var status = this.get('willPublish') ? 'published' : 'draft',
diff --git a/core/client/utils/bound-one-way.js b/core/client/utils/bound-one-way.js
new file mode 100644
index 0000000000..538895c5ef
--- /dev/null
+++ b/core/client/utils/bound-one-way.js
@@ -0,0 +1,20 @@
+/**
+ * Defines a property similarly to `Ember.computed.oneway`,
+ * save that while a `oneway` loses its binding upon being set,
+ * the `BoundOneWay` will continue to listen for upstream changes.
+ *
+ * This is an ideal tool for working with values inside of {{input}}
+ * elements.
+ * @param transform: a function to transform the **upstream** value.
+ */
+var BoundOneWay = function (upstream, transform) {
+    if (typeof transform !== 'function') {
+        //default to the identity function
+        transform = function (value) { return value; };
+    }
+    return function (key, value) {
+        return arguments.length > 1 ? value : transform(this.get(upstream));
+    }.property(upstream);
+};
+
+export default BoundOneWay;