From e34281695cf04ccfd4298dbb8830a9b16139c52b Mon Sep 17 00:00:00 2001 From: Rish Date: Fri, 12 Jul 2019 20:14:50 +0530 Subject: [PATCH] Removed `fast_finish: true` from Travis CI configuration no issue Based on reported upstream issues - https://github.com/travis-ci/travis-ci/issues/1696 We started receiving multiple notifications per build from Travis after enabling `allowed_failures` for node 12. It seems `allowed_failures` along with `fast_finish` don't work well in travis ci config, and sends a notification first for when main jobs are finished, and then for each `allowed_failure` job. It doesn't seem like the issue is fixed upstream based on above, so disabling `fast_finish` for now. --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 82137ff5cd..d9dcc461c2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -19,7 +19,6 @@ matrix: env: TEST_SUITE=lint allow_failures: - node_js: '12' - fast_finish: true install: - if [ "$TRAVIS_NODE_VERSION" == "12" ]; then yarn --ignore-engines; else yarn; fi before_script: @@ -38,4 +37,5 @@ notifications: rooms: - secure: KzvGpf6RFHgQ3BkppKM4OejFjJYxH60KkDDShet0a0v+j/03HF5Nx0S0Vl9O/F2dPt2qWvblKb3j9EKgB7RsoFSdZuOk7ijA9Duvn+p9RrLom0C9JxOA3ob065WAGyE0OGRm1P5H98loX/L+6oOHC4/qqGKXgz6gUdBtZBn/yo8= on_success: change + on_failure: always on_pull_requests: false