Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Added custom worker message handler

Browse source 
refs https://github.com/TryGhost/Ghost/issues/12496

- Handling logging in the main thread avoids file handle leaks which happen due to leaky implementation of bunyan logger (see referenced issue for more context)
- Bumped job-manager version to allow for `workerMessageHandler` callback funciton
This commit is contained in:
Naz 2021-02-22 19:37:31 +13:00 • committed by Kevin Ansfield
parent 179f4181c5
commit e30a21aa88
3 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
core/server/services/jobs/job-service.js
View file

@ -12,6 +12,11 @@ const errorHandler = (error, workerMeta) => {
logging.error(error);
sentry.captureException(error);
};
const jobManager = new JobManager({logging, errorHandler});
const workerMessageHandler = ({name, message}) => {
logging.info(`Worker for job ${name} sent a message: ${message}`);
};
const jobManager = new JobManager({logging, errorHandler, workerMessageHandler});
module.exports = jobManager;

2
package.json
View file

@ -49,7 +49,7 @@
"@tryghost/errors": "0.2.7",
"@tryghost/helpers": "1.1.37",
"@tryghost/image-transform": "1.0.3",
"@tryghost/job-manager": "0.7.1",
"@tryghost/job-manager": "0.8.0",
"@tryghost/kg-card-factory": "2.1.5",
"@tryghost/kg-default-atoms": "2.0.2",
"@tryghost/kg-default-cards": "3.1.0",

12
yarn.lock
View file

@ -465,15 +465,15 @@
optionalDependencies:
sharp "0.25.4"
"@tryghost/job-manager@0.7.1":
version "0.7.1"
resolved "https://registry.yarnpkg.com/@tryghost/job-manager/-/job-manager-0.7.1.tgz#bbbfc9679cada353f9ee82b31eb8d32febf4e246"
integrity sha512-I59N9MXggwwXpy2qsN6Xo9T4a/sijOURkp3CmCtGK9TSCE/q1Y2piZjLx2HUe19hRhbbDPvQifr4zCa556COjA==
"@tryghost/job-manager@0.8.0":
version "0.8.0"
resolved "https://registry.yarnpkg.com/@tryghost/job-manager/-/job-manager-0.8.0.tgz#b3e042b7dd6746d8e9e44b71c95d7e2ec75e2881"
integrity sha512-fXgyYaIw0ol99Kr1Nq0DDAH6sbgjIbUxQNsciQPPaUBqfPjdHEhRvrO+PD60nTAM1mZi74BnvCPJwoKAFMy6KA==
dependencies:
"@breejs/later" "4.0.2"
bree "4.1.0"
bree "4.1.1"
cron-validate "1.4.2"
fastq "1.10.0"
fastq "1.10.1"
p-wait-for "3.2.0"
"@tryghost/kg-card-factory@2.1.5":