From e14520115a2059a6968074412433e496064dfeb8 Mon Sep 17 00:00:00 2001 From: Naz Date: Wed, 1 Mar 2023 16:48:38 +0800 Subject: [PATCH] Extracted Image Importer test suite refs https://github.com/TryGhost/Toolbox/issues/523 refs https://github.com/TryGhost/Ghost/commit/3119a5cc4c5b00c3105854c93104ea39688197c2 - The "index.test.js" is doing too much, has to be broken down to allow things to move into new packages --- .../data/importer/importers/image.test.js | 59 +++++++++++++++++++ .../unit/server/data/importer/index.test.js | 54 ----------------- 2 files changed, 59 insertions(+), 54 deletions(-) create mode 100644 ghost/core/test/unit/server/data/importer/importers/image.test.js diff --git a/ghost/core/test/unit/server/data/importer/importers/image.test.js b/ghost/core/test/unit/server/data/importer/importers/image.test.js new file mode 100644 index 0000000000..d7e6562205 --- /dev/null +++ b/ghost/core/test/unit/server/data/importer/importers/image.test.js @@ -0,0 +1,59 @@ +const _ = require('lodash'); +const sinon = require('sinon'); + +const storage = require('../../../../../../core/server/adapters/storage'); +const ImageImporter = require('../../../../../../core/server/data/importer/importers/image'); + +describe('ImageImporter', function () { + it('has the correct interface', function () { + ImageImporter.type.should.eql('images'); + ImageImporter.preProcess.should.be.instanceof(Function); + ImageImporter.doImport.should.be.instanceof(Function); + }); + + it('does preprocess posts, users and tags correctly', function () { + let inputData = require('../../../../../utils/fixtures/import/import-data-1.json'); + let outputData = ImageImporter.preProcess(_.cloneDeep(inputData)); + + inputData = inputData.data.data; + outputData = outputData.data.data; + + inputData.posts[0].markdown.should.not.containEql('/content/images/my-image.png'); + inputData.posts[0].html.should.not.containEql('/content/images/my-image.png'); + outputData.posts[0].markdown.should.containEql('/content/images/my-image.png'); + outputData.posts[0].html.should.containEql('/content/images/my-image.png'); + + inputData.posts[0].markdown.should.not.containEql('/content/images/photos/cat.jpg'); + inputData.posts[0].html.should.not.containEql('/content/images/photos/cat.jpg'); + outputData.posts[0].markdown.should.containEql('/content/images/photos/cat.jpg'); + outputData.posts[0].html.should.containEql('/content/images/photos/cat.jpg'); + + inputData.posts[0].feature_image.should.eql('/images/my-image.png'); + outputData.posts[0].feature_image.should.eql('/content/images/my-image.png'); + + inputData.tags[0].feature_image.should.eql('/images/my-image.png'); + outputData.tags[0].feature_image.should.eql('/content/images/my-image.png'); + + inputData.users[0].profile_image.should.eql('/images/my-image.png'); + inputData.users[0].cover_image.should.eql('/images/photos/cat.jpg'); + outputData.users[0].profile_image.should.eql('/content/images/my-image.png'); + outputData.users[0].cover_image.should.eql('/content/images/photos/cat.jpg'); + }); + + it('does import the images correctly', function () { + const inputData = require('../../../../../utils/fixtures/import/import-data-1.json'); + + const storageApi = { + save: sinon.stub().returns(Promise.resolve()) + }; + + const storageSpy = sinon.stub(storage, 'getStorage').callsFake(function () { + return storageApi; + }); + + ImageImporter.doImport(inputData.images).then(function () { + storageSpy.calledOnce.should.be.true(); + storageApi.save.calledTwice.should.be.true(); + }); + }); +}); diff --git a/ghost/core/test/unit/server/data/importer/index.test.js b/ghost/core/test/unit/server/data/importer/index.test.js index dd765412f1..60106527a0 100644 --- a/ghost/core/test/unit/server/data/importer/index.test.js +++ b/ghost/core/test/unit/server/data/importer/index.test.js @@ -696,58 +696,4 @@ describe('Importer', function () { inputData.data.data.users[0].should.eql(outputData.data.data.users[0]); }); }); - - describe('ImageImporter', function () { - it('has the correct interface', function () { - ImageImporter.type.should.eql('images'); - ImageImporter.preProcess.should.be.instanceof(Function); - ImageImporter.doImport.should.be.instanceof(Function); - }); - - it('does preprocess posts, users and tags correctly', function () { - let inputData = require('../../../../utils/fixtures/import/import-data-1.json'); - let outputData = ImageImporter.preProcess(_.cloneDeep(inputData)); - - inputData = inputData.data.data; - outputData = outputData.data.data; - - inputData.posts[0].markdown.should.not.containEql('/content/images/my-image.png'); - inputData.posts[0].html.should.not.containEql('/content/images/my-image.png'); - outputData.posts[0].markdown.should.containEql('/content/images/my-image.png'); - outputData.posts[0].html.should.containEql('/content/images/my-image.png'); - - inputData.posts[0].markdown.should.not.containEql('/content/images/photos/cat.jpg'); - inputData.posts[0].html.should.not.containEql('/content/images/photos/cat.jpg'); - outputData.posts[0].markdown.should.containEql('/content/images/photos/cat.jpg'); - outputData.posts[0].html.should.containEql('/content/images/photos/cat.jpg'); - - inputData.posts[0].feature_image.should.eql('/images/my-image.png'); - outputData.posts[0].feature_image.should.eql('/content/images/my-image.png'); - - inputData.tags[0].feature_image.should.eql('/images/my-image.png'); - outputData.tags[0].feature_image.should.eql('/content/images/my-image.png'); - - inputData.users[0].profile_image.should.eql('/images/my-image.png'); - inputData.users[0].cover_image.should.eql('/images/photos/cat.jpg'); - outputData.users[0].profile_image.should.eql('/content/images/my-image.png'); - outputData.users[0].cover_image.should.eql('/content/images/photos/cat.jpg'); - }); - - it('does import the images correctly', function () { - const inputData = require('../../../../utils/fixtures/import/import-data-1.json'); - - const storageApi = { - save: sinon.stub().returns(Promise.resolve()) - }; - - const storageSpy = sinon.stub(storage, 'getStorage').callsFake(function () { - return storageApi; - }); - - ImageImporter.doImport(inputData.images).then(function () { - storageSpy.calledOnce.should.be.true(); - storageApi.save.calledTwice.should.be.true(); - }); - }); - }); });