Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

🐛 Fixed bookmark card display in member emails when using Gmail+Chrome

Browse source 
no issue

- updates `@tryghost/kg-default-cards` which contains two fixes
  - removes email-specific output being added to post html (had no visual impact due to use of conditional comments but keeps rendered html smaller+cleaner)
  - adds a background-url style to the thumbnail container to give two options for styling
- updates member email template styling to hide the `<img>` element in bookmark cards and use a background image instead to get consistent rendering across email clients
This commit is contained in:
Kevin Ansfield 2020-08-24 18:17:22 +01:00
parent 8b9c161ff9
commit e07e0a17c6
3 changed files with 10 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
core/server/services/mega/template.js
View file

@ -407,22 +407,16 @@ figure blockquote p {
}
.kg-bookmark-thumbnail {
position: relative;
min-width: 140px;
max-width: 180px;
max-height: 100%;
background-repeat: no-repeat;
background-size: cover;
background-position: center;
border-radius: 0 2px 2px 0;
}
.kg-bookmark-thumbnail img {
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 100%;
border-radius: 0 3px 3px 0;
object-fit: cover;
max-height: 100%;
display: none;
}
.kg-bookmark-metadata {

2
package.json
View file

@ -51,7 +51,7 @@
"@tryghost/job-manager": "0.1.0",
"@tryghost/kg-card-factory": "2.1.2",
"@tryghost/kg-default-atoms": "2.0.2",
"@tryghost/kg-default-cards": "2.6.0",
"@tryghost/kg-default-cards": "2.6.1",
"@tryghost/kg-markdown-html-renderer": "2.0.2",
"@tryghost/kg-mobiledoc-html-renderer": "3.0.1",
"@tryghost/magic-link": "0.4.13",

8
yarn.lock
View file

@ -452,10 +452,10 @@
resolved "https://registry.yarnpkg.com/@tryghost/kg-default-atoms/-/kg-default-atoms-2.0.2.tgz#b8a1143bb0fa559cd46a96181c91771a35a3547b"
integrity sha512-cV9FcTatyyf6QgOgNJ56sZmxu+rj3W105owcJatGuNtMx4hWrKupnvzxt7HXNBlAzwNrct7m9trrDFk+ghj1xw==
"@tryghost/kg-default-cards@2.6.0":
version "2.6.0"
resolved "https://registry.yarnpkg.com/@tryghost/kg-default-cards/-/kg-default-cards-2.6.0.tgz#c5662c6c0c8017ad798a9c28204220478755688d"
integrity sha512-r/820/Y+WxYcDTYxytfBeScABqBP13tXPrUlClnsWGGaTXTSsLOT8goDyuR+P1Q8U+ezYJQkk1EvdE55aDDEOw==
"@tryghost/kg-default-cards@2.6.1":
version "2.6.1"
resolved "https://registry.yarnpkg.com/@tryghost/kg-default-cards/-/kg-default-cards-2.6.1.tgz#36a6b8f6bf68ec14e2d00848cd66faf2fbe06207"
integrity sha512-EsLqsW4b59M1B5PyAybVI6zaNY5EJQ/1IQBmw3eVLGY4yJURzkQbcNygZgQ/0xXtjC5zypHMJiYuvgalf63QMw==
dependencies:
"@tryghost/kg-markdown-html-renderer" "^2.0.2"
"@tryghost/url-utils" "^0.6.14"