From dec6a4d72ad193557906329389b678af4c44e00f Mon Sep 17 00:00:00 2001 From: Hannah Wolfe Date: Thu, 12 May 2022 15:27:13 +0100 Subject: [PATCH] Removed unused getPaymentConfig method refs: https://github.com/TryGhost/Team/issues/1625 - this references unused stripe_product_name setting and defunct stripe_plans setting, but is not used anywhere --- core/server/services/members/api.js | 3 --- core/server/services/members/config.js | 19 ------------------- .../server/services/members/config.test.js | 6 ------ 3 files changed, 28 deletions(-) diff --git a/core/server/services/members/api.js b/core/server/services/members/api.js index f23cfbebce..4c4bafe08c 100644 --- a/core/server/services/members/api.js +++ b/core/server/services/members/api.js @@ -170,9 +170,6 @@ function createApiInstance(config) { } } }, - paymentConfig: { - stripe: config.getStripePaymentConfig() - }, models: { EmailRecipient: models.EmailRecipient, StripeCustomer: models.MemberStripeCustomer, diff --git a/core/server/services/members/config.js b/core/server/services/members/config.js index 4fd2646227..ab289caab8 100644 --- a/core/server/services/members/config.js +++ b/core/server/services/members/config.js @@ -98,25 +98,6 @@ class MembersConfigProvider { return this.getActiveStripeKeys() !== null; } - getStripePaymentConfig() { - if (!this.isStripeConnected()) { - return null; - } - - const stripeApiKeys = this.getActiveStripeKeys(); - - if (!stripeApiKeys) { - return null; - } - - return { - product: { - name: this._settingsCache.get('stripe_product_name') - }, - plans: this._settingsCache.get('stripe_plans') || [] - }; - } - getAuthSecret() { const hexSecret = this._settingsCache.get('members_email_auth_secret'); if (!hexSecret) { diff --git a/test/unit/server/services/members/config.test.js b/test/unit/server/services/members/config.test.js index 12961f3f3f..c4bf17fb35 100644 --- a/test/unit/server/services/members/config.test.js +++ b/test/unit/server/services/members/config.test.js @@ -67,12 +67,6 @@ describe('Members - config', function () { sinon.restore(); }); - it('Does not export webhookHandlerUrl', function () { - const paymentConfig = membersConfig.getStripePaymentConfig(); - - assert.equal(paymentConfig.webhookHandlerUrl, undefined, 'webhookHandlerUrl should not exist'); - }); - it('can get correct tokenConfig', function () { const {issuer, publicKey, privateKey} = membersConfig.getTokenConfig();