mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-24 23:48:13 -05:00
Removed Sentry error capturing for failed URL decoding
fix https://linear.app/tryghost/issue/SLO-79/incorrectusageerror-the-url-httpsblogkongregatecompercentc0-couldnt-be - we added this Sentry captureException whilst fixing a bug where decodeUrl could fail, and throw a 500 exception - we added handling for that case and returned an empty string, but we also added Sentry error capturing - at this point, I don't think we need to be capturing errors in Sentry, because the issue is already handled, and it only usually happens with malicious/incorrect URLs - this is our #2 cause of Sentry alerts, so it's good to clean it up
This commit is contained in:
parent
8483d96f08
commit
ddac3a9e8b
1 changed files with 0 additions and 2 deletions
|
@ -7,7 +7,6 @@
|
|||
const {metaData} = require('../services/proxy');
|
||||
const {SafeString} = require('../services/handlebars');
|
||||
const logging = require('@tryghost/logging');
|
||||
const sentry = require('../../shared/sentry');
|
||||
const errors = require('@tryghost/errors');
|
||||
|
||||
const {getMetaDataUrl} = metaData;
|
||||
|
@ -26,7 +25,6 @@ module.exports = function url(options) {
|
|||
message: `The url "${outputUrl}" couldn't be escaped correctly`,
|
||||
err: err
|
||||
});
|
||||
sentry.captureException(error);
|
||||
logging.error(error);
|
||||
|
||||
return new SafeString('');
|
||||
|
|
Loading…
Add table
Reference in a new issue