Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity

Better matching up the pages table with the posts table

Browse source 
refs https://github.com/TryGhost/Team/issues/1995
This commit is contained in:
James Morris 2022-09-28 14:17:12 +01:00
parent cd97341ed6
commit dc9ef69547
3 changed files with 14 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/components/posts-list/list-item-clicks.js
View file

@ -25,7 +25,7 @@ export default class PostsListItemClicks extends Component {
}
get isAnalytics() {
return ((!this.session.user.isContributor) && (this.args.post.isSent || this.args.post.isPublished) && (this.settings.get('emailTrackClicks') || this.feature.get('memberAttribution')));
return ((!this.session.user.isContributor) && this.args.post.isPost && (this.args.post.isSent || this.args.post.isPublished) && (this.settings.get('emailTrackClicks') || this.feature.get('memberAttribution')));
}
get routeForLink() {

3
ghost/admin/app/routes/pages.js
View file

@ -8,8 +8,7 @@ export default class PagesRoute extends PostsRoute {
buildRouteInfoMetadata() {
return {
titleToken: 'Pages',
mainClasses: this.feature.get('memberAttribution') ? ['gh-main-fullwidth'] : null
titleToken: 'Pages'
};
}
}

22
ghost/admin/app/templates/pages.hbs
View file

@ -29,16 +29,18 @@
<section class="view-container content-list">
<div class="{{if this.feature.memberAttribution 'gh-list-sticky'}}">
<ol class="pages-list gh-list {{unless this.postsInfinityModel "no-posts"}} {{if this.feature.memberAttribution 'feature-memberAttribution'}}">
{{#if this.postsInfinityModel}}
<li class="gh-list-row header">
<div class="gh-list-header gh-posts-title-header">Title</div>
<div class="gh-list-header gh-posts-status-header">{{#unless this.feature.memberAttribution}}Status{{/unless}}</div>
{{#if this.feature.memberAttribution}}
<div class="gh-list-header gh-posts-signups-header">Signups</div>
<div class="gh-list-header gh-posts-conversions-header">Conversions</div>
{{/if}}
</li>
{{/if}}
{{#unless this.feature.emailClicks}}
{{#if this.postsInfinityModel}}
<li class="gh-list-row header">
<div class="gh-list-header gh-posts-title-header">Title</div>
<div class="gh-list-header gh-posts-status-header">{{#unless this.feature.memberAttribution}}Status{{/unless}}</div>
{{#if this.feature.memberAttribution}}
<div class="gh-list-header gh-posts-signups-header">Signups</div>
<div class="gh-list-header gh-posts-conversions-header">Conversions</div>
{{/if}}
</li>
{{/if}}
{{/unless}}
{{#each this.postsInfinityModel as |page|}}
<PostsList::ListItem